From: Loic Poulain <loic.poulain@intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] Bluetooth: HCI H5 fast retransmit
Date: Thu, 07 Aug 2014 19:09:03 +0200 [thread overview]
Message-ID: <53E3B2AF.50605@intel.com> (raw)
In-Reply-To: <D672899E-220D-4633-A74A-9C50021C2AE8@holtmann.org>
Hi Marcel,
This patch is not so much out-of-scope of the H5 because specification
only gives "recommended parameters" regarding timeout calculation.
I tested it with only one H5 controller (rtl8723).
This mechanism is very beneficial with this controller due to a
relative high packet loss.
However I'm going to rework this patch to be more specific (only fast
retransmit if the invalid ack number is a duplicate of the last acked
packet)
+ comments.
I don't see any obvious H5 incompatibility issue, therefore, extra flag
shouldn't be required.
Regards,
Loic
--
Intel Open Source Technology Center
http://oss.intel.com/
next prev parent reply other threads:[~2014-08-07 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 16:37 [RFC] Bluetooth: HCI H5 fast retransmit Loic Poulain
2014-08-06 19:59 ` Marcel Holtmann
2014-08-07 17:09 ` Loic Poulain [this message]
2014-08-07 19:05 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2014-08-08 17:04 Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E3B2AF.50605@intel.com \
--to=loic.poulain@intel.com \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox