From: Martin Townsend <martin.townsend@xsilon.com>
To: Marcel Holtmann <marcel@holtmann.org>,
Alexander Aring <alex.aring@gmail.com>
Cc: linux-zigbee-devel@lists.sourceforge.net,
linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org
Subject: Re: [PATCH v2 bluetooth-next] Simplify lowpan receive path so skb is freed in lowpan_rcv when dropped.
Date: Wed, 27 Aug 2014 21:49:49 +0100 [thread overview]
Message-ID: <53FE446D.6040805@xsilon.com> (raw)
In-Reply-To: <3DF0C18C-4A97-4A00-AB0F-9E01F72CE967@holtmann.org>
On 21/08/14 14:24, Marcel Holtmann wrote:
> Hi Alex,
>
>> this patch wasn't able to apply and now it doesn't apply either (because
>> lot of other changes). I thought you will resend a v3 and then I will
>> care about reviewing. Then putting Acked-by, then Marcel will put it on
>> the right repositories.
>>
>> If you can, describe the changes in the commit msg (please note the 80
>> line width there).
>>
>> This patch is also something for bluetooth (not bluetooth-next), it's a
>> bug fix. But this depends how Marcel will dealing with this issue. It's
>> a bugfix with a huge change of lines. I would base it on bluetooth,
>> because it's a bug fix.
> simplifying something is not for -stable or a bug fix. If there is a memory leak, then fix that memory leak first in a separate patch. The rules are pretty clear here. Only bug fixes after the merge window has closed.
>
> Regards
>
> Marcel
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
I'll respin and include the memory leak fix and this patch and a couple
of others I have and send as a series to bluetooth. What bluetooth git
repository should I base the series on?
- Martin.
next prev parent reply other threads:[~2014-08-27 20:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 13:27 [PATCH v2 bluetooth-next] Simplify lowpan receive path so skb is freed in lowpan_rcv when dropped Martin Townsend
2014-08-04 8:13 ` Alexander Aring
2014-08-21 6:30 ` [Linux-zigbee-devel] " Martin Townsend
2014-08-21 8:39 ` Alexander Aring
2014-08-21 13:24 ` Marcel Holtmann
2014-08-27 20:49 ` Martin Townsend [this message]
2014-08-28 4:47 ` Alexander Aring
2014-08-28 5:19 ` Alexander Aring
2014-09-08 10:40 ` Alexander Aring
2014-09-08 18:13 ` Martin Townsend
2014-09-08 18:36 ` Alexander Aring
2014-09-08 18:55 ` Alexander Aring
2014-09-09 9:28 ` Martin Townsend
2014-09-09 9:46 ` Alexander Aring
2014-09-09 9:59 ` Alexander Aring
2014-09-09 10:17 ` Martin Townsend
2014-09-09 10:47 ` Alexander Aring
2014-09-09 11:13 ` Martin Townsend
2014-09-09 13:44 ` Marcel Holtmann
2014-09-10 0:18 ` Alexander Aring
2014-09-09 8:59 ` Martin Townsend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FE446D.6040805@xsilon.com \
--to=martin.townsend@xsilon.com \
--cc=alex.aring@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).