Re: [PATCH] gdbus: use caller's bus name in polkit authorization check

[Hannu Mallat <hannu.mallat@jollamobile.com>]

Hi Marcel,

> so I wrote this code in 2009 as it seems. I can not even judge if my
> code is correct or your change is the correct one. It has been too
> long ago. You would need to convince me which one is the correct
> behavior when it comes to PolicyKit.

quoting polkit documentation for subject struct,

     "This struct describes subjects such as UNIX processes. It is
     typically used to check if a given process is authorized for
     an action."

so as far as I can see, the struct should describe the caller of
the D-Bus method, not bluetoothd itself, if the idea is to limit certain
methods to authorized callers only.

In the end I don't know if polkit offers much over D-Bus daemon based
authorization, and I chose not to use polkit for my needs, but wanted to
point out the issue nevertheless if someone else might face the same
problem.

BR,
H.