linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@mozilla.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] Documentation: HAL IPC uses 4 octects for socket channel
Date: Tue, 03 Feb 2015 09:47:59 +0100	[thread overview]
Message-ID: <54D08B3F.5080202@mozilla.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

The documentations says that the HAL IPC uses 2 octets for socket
channels, while |struct hal_cmd_socket_{listen,connect}| contain 4
octets. This patch fixes the documentation accordingly.

[-- Attachment #2: 0001-Documentation-HAL-IPC-uses-4-octects-for-socket-chan.patch --]
[-- Type: text/x-patch, Size: 1479 bytes --]

>From 53c14fc8c07bf4196b61b3b7809dbe02313c49a7 Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann <tdz@users.sourceforge.net>
Date: Tue, 3 Feb 2015 09:37:47 +0100
Subject: [PATCH] Documentation: HAL IPC uses 4 octects for socket channel

The documentations says that the HAL IPC uses 2 octets for socket
channels, while |struct hal_cmd_socket_{listen,connect}| contain 4
octets. This patch fixes the documentation accordingly.

Signed-off-by: Thomas Zimmermann <tdz@users.sourceforge.net>
---
 android/hal-ipc-api.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index f15c12e..515cf4e 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -456,7 +456,7 @@ Commands and responses:
 		Command parameters: Socket type (1 octet)
 		                    Service name (256 octets)
 		                    Service UUID (16 octets)
-		                    Channel (2 octets)
+		                    Channel (4 octets)
 		                    Socket flags (1 octet)
 		Response parameters: File descriptor (inline)
 
@@ -474,7 +474,7 @@ Commands and responses:
 		Command parameters: Remote address (6 octets)
 		                    Socket type (1 octet)
 		                    Service UUID (16 octets)
-		                    Channel (2 octets)
+		                    Channel (4 octets)
 		                    Socket flags (1 octet)
 		Response parameters: File descriptor (inline)
 
-- 
1.7.10.4


             reply	other threads:[~2015-02-03  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03  8:47 Thomas Zimmermann [this message]
2015-02-03 11:35 ` [PATCH] Documentation: HAL IPC uses 4 octects for socket channel Szymon Janc
2015-02-03 11:45   ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D08B3F.5080202@mozilla.com \
    --to=tzimmermann@mozilla.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).