From: Thomas Zimmermann <tzimmermann@mozilla.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Documentation: HAL IPC uses 4 octects for socket channel
Date: Tue, 03 Feb 2015 12:45:04 +0100 [thread overview]
Message-ID: <54D0B4C0.8090801@mozilla.com> (raw)
In-Reply-To: <1883387.StZLWa3Uue@uw000953>
Hi
Am 03.02.2015 um 12:35 schrieb Szymon Janc:
> Hi Thomas,
>
> On Tuesday 03 of February 2015 09:47:59 Thomas Zimmermann wrote:
>> The documentations says that the HAL IPC uses 2 octets for socket
>> channels, while |struct hal_cmd_socket_{listen,connect}| contain 4
>> octets. This patch fixes the documentation accordingly.
> I've applied the patch, thanks.
>
> Some notes though:
> - I've fixed commit message prefix (we try to keep those consistent for
> easier history view)
> - I've removed SoB line - we don't use it in userspace code
> - for any future submissions please send patch inline (ie with git send-email)
> instead of attaching it
Thanks a lot and sorry about the issues. It's my first patch here, I'll
try to do better.
Best regards
Thomas
prev parent reply other threads:[~2015-02-03 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 8:47 [PATCH] Documentation: HAL IPC uses 4 octects for socket channel Thomas Zimmermann
2015-02-03 11:35 ` Szymon Janc
2015-02-03 11:45 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D0B4C0.8090801@mozilla.com \
--to=tzimmermann@mozilla.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).