From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: Jiri Slaby Message-ID: <54E5F0A4.9080300@suse.cz> Date: Thu, 19 Feb 2015 15:18:12 +0100 From: Jiri Slaby MIME-Version: 1.0 To: johan.hedberg@gmail.com CC: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Marcel Holtmann , Gustavo Padovan Subject: Re: [PATCH 1/1] Bluetooth: make hci_test_bit's addr const References: <1424354164-11728-1-git-send-email-jslaby@suse.cz> In-Reply-To: <1424354164-11728-1-git-send-email-jslaby@suse.cz> Content-Type: text/plain; charset=utf-8 List-ID: On 02/19/2015, 02:56 PM, Jiri Slaby wrote: > gcc5 warns about passing a const array to hci_test_bit which takes a > non-const pointer: > net/bluetooth/hci_sock.c: In function ‘hci_sock_sendmsg’: > net/bluetooth/hci_sock.c:955:8: warning: passing argument 2 of ‘hci_test_bit’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-array-qualifiers] > &hci_sec_filter.ocf_mask[ogf])) && > ^ > net/bluetooth/hci_sock.c:49:19: note: expected ‘void *’ but argument is of type ‘const __u32 (*)[4] {aka const unsigned int (*)[4]}’ > static inline int hci_test_bit(int nr, void *addr) > ^ > > So make 'addr' 'const void *'. > > Signed-off-by: Jiri Slaby > Cc: Marcel Holtmann > Cc: Gustavo Padovan > Cc: Johan Hedberg > --- > net/bluetooth/hci_sock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c > index 1d65c5be7c82..34a095ff8679 100644 > --- a/net/bluetooth/hci_sock.c > +++ b/net/bluetooth/hci_sock.c > @@ -46,7 +46,7 @@ struct hci_pinfo { > unsigned short channel; > }; > > -static inline int hci_test_bit(int nr, void *addr) > +static inline int hci_test_bit(int nr, const void *addr) > { > return *((__u32 *) addr + (nr >> 5)) & ((__u32) 1 << (nr & 31)); quite interestingly, the compiler doesn't complain against the cast... Will send a v2. -- js suse labs