From: Loic Poulain <loic.poulain@intel.com>
To: Peter Hurley <peter@hurleysoftware.com>,
Frederic Danis <frederic.danis@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org, gregkh@linuxfoundation.org,
jslaby@suse.cz
Subject: Re: [RFC 3/5] Bluetooth: hci_uart: Add HCIUARTSETBAUDRATE ioctl
Date: Fri, 03 Apr 2015 16:18:35 +0200 [thread overview]
Message-ID: <551EA13B.7010307@intel.com> (raw)
In-Reply-To: <551E9987.9050800@hurleysoftware.com>
Hi Peter,
On 03/04/2015 15:45, Peter Hurley wrote:
> The line discipline is always notified of line rate changes
> via the set_termios() method, so if you add that to the hci_ldisc,
> you'll be able to keep the BT device in sync with your
> vendor-specific commands.
If I'm not wrong, line discipline is notified after the tty termios change.
So, it's too late to send the HCI change speed command.
Moreover, user space is not aware of the device behavior, the driver should
be the only one to manage the device and its serial link.
Here, user space is just a bootstrap which hands over to the driver.
Regards,
Loic
--
Intel Open Source Technology Center
http://oss.intel.com/
next prev parent reply other threads:[~2015-04-03 14:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:37 [RFC 0/5] Move HCI UART vendor specific setup to kernel Frederic Danis
2015-04-02 14:37 ` [RFC 1/5] Bluetooth: hci_uart: Add HCIUARTSETDEVTYPE ioctl Frederic Danis
2015-04-02 14:57 ` Marcel Holtmann
2015-04-02 14:37 ` [RFC 2/5] Bluetooth: hci_uart: Add BCM specific setup function Frederic Danis
2015-04-02 14:37 ` [RFC 3/5] Bluetooth: hci_uart: Add HCIUARTSETBAUDRATE ioctl Frederic Danis
2015-04-02 15:12 ` Marcel Holtmann
2015-04-03 10:54 ` Peter Hurley
2015-04-03 12:49 ` Frederic Danis
2015-04-03 13:45 ` Peter Hurley
2015-04-03 13:56 ` Peter Hurley
2015-04-03 14:18 ` Loic Poulain [this message]
2015-04-03 15:45 ` Peter Hurley
2015-04-03 17:39 ` Marcel Holtmann
2015-04-04 23:05 ` Peter Hurley
2015-04-04 23:35 ` Marcel Holtmann
2015-04-05 1:22 ` Peter Hurley
2015-04-05 2:29 ` Marcel Holtmann
2015-04-10 12:07 ` Peter Hurley
2015-04-10 16:07 ` Marcel Holtmann
2015-04-10 16:45 ` Peter Hurley
2015-04-10 16:58 ` Marcel Holtmann
2015-04-02 14:37 ` [RFC 4/5] tty: Re-add external interface for tty_set_termios() Frederic Danis
2015-04-02 15:08 ` Marcel Holtmann
2015-04-02 14:37 ` [RFC 5/5] Bluetooth: hci_uart: Add BCM specific UART speed management Frederic Danis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551EA13B.7010307@intel.com \
--to=loic.poulain@intel.com \
--cc=frederic.danis@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).