From: Florian Grandel <fgrandel@gmail.com>
To: Arman Uguray <armansito@chromium.org>,
Johan Hedberg <johan.hedberg@gmail.com>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>
Subject: Test coverage for "add advertising" - timeouts, missing tests
Date: Tue, 26 May 2015 03:14:13 +0200 [thread overview]
Message-ID: <5563C8E5.3010008@gmail.com> (raw)
Hi Arman and Johan,
Marcel would like to see a test that covers an advertising instance
timeout to further reduce the potential for regressions caused by the
multi-advertising changes.
I may be mistaken but I think we do not have such a test in mgmt-tester,
yet.
(We do have tests that set a timeout in an add advertising call but the
timeout will not expire as the delayed work is canceled. This is
intended behavior - just not the test I would have to write.)
Today, Arman and I quickly discussed the possibility to test timeouts
and we first thought that the tester would support it. But then I
couldn't really find a hook to do so.
So now I'm left with a few questions:
- Did I overlook the hook to test timeouts?
- If not: Should we introduce one?
- If so: Is there a way to "simulate" the timeout in a way that doesn't
require us to actually wait for a second or even more? Otherwise timeout
tests would considerably slow down test execution.
And somewhat related a different problem that I encountered today:
- Is there a way to test that a given event is NOT being triggered by a
test case? Maybe there's a way to find out when no more events can be
expected so that we don't have to wait - which would considerably slow
down tests again and would not be reliable anyway?
Thanks for your help!
Florian
reply other threads:[~2015-05-26 1:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5563C8E5.3010008@gmail.com \
--to=fgrandel@gmail.com \
--cc=armansito@chromium.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).