Re: [PATCH] BlueZ line discipline baud rate setting update

[Frederic Danis <frederic.danis@linux.intel.com>]

Hello Marcel and Ilya,

On 15/06/2015 19:35, Marcel Holtmann wrote:
> Hi Ilya,
>
>> Bring the tty into a known 8 bits, 1 start bit, 1 stop bit,
>> hardware flow control state with a given baud rate.
>>
>> Signed-off-by: Ilya Faenson <ifaenson@broadcom.com>
>> ---
>> drivers/bluetooth/hci_ldisc.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
>> index ac87346..606cc5a 100644
>> --- a/drivers/bluetooth/hci_ldisc.c
>> +++ b/drivers/bluetooth/hci_ldisc.c
>> @@ -271,9 +271,16 @@ void hci_uart_set_baudrate(struct hci_uart *hu, unsigned int speed)
>> 	struct tty_struct *tty = hu->tty;
>> 	struct ktermios ktermios;
>>
>> +	/* Bring the UART into a known state with a given baud rate */
>> 	ktermios = tty->termios;
>> 	ktermios.c_cflag &= ~CBAUD;
>> -	ktermios.c_cflag |= BOTHER;
>> +	ktermios.c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR |
>> +			    IGNCR | ICRNL | IXON);
>
> I think this one needs to align like this:
>
> 			&= ~(IGNBRK | .. |
> 			     IGNCR | ..);
>
> However I can fix that one easily inline. So no worries.
>
> Fred, can you test this patch so I can add a Tested-by line.

OK, I will test it.

Btw, I thought that this function should only change the UART speed.
For other UART parameters, I thought they should be set by btattach, 
ACPI or DT part.

Regards

Fred