From: Loic Poulain <loic.poulain@intel.com>
To: Ilya Faenson <ifaenson@broadcom.com>,
Frederic Danis <frederic.danis@linux.intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>
Cc: Arend Van Spriel <arend@broadcom.com>
Subject: Re: [PATCH 1/3] Bluetooth: hci_uart: Add PM for BCM2E39
Date: Fri, 17 Jul 2015 15:11:44 +0200 [thread overview]
Message-ID: <55A8FF10.2090108@intel.com> (raw)
In-Reply-To: <E0D3336E15B58B4294723AC879BA5E9426DDF7@IRVEXCHMB15.corp.ad.broadcom.com>
Hi Ilya,
> IF: Sorry for the delay in responding. I am not actively working on the similar DT driver at the moment as we have hit a DT maintainer roadblock for its development. I do not read this bulletin board much therefore. Great seeing a first take on the Broadcom BT UART ACPI driver! Looks like a good start to me. A few comments:
>
Most of Bluetooth UART chips have some extra configuration (PCM, I2S,
LPM...)
with specific vendor commands. Since it looks hard to include this
information
into DT and much more difficult into ACPI, I suggest to implement a
common way
to that with a generic btconf file. This file could be retrieved via
request_firmware
and filled with a list of HCI commands for vendor config. This
configuration should
happen after firmware download. If no conf file found, you can apply a
default
configuration or just ignore it.
It's just a proposal, I don't know if it does completely match your
requirements.
Regards,
Loic
--
Intel Open Source Technology Center
http://oss.intel.com/
next prev parent reply other threads:[~2015-07-17 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 13:22 [PATCH 1/3] Bluetooth: hci_uart: Add PM for BCM2E39 Frederic Danis
2015-07-03 13:22 ` [PATCH 2/3] net: rfkill: gpio: Make BCM2E39 support optional Frederic Danis
2015-07-03 13:22 ` [PATCH 3/3] Bluetooth: hci_uart: Retrieve UART speed from ACPI Frederic Danis
2015-07-16 16:10 ` [PATCH 1/3] Bluetooth: hci_uart: Add PM for BCM2E39 Frederic Danis
2015-07-16 18:54 ` Ilya Faenson
2015-07-17 13:11 ` Loic Poulain [this message]
2015-07-17 18:33 ` Ilya Faenson
2015-07-23 15:03 ` Frederic Danis
2015-07-23 17:49 ` Ilya Faenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8FF10.2090108@intel.com \
--to=loic.poulain@intel.com \
--cc=arend@broadcom.com \
--cc=frederic.danis@linux.intel.com \
--cc=ifaenson@broadcom.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).