From: Frederic Danis <frederic.danis@linux.intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Bluetooth: hci_bcm: Add ACPI and PM support
Date: Mon, 10 Aug 2015 17:50:27 +0200 [thread overview]
Message-ID: <55C8C843.8040606@linux.intel.com> (raw)
In-Reply-To: <A785406E-6D37-404C-B535-2CAD31496F0E@holtmann.org>
Hello Marcel,
On 07/08/2015 18:45, Marcel Holtmann wrote:
> Hi Fred,
>
>> These patches move PM support from rfkill-gpio to hci_uart module.
>> On, off, suspend and resume functions are supported.
>> They also parse the ACPI entry to find initial UART baud rate.
>>
>> v1->v2:
>> - Add BCM2E67 device in acpi_device_id table
>> - Add suspend/resume functions
>
> looks pretty good. My only concern is the race between bcm_data and bcm_device. Is that a valid concern from my side or can that never happen? Meaning do we need to protect against removal / unbinding of the platform device while the line discipline is active.
I do not found a way to protect against device unbinding, so I will
check if bcm_device is still in bsm_device_list before using it.
Regards
Fred
prev parent reply other threads:[~2015-08-10 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 15:00 [PATCH v2 0/4] Bluetooth: hci_bcm: Add ACPI and PM support Frederic Danis
2015-08-07 15:00 ` [PATCH v2 1/4] Bluetooth: hci_bcm: Add PM for BCM devices Frederic Danis
2015-08-07 16:41 ` Marcel Holtmann
2015-08-10 15:59 ` Frederic Danis
2015-08-10 8:00 ` Luka Karinja
2015-08-10 14:57 ` Frederic Danis
2015-08-23 10:44 ` Luka Karinja
2015-09-04 14:08 ` Frederic Danis
2015-08-07 15:00 ` [PATCH v2 2/4] net: rfkill: gpio: Make BCM2E39 support optional Frederic Danis
2015-08-07 16:42 ` Marcel Holtmann
2015-08-07 15:00 ` [PATCH v2 3/4] Bluetooth: hci_bcm: Retrieve UART speed from ACPI Frederic Danis
2015-08-07 15:00 ` [PATCH v2 4/4] Bluetooth: hci_bcm: Add suspend/resume PM functions Frederic Danis
2015-08-07 16:45 ` [PATCH v2 0/4] Bluetooth: hci_bcm: Add ACPI and PM support Marcel Holtmann
2015-08-10 15:50 ` Frederic Danis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C8C843.8040606@linux.intel.com \
--to=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).