From: Simon Fels <simon.fels@canonical.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] bluetooth: ask for MWS transport config only if controller supports 4.1
Date: Wed, 16 Sep 2015 07:25:54 +0200 [thread overview]
Message-ID: <55F8FD62.8090703@canonical.com> (raw)
In-Reply-To: <D76DBD6B-2DDD-4B96-B5F9-59A93B65D78E@holtmann.org>
Hey Marcel,
> so it is actually not that this chip does not understand this command, it is that it is being stupid.
It lead me to the assumption that the chip does something pretty wired
here as I didn't found this command in the 4.0 spec and when saying "I
am supporting 4.0" I would assume it doesn't mix any of the new commands
from newer spec versions in. However didn't saw that it was added in the
addendum ...
> < HCI Command: Get MWS Transport Layer.. (0x05|0x000c) plen 0
>> HCI Event: Command Complete (0x0e) plen 5
> Get MWS Transport Layer Configuration (0x05|0x000c) ncmd 1
> Status: Unknown Connection Identifier (0x02)
> Number of transports: 0
> Baud rate list: 0 entries
>
> The command is properly supported. I just don't know why it needs to return with an error. And especially error 0x02 which makes no sense in this case since the command is not even taking a connection handle in the first place.
>
> < HCI Command: Read Local Version Info.. (0x04|0x0001) plen 0
>> HCI Event: Command Complete (0x0e) plen 12
> Read Local Version Information (0x04|0x0001) ncmd 1
> Status: Success (0x00)
> HCI version: Bluetooth 4.0 (0x06) - Revision 0 (0x0000)
> LMP version: Bluetooth 4.0 (0x06) - Subversion 0 (0x0000)
> Manufacturer: MediaTek, Inc. (70)
> < HCI Command: Read BD ADDR (0x04|0x0009) plen 0
>> HCI Event: Command Complete (0x0e) plen 10
> Read BD ADDR (0x04|0x0009) ncmd 1
> Status: Success (0x00)
> Address: 38:BC:1A:1F:7E:96 (Meizu technology co.,ltd)
>
> So it seems that MediaTek needs to work a bit on their HCI command support. Which module is this anyway? Who builds it and where can it be found? Is this USB or UART? If it is USB, please provide /sys/kernel/debug/usb/devices entry for this one.
As far as I know it is the MT6630QP chip and its connected over UART.
> I have the feeling we are missing some sort of firmware update here that would allow to fix this controller.
Generally I would say this is the way to go too but that isn't really an
option in this case. So either we come up with a general solution by
adding a quirk for this or I patch this just on our kernel.
> And I forgot to note that MWS actually was a CSA. So it is valid for Bluetooth 4.0 controllers. It is just that Bluetooth 4.1 included all previous CSA.
I see. That is why I didn't found it in the 4.0 spec. Thanks for the hint!
regards,
Simon
next prev parent reply other threads:[~2015-09-16 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 9:24 [PATCH] bluetooth: ask for MWS transport config only if controller supports 4.1 Simon Fels
2015-09-15 9:32 ` Marcel Holtmann
2015-09-15 10:10 ` Simon Fels
2015-09-16 2:36 ` Marcel Holtmann
2015-09-16 5:25 ` Simon Fels [this message]
2015-09-16 9:01 ` Marcel Holtmann
2015-09-16 9:50 ` Simon Fels
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F8FD62.8090703@canonical.com \
--to=simon.fels@canonical.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).