From: Frederic Danis <frederic.danis@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>, andriy.shevchenko@linux.intel.com
Cc: linux-serial@vger.kernel.org, peter@hurleysoftware.com,
linux-bluetooth@vger.kernel.org, heikki.krogerus@linux.intel.com,
marcel@holtmann.org
Subject: Re: [PATCH v2] Revert "serial: 8250_dma: don't bother DMA with small transfers"
Date: Tue, 6 Oct 2015 16:23:36 +0200 [thread overview]
Message-ID: <5613D968.7000505@linux.intel.com> (raw)
In-Reply-To: <20151006135503.GA13250@kroah.com>
Hello Greg,
On 06/10/2015 15:55, Greg KH wrote:
> On Tue, Oct 06, 2015 at 03:08:40PM +0200, Frederic Danis wrote:
>> This reverts commit 9119fba0cfeda6d415c9f068df66838a104b87cb.
>>
>> This commit prevents from sending "big" file using Bluetooth.
>> When sending a lot of data quickly through the Bluetooth interface, and
>> after a variable amount of data sent, transfer fails with error:
>> kernel: [ 415.247453] Bluetooth: hci0 hardware error 0x00
>>
>> Found on T100TA.
>>
>> After reverting this commit, send works fine for any file size.
>>
>> Signed-off-by: Frederic Danis <frederic.danis@linux.intel.com>
>> ---
>> v2: Re-send to correct people
>>
>> drivers/tty/serial/8250/8250_dma.c | 4 ----
>> 1 file changed, 4 deletions(-)
>
> Andy, any objections?
>
> Frederic, don't you want to see this backported to 4.0 and newer?
Yes, you're right, unless Andy has any objection this should be good
Regards
Fred
next prev parent reply other threads:[~2015-10-06 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 13:08 [PATCH v2] Revert "serial: 8250_dma: don't bother DMA with small transfers" Frederic Danis
2015-10-06 13:55 ` Greg KH
2015-10-06 14:23 ` Frederic Danis [this message]
2015-10-09 14:45 ` Frederic Danis
2015-10-09 14:48 ` Andy Shevchenko
2015-10-09 15:09 ` Fabio Estevam
2015-10-06 14:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5613D968.7000505@linux.intel.com \
--to=frederic.danis@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).