linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: linux-wpan@vger.kernel.org, jukka.rissanen@linux.intel.com,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH bluetooth-next 4/4] 6lowpan: add nhc module for GHC ICMPv6 detection
Date: Wed, 25 Nov 2015 14:50:33 +0100	[thread overview]
Message-ID: <5655BCA9.3090609@osg.samsung.com> (raw)
In-Reply-To: <20150918215059.GC6872@omega>

Hello.

On 18/09/15 23:51, Alexander Aring wrote:
> On Fri, Sep 18, 2015 at 01:52:48PM +0200, Stefan Schmidt wrote:
>> Signed-off-by: Stefan Schmidt<stefan@osg.samsung.com>
>> ---
>>   net/6lowpan/Kconfig          |  5 +++++
>>   net/6lowpan/Makefile         |  1 +
>>   net/6lowpan/nhc_ghc_icmpv6.c | 27 +++++++++++++++++++++++++++
>>   3 files changed, 33 insertions(+)
>>   create mode 100644 net/6lowpan/nhc_ghc_icmpv6.c
>>
>> diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig
>> index 67a786b..a34693d 100644
>> --- a/net/6lowpan/Kconfig
>> +++ b/net/6lowpan/Kconfig
>> @@ -69,4 +69,9 @@ config 6LOWPAN_GHC_UDP
>>   	default y
>>   	---help---
>>   
>> +config 6LOWPAN_GHC_ICMPV6
>> +	tristate "GHC ICMPv6 Support"
>> +	default y
>> +	---help---
>> +
>>   endif
>> diff --git a/net/6lowpan/Makefile b/net/6lowpan/Makefile
>> index fc65efb..49256b7f 100644
>> --- a/net/6lowpan/Makefile
>> +++ b/net/6lowpan/Makefile
>> @@ -14,3 +14,4 @@ obj-$(CONFIG_6LOWPAN_NHC_UDP) += nhc_udp.o
>>   #rfc7400 ghcs
>>   obj-$(CONFIG_6LOWPAN_GHC_EXTENSION_HEADER) += nhc_ghc_extension_header.o
>>   obj-$(CONFIG_6LOWPAN_GHC_UDP) += nhc_ghc_udp.o
>> +obj-$(CONFIG_6LOWPAN_GHC_ICMPV6) += nhc_ghc_icmpv6.o
>> diff --git a/net/6lowpan/nhc_ghc_icmpv6.c b/net/6lowpan/nhc_ghc_icmpv6.c
>> new file mode 100644
>> index 0000000..378ebfe
>> --- /dev/null
>> +++ b/net/6lowpan/nhc_ghc_icmpv6.c
>> @@ -0,0 +1,27 @@
>> +/*
>> + *	6LoWPAN ICMPv6 compression according to RFC7400
>> + *
>> + *	This program is free software; you can redistribute it and/or
>> + *	modify it under the terms of the GNU General Public License
>> + *	as published by the Free Software Foundation; either version
>> + *	2 of the License, or (at your option) any later version.
>> + */
>> +
>> +#include "nhc.h"
>> +
>> +#define LOWPAN_GHC_ICMPV6_IDLEN		1
>> +#define LOWPAN_GHC_ICMPV6_ID_0		0xdf
>> +#define LOWPAN_GHC_ICMPV6_MASK_0	0xff
>> +
>> +static void icmpv6_ghid_setup(struct lowpan_nhc *nhc)
>> +{
>> +	nhc->id[0] = LOWPAN_GHC_ICMPV6_ID_0;
>> +	nhc->idmask[0] = LOWPAN_GHC_ICMPV6_MASK_0;
>> +}
>> +
>> +LOWPAN_NHC(ghc_icmpv6, "RFC7400 ICMPv6", NEXTHDR_HOP, 0,
> s/NEXTHDR_HOP/NEXTHDR_ICMP/

Fixed in the new patchset coming later today.

regards
Stefan Schmidt

      reply	other threads:[~2015-11-25 13:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 11:52 [PATCH bluetooth-next 0/4] GHC compression detection Stefan Schmidt
2015-09-18 11:52 ` [PATCH bluetooth-next 1/4] 6lowpan: clarify Kconfig entries for upcoming GHC support Stefan Schmidt
2015-09-18 11:52 ` [PATCH bluetooth-next 2/4] 6lowpan: add nhc module for GHC extension header detection Stefan Schmidt
2015-09-18 21:44   ` Alexander Aring
2015-09-18 22:14     ` Alexander Aring
2015-11-25 13:50       ` Stefan Schmidt
2015-11-25 13:50     ` Stefan Schmidt
2015-09-18 11:52 ` [PATCH bluetooth-next 3/4] 6lowpan: add nhc module for GHC UDP detection Stefan Schmidt
2015-09-18 21:50   ` Alexander Aring
2015-11-25 13:49     ` Stefan Schmidt
2015-09-18 11:52 ` [PATCH bluetooth-next 4/4] 6lowpan: add nhc module for GHC ICMPv6 detection Stefan Schmidt
2015-09-18 21:51   ` Alexander Aring
2015-11-25 13:50     ` Stefan Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5655BCA9.3090609@osg.samsung.com \
    --to=stefan@osg.samsung.com \
    --cc=alex.aring@gmail.com \
    --cc=jukka.rissanen@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).