From: Stefan Schmidt <stefan@osg.samsung.com>
To: michael.hennerich@analog.com, alex.aring@gmail.com,
stefan@datenfreihafen.org, marcel@holtmann.org
Cc: linux-wpan@vger.kernel.org, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] drivers/net/ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154
Date: Tue, 8 Dec 2015 15:30:30 +0100 [thread overview]
Message-ID: <5666E986.8070105@osg.samsung.com> (raw)
In-Reply-To: <1449575525-23259-1-git-send-email-michael.hennerich@analog.com>
Hello.
One last thing, hopefully. :)
On 08/12/15 12:52, michael.hennerich@analog.com wrote:
[snip]
> +
> + dev_info(&spi->dev, "mac802154 IRQ-%d registered\n", spi->irq);
> +
> + return ret;
> +
> + ieee802154_unregister_hw(lp->hw);
The function call after return will never be called. Guess you want to
make sure the error handling is correct here.
> +err_hw_init:
> + mutex_destroy(&lp->bmux);
> + ieee802154_free_hw(lp->hw);
regards
Stefan Schmidt
next prev parent reply other threads:[~2015-12-08 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 11:52 [PATCH v2] drivers/net/ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154 michael.hennerich
2015-12-08 13:37 ` Stefan Schmidt
2015-12-08 14:05 ` Stefan Schmidt
2015-12-08 14:44 ` Michael Hennerich
2015-12-08 14:56 ` Michael Hennerich
2015-12-08 15:13 ` Stefan Schmidt
2015-12-08 14:41 ` Michael Hennerich
2015-12-08 14:30 ` Stefan Schmidt [this message]
2015-12-08 14:45 ` Michael Hennerich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666E986.8070105@osg.samsung.com \
--to=stefan@osg.samsung.com \
--cc=alex.aring@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=michael.hennerich@analog.com \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).