Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@codecoup.pl>
To: linux-bluetooth@vger.kernel.org,
	Sathish Narasimman <sathish.narasimman@intel.com>
Cc: chethan.tumkur.narayan@intel.com, ravishankar.srivatsa@intel.com,
	Sathish Narasimman <sathish.narasimman@intel.com>
Subject: Re: [PATCH 2/2] Bluetooth: LL privacy allow RPA
Date: Tue, 06 Apr 2021 16:17:13 +0200	[thread overview]
Message-ID: <5698706.lOV4Wx5bFT@ix> (raw)
In-Reply-To: <20210405143041.16168-1-sathish.narasimman@intel.com>

Hi,

On Monday, 5 April 2021 16:30:41 CEST Sathish Narasimman wrote:
> allow RPA to add bd address to whitelist
> 
> Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
> ---
>  net/bluetooth/hci_request.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index 0d78122342d5..560b74d421a8 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -847,6 +847,10 @@ static u8 update_white_list(struct hci_request *req)
>  	 */
>  	bool allow_rpa = hdev->suspended;
> 
> +	if (use_ll_privacy(hdev) &&
> +	    hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY))
> +		allow_rpa = true;
> +
>  	/* Go through the current white list programmed into the
>  	 * controller one by one and check if that address is still
>  	 * in the list of pending connections or list of devices to

I'm bit confused by this patch. Why add RPA to whitelist if LL privacy is in 
use?

-- 
pozdrawiam
Szymon Janc



  parent reply	other threads:[~2021-04-06 14:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 14:30 [PATCH 2/2] Bluetooth: LL privacy allow RPA Sathish Narasimman
2021-04-06  8:50 ` Marcel Holtmann
2021-04-06 14:17 ` Szymon Janc [this message]
2021-04-06 15:05   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5698706.lOV4Wx5bFT@ix \
    --to=szymon.janc@codecoup.pl \
    --cc=chethan.tumkur.narayan@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=ravishankar.srivatsa@intel.com \
    --cc=sathish.narasimman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox