Re: [PATCH 0/3] Allow to reattach with new composition data

Gix, Brian
2020-01-20T17:17:48Z

Hi Jakub,

a few things..

First, the subject line for user space patches should always be [BlueZ PATCH...] to differentiate bluez.git
patches from kernel patches.

Also: The title of the patch should always start with the component being modified... in this case
"mesh: Allow reattach..." or "tools/mesh: XXXX" for example

On Mon, 2020-01-20 at 17:11 +0100, Jakub Witowski wrote:
> This patch allows the application to modify the CID, PID, VID and CRPL in the composition data.

This will require some discussion. Currently we are planning at *least* to make CRPL entirely under the
control of bluetooth-mesh.conf, because this has a significant daemon impact.

The other settings I am not as concerned about... If the spec really does allow their alteration though, I am
willing to consider them.

> According the Mesh Profile (2.3.4 Elements) the modification of fields other than "Elements" is not
> prohibited.
>
> Also in my opinion (as you can see in the 1st patch), there is no need to use pointer to the node_composition
> struct.
> The static is more clear and less problematic.
>
> Jakub Witowski (3):
> mesh: use static node_comp instead of the pointer
> mesh: add composition data setter
> mesh: allow to reattach with new composition data
>
> mesh/mesh-config-json.c | 46 +++++++++++++++-----
> mesh/mesh-config.h | 2 +
> mesh/node.c | 96 +++++++++++++++++++++++++----------------
> 3 files changed, 96 insertions(+), 48 deletions(-)
>