From: Szymon Janc <szymon.janc@tieto.com>
To: Mariusz Skamra <mariusz.skamra@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 4/4] android/gatt: Fix autoconnect
Date: Fri, 08 May 2015 14:46:22 +0200 [thread overview]
Message-ID: <5915398.yFWW3tx09O@leonov> (raw)
In-Reply-To: <1430393178-29983-4-git-send-email-mariusz.skamra@gmail.com>
Hi Mariusz,
On Thursday 30 of April 2015 13:26:18 Mariusz Skamra wrote:
> This patch fixes autoconnect issue, however there is also race hazard in
> Android Gatt framework. If app uses autoconnect while connecting,
> direct flag is set to false. Then bt_gatt_add_autoconnect should be called
> to add this app's id to autoconnect_apps queue.
> ---
> android/gatt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 4da959f..72a27ab 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -1972,6 +1972,7 @@ static bool trigger_connection(struct app_connection
> *conn, bool direct) if (direct)
> return connect_le(conn->device) == 0;
>
> + bt_gatt_add_autoconnect(conn->app->id, &conn->device->bdaddr);
> return auto_connect_le(conn->device);
> case DEVICE_CONNECTED:
> notify_app_connect_status(conn, GATT_SUCCESS);
This patch is now applied. Thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2015-05-08 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 11:26 [PATCH 1/4] unit/eir: Fix G-tag test data Mariusz Skamra
2015-04-30 11:26 ` [PATCH 2/4] src/eir: Fix eir parser Mariusz Skamra
2015-04-30 14:32 ` Luiz Augusto von Dentz
2015-04-30 11:26 ` [PATCH 3/4] unit/eir: Add WahooHRM test Mariusz Skamra
2015-04-30 11:26 ` [PATCH 4/4] android/gatt: Fix autoconnect Mariusz Skamra
2015-05-08 12:46 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5915398.yFWW3tx09O@leonov \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mariusz.skamra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).