Re: [PATCH BlueZ] sixaxis: DS4: use 0x12 cmd to get device bdaddr

[Bastien Nocera <hadess@hadess.net>]

Hello Marek,

Some comments below.

On Sat, 2026-04-04 at 14:30 +0200, Marek Czerski wrote:
> This change is required for Esperanza EGG109k ps controller clone.

This should be what's mentioned in the commit subject:
sixaxis: Fix pairing Esperanza EGG109k controller

> EGG109k looks like PS3 controller but presents itself to the system
> as PS4 controller. It does not respond to 0x81 command.
> Command 0x12 contains both the device mac address as well as
> configured host mac address, so it can be used to query
> both. Kernel driver also uses 0x12 command for that.

You should name the kernel driver (it's "hid-playstation").

Note that despite what the hid-sony driver says, it's not a "Bluetooth
MAC address" or mac address, but a "Bluetooth address".

I would also include a link to an online store or product page for the
device, so folks know what it looks like.

> ---
>  plugins/sixaxis.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
> index 27bc09815..8e212ee71 100644
> --- a/plugins/sixaxis.c
> +++ b/plugins/sixaxis.c
> @@ -111,12 +111,12 @@ static int sixaxis_get_device_bdaddr(int fd,
> bdaddr_t *bdaddr)
>  
>  static int ds4_get_device_bdaddr(int fd, bdaddr_t *bdaddr)
>  {
> -	uint8_t buf[7];
> +	uint8_t buf[16];

This is a good opportunity to copy the constants from hid-playstation:
#define DS4_FEATURE_REPORT_PAIRING_INFO         0x12
#define DS4_FEATURE_REPORT_PAIRING_INFO_SIZE    16
and use those.

>  	int ret;
>  
>  	memset(buf, 0, sizeof(buf));
>  
> -	buf[0] = 0x81;
> +	buf[0] = 0x12;
>  
>  	ret = ioctl(fd, HIDIOCGFEATURE(sizeof(buf)), buf);
>  	if (ret < 0) {