From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
linux-wireless@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [2/3] mwifiex: support sysfs initiated device coredump
Date: Mon, 12 Mar 2018 13:44:06 +0100 [thread overview]
Message-ID: <5AA67616.2000602@broadcom.com> (raw)
In-Reply-To: <20180312094115.2E1C1606DB@smtp.codeaurora.org>
On 3/12/2018 10:41 AM, Kalle Valo wrote:
> Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
>
>> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
>> it is possible to initiate a device coredump from user-space. This
>> patch adds support for it adding the .coredump() driver callback.
>> As there is no longer a need to initiate it through debugfs remove
>> that code.
>>
>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>
> Based on the discussion I assume this is ok to take to w-d-next. If that's not
> the case, please let me know ASAP.
It is up to the mwifiex maintainers to decide, I guess. The ABI
documentation need to be revised and change the callback to void return
type. I am not sure what the best approach is. 1) apply this and fix
return type later, or 2) fix return type and resubmit this. What is your
opinion?
Regards,
Arend
next prev parent reply other threads:[~2018-03-12 12:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 10:50 [PATCH 0/3] drivers: support for sysfs initiated coredump Arend van Spriel
2018-02-21 10:50 ` [PATCH 1/3] brcmfmac: add " Arend van Spriel
2018-02-21 10:50 ` [PATCH 2/3] mwifiex: support sysfs initiated device coredump Arend van Spriel
2018-02-21 22:59 ` Brian Norris
2018-02-22 12:17 ` Arend van Spriel
2018-02-22 19:35 ` Brian Norris
2018-02-23 10:39 ` Arend van Spriel
2018-02-23 10:51 ` Johannes Berg
2018-02-26 22:06 ` Brian Norris
2018-02-26 22:25 ` Arend van Spriel
2018-03-12 9:41 ` [2/3] " Kalle Valo
2018-03-12 9:41 ` Kalle Valo
[not found] ` <20180312094115.2E1C1606DB@smtp.codeaurora.org>
2018-03-12 12:44 ` Arend van Spriel [this message]
2018-03-13 13:10 ` Kalle Valo
2018-03-13 19:42 ` Arend van Spriel
2018-03-13 20:19 ` Marcel Holtmann
2018-03-13 20:21 ` Arend van Spriel
2018-02-21 10:50 ` [PATCH 3/3] btmrvl: support sysfs initiated firmware coredump Arend van Spriel
2018-02-27 14:46 ` [3/3] " Kalle Valo
2018-02-27 14:46 ` Kalle Valo
2018-02-27 18:26 ` [PATCH 3/3] " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AA67616.2000602@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).