linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump
       [not found]   ` <87bmdhp8os.fsf@kamboji.qca.qualcomm.com>
@ 2018-05-15  9:57     ` Arend van Spriel
  2018-05-15 10:02       ` Kalle Valo
  0 siblings, 1 reply; 3+ messages in thread
From: Arend van Spriel @ 2018-05-15  9:57 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless, Marcel Holtmann, Linux Bluetooth mailing list

+ Marcel, bt-list

On 5/15/2018 11:30 AM, Kalle Valo wrote:
> Arend van Spriel <arend.vanspriel@broadcom.com> writes:
>
>> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
>> it is possible to initiate a device coredump from user-space. This
>> patch adds support for it in btmrvl_sdio adding the .coredump()
>> driver callback. This makes dump through debugfs obsolete so removing
>> it.
>>
>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>> ---
>>   drivers/bluetooth/btmrvl_debugfs.c | 31 -------------------------------
>>   drivers/bluetooth/btmrvl_drv.h     |  2 --
>>   drivers/bluetooth/btmrvl_main.c    |  6 ------
>>   drivers/bluetooth/btmrvl_sdio.c    | 11 ++++++++---
>>   4 files changed, 8 insertions(+), 42 deletions(-)
>
> Shouldn't this go via bluetooth tree?

Ah, yes. I should at least have added bt-list to Cc: I can submit this 
separately so you can drop it or can you coordinate with Marcel how to 
deal with it. Maybe it is fine to take this to w-d tree?

Regards,
Arend

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump
  2018-05-15  9:57     ` [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump Arend van Spriel
@ 2018-05-15 10:02       ` Kalle Valo
  2018-05-15 10:37         ` Arend van Spriel
  0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2018-05-15 10:02 UTC (permalink / raw)
  To: Arend van Spriel
  Cc: linux-wireless, Marcel Holtmann, Linux Bluetooth mailing list

Arend van Spriel <arend.vanspriel@broadcom.com> writes:

> + Marcel, bt-list
>
> On 5/15/2018 11:30 AM, Kalle Valo wrote:
>> Arend van Spriel <arend.vanspriel@broadcom.com> writes:
>>
>>> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
>>> it is possible to initiate a device coredump from user-space. This
>>> patch adds support for it in btmrvl_sdio adding the .coredump()
>>> driver callback. This makes dump through debugfs obsolete so removing
>>> it.
>>>
>>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>>> ---
>>>   drivers/bluetooth/btmrvl_debugfs.c | 31 -------------------------------
>>>   drivers/bluetooth/btmrvl_drv.h     |  2 --
>>>   drivers/bluetooth/btmrvl_main.c    |  6 ------
>>>   drivers/bluetooth/btmrvl_sdio.c    | 11 ++++++++---
>>>   4 files changed, 8 insertions(+), 42 deletions(-)
>>
>> Shouldn't this go via bluetooth tree?
>
> Ah, yes. I should at least have added bt-list to Cc: I can submit this
> separately so you can drop it or can you coordinate with Marcel how to
> deal with it. Maybe it is fine to take this to w-d tree?

I prefer submitting this patch separately to the bluetooth tree (and
I'll drop this version from my queue).

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump
  2018-05-15 10:02       ` Kalle Valo
@ 2018-05-15 10:37         ` Arend van Spriel
  0 siblings, 0 replies; 3+ messages in thread
From: Arend van Spriel @ 2018-05-15 10:37 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless, Marcel Holtmann, Linux Bluetooth mailing list

On 5/15/2018 12:02 PM, Kalle Valo wrote:
> Arend van Spriel <arend.vanspriel@broadcom.com> writes:
>
>> + Marcel, bt-list
>>
>> On 5/15/2018 11:30 AM, Kalle Valo wrote:
>>> Arend van Spriel <arend.vanspriel@broadcom.com> writes:
>>>
>>>> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
>>>> it is possible to initiate a device coredump from user-space. This
>>>> patch adds support for it in btmrvl_sdio adding the .coredump()
>>>> driver callback. This makes dump through debugfs obsolete so removing
>>>> it.
>>>>
>>>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>>>> ---
>>>>    drivers/bluetooth/btmrvl_debugfs.c | 31 -------------------------------
>>>>    drivers/bluetooth/btmrvl_drv.h     |  2 --
>>>>    drivers/bluetooth/btmrvl_main.c    |  6 ------
>>>>    drivers/bluetooth/btmrvl_sdio.c    | 11 ++++++++---
>>>>    4 files changed, 8 insertions(+), 42 deletions(-)
>>>
>>> Shouldn't this go via bluetooth tree?
>>
>> Ah, yes. I should at least have added bt-list to Cc: I can submit this
>> separately so you can drop it or can you coordinate with Marcel how to
>> deal with it. Maybe it is fine to take this to w-d tree?
>
> I prefer submitting this patch separately to the bluetooth tree (and
> I'll drop this version from my queue).

Fine by me.

Regards,
Arend

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-15 10:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1526375691-31789-1-git-send-email-arend.vanspriel@broadcom.com>
     [not found] ` <1526375691-31789-6-git-send-email-arend.vanspriel@broadcom.com>
     [not found]   ` <87bmdhp8os.fsf@kamboji.qca.qualcomm.com>
2018-05-15  9:57     ` [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump Arend van Spriel
2018-05-15 10:02       ` Kalle Valo
2018-05-15 10:37         ` Arend van Spriel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).