From: "Stotland, Inga" <inga.stotland@intel.com>
To: "sbrown@ewol.com" <sbrown@ewol.com>
Cc: "Gix, Brian" <brian.gix@intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ] mesh: Fix errors found by static analysis
Date: Sun, 29 Nov 2020 05:10:42 +0000 [thread overview]
Message-ID: <5d40d4a569ef5c8adf78511a47332ca774eb4487.camel@intel.com> (raw)
In-Reply-To: <64b4d0e7e44b9726b8664e16461905cf8b90f20d.camel@ewol.com>
Hi Steve,
On Sat, 2020-11-28 at 12:05 -0500, Steve Brown wrote:
> Hi Inga,
>
> The changes to mesh/keyring.c break create network for me.
>
> I think the mkdir tests should be
> if (!!mkdir(key_file, 0755))
Yes, you are correct: it's a wrong check. Will fix.
> not
> if (!mkdir(key_file, 0755))
>
> With that change, I can create networks again.
>
> Steve
>
Best regards,
Inga
prev parent reply other threads:[~2020-11-29 5:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 7:10 [PATCH BlueZ] mesh: Fix errors found by static analysis Inga Stotland
2020-11-06 7:26 ` [BlueZ] " bluez.test.bot
2020-11-10 18:27 ` [PATCH BlueZ] " Gix, Brian
2020-11-28 17:05 ` Steve Brown
2020-11-29 5:10 ` Stotland, Inga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d40d4a569ef5c8adf78511a47332ca774eb4487.camel@intel.com \
--to=inga.stotland@intel.com \
--cc=brian.gix@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sbrown@ewol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).