RE: [BlueZ,v4,1/8] adv_monitor: Implement RSSI Filter logic for background scanning

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]


This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkbuild Failed

Outputs:
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
src/adv_monitor.c: In function ‘adv_monitor_removed_callback’:
src/adv_monitor.c:1030:30: error: ‘manager’ undeclared (first use in this function)
 1030 |  const uint16_t adapter_id = manager->adapter_id;
      |                              ^~~~~~~
src/adv_monitor.c:1030:30: note: each undeclared identifier is reported only once for each function it appears in
src/adv_monitor.c:1041:51: error: passing argument 3 of ‘queue_foreach’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
 1041 |  queue_foreach(manager->apps, app_remove_monitor, ev);
      |                                                   ^~
In file included from src/adv_monitor.c:42:
./src/shared/queue.h:48:14: note: expected ‘void *’ but argument is of type ‘const struct mgmt_ev_adv_monitor_removed *’
   48 |        void *user_data);
      |        ~~~~~~^~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:6863: src/adv_monitor.o] Error 1
make: *** [Makefile:4056: all] Error 2



---
Regards,
Linux Bluetooth