public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: "Chris Rivera" <crivera@novell.com>
To: bluez-devel@lists.sourceforge.net
Subject: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item
Date: Thu, 25 Oct 2007 15:20:17 -0400	[thread overview]
Message-ID: <5f84803c0710251220m73a0b7va39bd0c46cfaabd9@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 165 bytes --]

Since the Preferences menu entry in the applet opens a new window it should
probably have an ellipsis in the label.  Attached is a trivial patch to add
this.

Chris

[-- Attachment #1.2: Type: text/html, Size: 185 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bluez-gnome-pref-menu-item.patch --]
[-- Type: text/x-patch; name=bluez-gnome-pref-menu-item.patch, Size: 846 bytes --]

Index: applet/main.c
===================================================================
RCS file: /cvsroot/bluez/gnome/applet/main.c,v
retrieving revision 1.87
diff -u -r1.87 main.c
--- applet/main.c	29 Aug 2007 20:42:18 -0000	1.87
+++ applet/main.c	25 Oct 2007 19:13:47 -0000
@@ -1675,12 +1675,15 @@
 {
 	GtkWidget *menu;
 	GtkWidget *item;
+	GtkWidget *image;
 
 	menu = gtk_menu_new();
 
-	item = gtk_image_menu_item_new_from_stock(GTK_STOCK_PREFERENCES, NULL);
+	item = gtk_image_menu_item_new_with_mnemonic (_("_Preferences..."));
 	g_signal_connect(item, "activate",
 				G_CALLBACK(settings_callback), NULL);
+	image = gtk_image_new_from_stock (GTK_STOCK_PREFERENCES, GTK_ICON_SIZE_MENU);
+	gtk_image_menu_item_set_image (GTK_IMAGE_MENU_ITEM (item), image);
 	gtk_widget_show(item);
 	gtk_menu_shell_append(GTK_MENU_SHELL(menu), item);
 

[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

             reply	other threads:[~2007-10-25 19:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 19:20 Chris Rivera [this message]
2007-10-25 22:44 ` [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item Marcel Holtmann
2007-10-25 23:22   ` Chris Rivera
2007-10-26  0:29   ` Bastien Nocera
2007-10-31 16:33     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f84803c0710251220m73a0b7va39bd0c46cfaabd9@mail.gmail.com \
    --to=crivera@novell.com \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox