Re: [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons

Chris Rivera
2007-12-17T03:08:52Z

[-- Attachment #1.1: Type: text/plain, Size: 2004 bytes --]

Anyone? Anyone?

On Dec 6, 2007 12:59 PM, Chris Rivera <chrismrivera@gmail.com> wrote:

> Attached is an updated patch with the changes that we talked about.
>
> Chris
>
>
> On Dec 3, 2007 11:59 AM, Marcel Holtmann <marcel@holtmann.org> wrote:
>
> > Hi Chris,
> >
> > >
> > > I meant to look into it, but never got around it. Some small
> > > comments
> > > about it. Don't make the applet a singleton. That is totally
> > > unneeded
> > > since the applet will be loaded at login.
> > >
> > > I still think it should be a singleton. You wouldn't ever want two
> > > applets running unless you're testing, and we have the singleton flags
> > > for that. I don't think this hurts anything.
> >
> > I am okay with that. Please abstract everything into common/. And don't
> > forget to document it in the manual pages.
> >
> > > For the "Present" method. Don't use the D-Bus low-level calls.
> > > It should
> > > be all dbus-glib. Which means we have to abstract that into an
> >
> > > object. I
> > > don't know if there is a well defined way for this. If it is,
> > > it might
> > > be good to use that. If not, then propose something for
> > > freedesktop.org.
> > >
> > > I thought about doing this, but it seems like overkill to define a
> > > GObject to just expose one method. GObject isn't exactly terse
> > > either.
> >
> > In a simple way you can use GObject for it. It is better than using the
> > low-level D-Bus calls.
> >
> > > And we should probably have some generic methods inside
> > > common/ instead
> > > of doing it again in every program.
> > >
> > > Please follow the kernel coding style. I know it is odd for a
> > > GTK
> > > application, but it makes it a lot easier for me.
> > >
> > > Which parts of the patch violate the kernel coding style? The
> > > function parameter spacing?
> >
> > Mainly the spacing.
> >
> >
>

[-- Attachment #1.2: Type: text/html, Size: 3187 bytes --]

[-- Attachment #2: Type: text/plain, Size: 308 bytes --]

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]