From: Jesse Melhuish <melhuishj@chromium.org>
To: linux-bluetooth@vger.kernel.org
Cc: Jesse Melhuish <melhuishj@chromium.org>
Subject: [RFC BlueZ PATCH] Bluetooth: Use driver status and experiment value for central-peripheral support.
Date: Mon, 20 Dec 2021 22:19:25 +0000 [thread overview]
Message-ID: <61c10192.1c69fb81.96a67.06a8@mx.google.com> (raw)
---
The observed behavior without any change is that support for the
central-peripheral role can be enabled through an experiment flag in
BlueZ regardless of whether the controller can actually support it.
Additionally, if the controller has enabled this feature but the
experiment flag has not been set the central-peripheral role is not
listed as supported. I'm not certain what the expected behavior should
be, but enabling if either source says to enable (this patch) or only
when both enable the feature both seem like reasonable options to start
with.
src/adapter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/adapter.c b/src/adapter.c
index 9fc6853c9..60325015b 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -10434,7 +10434,8 @@ static void read_exp_features_complete(uint8_t status, uint16_t length,
}
if (feat->func)
- feat->func(adapter, action);
+ feat->func(adapter, action ||
+ (rp->features[i].flags & BIT(0)));
}
}
}
--
2.31.0
next reply other threads:[~2021-12-20 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 22:19 Jesse Melhuish [this message]
2021-12-21 20:57 ` [RFC BlueZ PATCH] Bluetooth: Use driver status and experiment value for central-peripheral support Luiz Augusto von Dentz
2021-12-21 21:19 ` Jesse Melhuish
2021-12-21 21:35 ` Luiz Augusto von Dentz
2021-12-21 22:27 ` Jesse Melhuish
2021-12-22 20:12 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c10192.1c69fb81.96a67.06a8@mx.google.com \
--to=melhuishj@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox