Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Lukasz Rymanowski <lukasz.rymanowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com
Subject: Re: [PATCH v3 1/3] android: Add wrapper function for get remote dev properties
Date: Wed, 08 Jan 2014 13:19:15 +0100	[thread overview]
Message-ID: <6204735.JyjCCBb1Ih@uw000953> (raw)
In-Reply-To: <1389104030-21314-1-git-send-email-lukasz.rymanowski@tieto.com>

Hi Łukasz,

> ---
>  android/bluetooth.c | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/android/bluetooth.c b/android/bluetooth.c
> index 3cbf68d..f281fcf 100644
> --- a/android/bluetooth.c
> +++ b/android/bluetooth.c
> @@ -2673,6 +2673,19 @@ static uint8_t get_device_timestamp(struct device *dev)
>  	return HAL_STATUS_SUCCESS;
>  }
>  
> +static void get_remote_device_props(struct device *dev)
> +{
> +	get_device_name(dev);
> +	get_device_uuids(dev);
> +	get_device_class(dev);
> +	get_device_type(dev);
> +	get_device_service_rec(dev);
> +	get_device_friendly_name(dev);
> +	get_device_rssi(dev);
> +	get_device_version_info(dev);
> +	get_device_timestamp(dev);
> +}
> +
>  static void handle_get_remote_device_props_cmd(const void *buf, uint16_t len)
>  {
>  	const struct hal_cmd_get_remote_device_props *cmd = buf;
> @@ -2688,15 +2701,7 @@ static void handle_get_remote_device_props_cmd(const void *buf, uint16_t len)
>  		goto failed;
>  	}
>  
> -	get_device_name(l->data);
> -	get_device_uuids(l->data);
> -	get_device_class(l->data);
> -	get_device_type(l->data);
> -	get_device_service_rec(l->data);
> -	get_device_friendly_name(l->data);
> -	get_device_rssi(l->data);
> -	get_device_version_info(l->data);
> -	get_device_timestamp(l->data);
> +	get_remote_device_props(l->data);
>  
>  	status = HAL_STATUS_SUCCESS;
>  
> 

Patches applied, thanks.

-- 
BR
Szymon Janc

      parent reply	other threads:[~2014-01-08 12:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 14:13 [PATCH v3 1/3] android: Add wrapper function for get remote dev properties Lukasz Rymanowski
2014-01-07 14:13 ` [PATCH v3 2/3] android: Move get_remote_device_props up in the file Lukasz Rymanowski
2014-01-07 14:13 ` [PATCH v3 3/3] android: Send remote devices properties on enable Lukasz Rymanowski
2014-01-08 12:19 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6204735.JyjCCBb1Ih@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=lukasz.rymanowski@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox