* [PATCH] Bluetooth: Replace IS_ERR_OR_NULL with IS_ERR
@ 2022-08-01 4:29 Aashish Sharma
2022-08-01 5:03 ` bluez.test.bot
2022-08-01 8:13 ` [PATCH] " Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Aashish Sharma @ 2022-08-01 4:29 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
groeck, mfaltesek
Cc: linux-bluetooth, netdev, linux-kernel, Aashish Sharma
Since bt_skb_sendmsg never returns NULL, replace IS_ERR_OR_NULL
with IS_ERR.
Signed-off-by: Aashish Sharma <shraash@google.com>
---
include/net/bluetooth/bluetooth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index 6b48d9e2aab9..a8b52175af05 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -494,7 +494,7 @@ static inline struct sk_buff *bt_skb_sendmmsg(struct sock *sk,
struct sk_buff *skb, **frag;
skb = bt_skb_sendmsg(sk, msg, len, mtu, headroom, tailroom);
- if (IS_ERR_OR_NULL(skb))
+ if (IS_ERR(skb))
return skb;
len -= skb->len;
--
2.37.1.455.g008518b4e5-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: Bluetooth: Replace IS_ERR_OR_NULL with IS_ERR
2022-08-01 4:29 [PATCH] Bluetooth: Replace IS_ERR_OR_NULL with IS_ERR Aashish Sharma
@ 2022-08-01 5:03 ` bluez.test.bot
2022-08-01 8:13 ` [PATCH] " Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-08-01 5:03 UTC (permalink / raw)
To: linux-bluetooth, shraash
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
This is an automated email and please do not reply to this email.
Dear Submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
----- Output -----
error: patch failed: include/net/bluetooth/bluetooth.h:494
error: include/net/bluetooth/bluetooth.h: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Please resolve the issue and submit the patches again.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Replace IS_ERR_OR_NULL with IS_ERR
2022-08-01 4:29 [PATCH] Bluetooth: Replace IS_ERR_OR_NULL with IS_ERR Aashish Sharma
2022-08-01 5:03 ` bluez.test.bot
@ 2022-08-01 8:13 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-08-01 8:13 UTC (permalink / raw)
To: Aashish Sharma
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Guenter Roeck, Martin Faltesek, Linux Bluetooth, netdev,
linux-kernel
On Sun, Jul 31, 2022 at 9:29 PM Aashish Sharma <shraash@google.com> wrote:
>
> Since bt_skb_sendmsg never returns NULL, replace IS_ERR_OR_NULL
> with IS_ERR.
>
> Signed-off-by: Aashish Sharma <shraash@google.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> include/net/bluetooth/bluetooth.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> index 6b48d9e2aab9..a8b52175af05 100644
> --- a/include/net/bluetooth/bluetooth.h
> +++ b/include/net/bluetooth/bluetooth.h
> @@ -494,7 +494,7 @@ static inline struct sk_buff *bt_skb_sendmmsg(struct sock *sk,
> struct sk_buff *skb, **frag;
>
> skb = bt_skb_sendmsg(sk, msg, len, mtu, headroom, tailroom);
> - if (IS_ERR_OR_NULL(skb))
> + if (IS_ERR(skb))
> return skb;
>
> len -= skb->len;
> --
> 2.37.1.455.g008518b4e5-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-01 8:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-01 4:29 [PATCH] Bluetooth: Replace IS_ERR_OR_NULL with IS_ERR Aashish Sharma
2022-08-01 5:03 ` bluez.test.bot
2022-08-01 8:13 ` [PATCH] " Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox