Re: [PATCH BlueZ] zsh: drop no more arguments message

Luiz Augusto von Dentz
2022-08-22T22:55:19Z

Hi Ronan,

On Sun, Aug 21, 2022 at 7:33 PM Ronan Pigott <ronan@rjp.ie> wrote:
>
> This usage of the _message as a completion function is invalid, and
> will result in an error if invoked by _arguments when the user has a
> format style set for completion messages.
>
> We can just drop this message, since it is not necessary.

It might be better to include the output of zsh when it fails to
auto-complete, or actually a pre and post patch output.

> ---
> completion/zsh/_bluetoothctl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/completion/zsh/_bluetoothctl b/completion/zsh/_bluetoothctl
> index bf35e503e..610ca2b8d 100644
> --- a/completion/zsh/_bluetoothctl
> +++ b/completion/zsh/_bluetoothctl
> @@ -68,8 +68,7 @@ _bluetoothctl() {
> '(info)'{-m,--monitor}'[Enable monitor output]' \
> + 'command' \
> '(info):command:->command' \
> - '(info):: :->argument' \
> - ': :_message "no more arguments"'
> + '(info):: :->argument'
>
> if [[ $state == "command" ]]; then
> _describe -t commands 'command' all_commands
> --
> 2.37.2
>

--
Luiz Augusto von Dentz