RE: [BlueZ,v4,1/6] adapter: Keep track of whether the adapter is rfkill'ed

bluez.test.bot
2022-08-31T10:23:22Z

[-- Attachment #1: Type: text/plain, Size: 4502 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=672764

---Test result---

Test Summary:
CheckPatch FAIL 9.12 seconds
GitLint PASS 6.06 seconds
Prep - Setup ELL PASS 31.33 seconds
Build - Prep PASS 0.88 seconds
Build - Configure PASS 10.02 seconds
Build - Make PASS 941.21 seconds
Make Check PASS 12.27 seconds
Make Check w/Valgrind PASS 338.64 seconds
Make Distcheck PASS 277.34 seconds
Build w/ext ELL - Configure PASS 10.07 seconds
Build w/ext ELL - Make PASS 97.46 seconds
Incremental Build w/ patches PASS 702.02 seconds
Scan Build PASS 736.92 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,v4,1/6] adapter: Keep track of whether the adapter is rfkill'ed
ERROR:CODE_INDENT: code indent should use tabs where possible
#95: FILE: src/adapter.c:7558:
+^I g_dbus_emit_property_changed(dbus_conn, adapter->path,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#110: FILE: src/adapter.c:7574:
+^I g_dbus_emit_property_changed(dbus_conn, adapter->path,$

/github/workspace/src/12960589.patch total: 2 errors, 0 warnings, 90 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/12960589.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

[BlueZ,v4,2/6] adapter: Implement PowerState property
ERROR:CODE_INDENT: code indent should use tabs where possible
#96: FILE: src/adapter.c:590:
+^I g_dbus_emit_property_changed(dbus_conn, adapter->path,$

WARNING:LONG_LINE: line length of 97 exceeds 80 columns
#123: FILE: src/adapter.c:659:
+ reset_power_state_target(adapter, settings & MGMT_SETTING_POWERED ? 0x01 : 0x00);

WARNING:LONG_LINE_STRING: line length of 81 exceeds 80 columns
#153: FILE: src/adapter.c:727:
+ ADAPTER_INTERFACE, "PowerState");

WARNING:LONG_LINE_STRING: line length of 81 exceeds 80 columns
#175: FILE: src/adapter.c:761:
+ ADAPTER_INTERFACE, "PowerState");

WARNING:LONG_LINE_STRING: line length of 81 exceeds 80 columns
#209: FILE: src/adapter.c:3101:
+ ADAPTER_INTERFACE, "PowerState");

WARNING:LONG_LINE_STRING: line length of 81 exceeds 80 columns
#222: FILE: src/adapter.c:3115:
+ ADAPTER_INTERFACE, "PowerState");

WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#239: FILE: src/adapter.c:3156:
+ } else if (adapter->power_state_target == ADAPTER_POWER_STATE_TARGET_NONE) {

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#245: FILE: src/adapter.c:3162:
+ if (adapter->power_state_target == ADAPTER_POWER_STATE_TARGET_ON)

WARNING:LONG_LINE_STRING: line length of 81 exceeds 80 columns
#273: FILE: src/adapter.c:5620:
+ ADAPTER_INTERFACE, "PowerState");

WARNING:LONG_LINE_STRING: line length of 81 exceeds 80 columns
#282: FILE: src/adapter.c:7365:
+ ADAPTER_INTERFACE, "PowerState");

/github/workspace/src/12960593.patch total: 1 errors, 9 warnings, 197 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/12960593.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

---
Regards,
Linux Bluetooth