* [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT
@ 2022-09-22 20:38 Brian Gix
2022-09-22 20:38 ` [PATCH BlueZ 1/4] mgmt: Add support for Mesh in the kernel Brian Gix
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Brian Gix @ 2022-09-22 20:38 UTC (permalink / raw)
To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland
This patchset enables the mesh daemon (bluetooth-meshd) to use the new
MGMT mesh opcodes and events to send and receive Mesh packets. By
default, the daemon attempts to enable the experimental mesh
functionality, and query the kernel for active mesh support before then
enumerating the available controllers and selecting ojne that works.
If no kernel support is found, it will continue to use a raw HCI socket
for mesh support.
Brian Gix (4):
mgmt: Add support for Mesh in the kernel
lib: Add defines of new MGMT opcodes and events
mesh: Improve PB-ADV timing for reliability
mesh: Add new kernel MGMT based IO transport
Makefile.mesh | 9 +-
doc/mgmt-api.txt | 192 +++++++++++++++++++++++++++++++++--------
lib/mgmt.h | 6 ++
mesh/main.c | 39 ++++++++-
mesh/mesh-io-api.h | 11 ++-
mesh/mesh-io-generic.c | 47 +++-------
mesh/mesh-io-unit.c | 13 ++-
mesh/mesh-io.c | 188 ++++++++++++++++++++++++++++++----------
mesh/mesh-io.h | 4 +-
mesh/mesh-mgmt.c | 164 +++++++++++++++++++++++++++--------
mesh/mesh-mgmt.h | 12 ++-
mesh/mesh.c | 6 +-
mesh/mesh.h | 2 +-
mesh/pb-adv.c | 9 +-
14 files changed, 523 insertions(+), 179 deletions(-)
--
2.37.3
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH BlueZ 1/4] mgmt: Add support for Mesh in the kernel 2022-09-22 20:38 [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT Brian Gix @ 2022-09-22 20:38 ` Brian Gix 2022-09-22 21:32 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 2022-09-22 20:38 ` [PATCH BlueZ 2/4] lib: Add defines of new MGMT opcodes and events Brian Gix ` (3 subsequent siblings) 4 siblings, 1 reply; 11+ messages in thread From: Brian Gix @ 2022-09-22 20:38 UTC (permalink / raw) To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland These commands and events allow User space apps to test for Mesh support, and request incoming mesh packets be delivered and request outbound mesh packets to be sent. This is the basis for sharing one controller between the legacy bluetoothd daemon and the mesh bluetooth-meshd daemon. --- doc/mgmt-api.txt | 192 ++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 157 insertions(+), 35 deletions(-) diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index 23ea42228..90d612ed8 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -3861,45 +3861,132 @@ Add Advertisement Patterns Monitor With RSSI Threshold Command Invalid Parameters -Set Quality Report Command -========================== +Set Mesh Receiver Command +========================= Command Code: 0x0057 Controller Index: <controller id> - Command Parameters: Quality_Report (1 Octet) - Return Parameters: Current_Settings (4 Octets) + Command Parameters: Enable (1 Octets) + Window (2 Octets) + Period (2 Octets) + Num AD Types (1 Octets) + AD Types { } - This command is used to enable and disable the controller's quality - report feature. The allowed values for the Quality_Report command - parameter are 0x00 and 0x01. All other values will return Invalid - Parameters. + This command Enables or Disables Mesh Receiving. When enabled passive + scanning remains enabled for this controller. + + The Window/Period values are used to set the Scan Parameters when no + other scanning is being done. + + Num AD Types and AD Types parameter, filter Advertising and Scan + responses by AD type. Reponses that do not contain at least one of the + requested AD types will be ignored. Otherwise they will be delivered + with the Mesh Device Found event. + + Possible errors: Failed + No Resources + Invalid Parameters + + +Read Mesh Features Command +========================== + + Command Code: 0x0058 + Controller Index: <controller id> + Command Parameters: + Return Parameters: Index (2 Octets) + Max Handles (1 Octets) + Used Handles (1 Octets) + Handle { } - The value 0x00 disables the Quality Report, and the value 0x01 - enables the Quality Report feature. + This command is used to both verify that Outbound Mesh packet + support is enabled, and to indicate the number of packets that + can and are simultaneously queued. - This command is only available for the controllers that support - either AOSP Bluetooth quality report or Intel telemetry event. - It is supported if the supported_settings indicate support for it. + Index identifies the HCI Controller that this information is valid for. - This command requires to use a valid controller index. Otherwise, - an Invalid Index status will be returned. + Max Handles indicates the maximum number of packets that may be queued. - The command is sent to the controller to enable/disable the quality - report feature, and generates a Command Complete event on success. - If the controller failed to execute the action, a Failed status will - be returned. + Used Handles indicates the number of packets awaiting transmission. - The quality report state is maintained by the kernel over the adapter - power cycle. When the adapter is powered off, the quality report - feature is disabled by the kernel. When the adapter is powered on, it - is enabled again by the kernel if it was enabled before. + Handle is an array of the currently outstanding packets. Possible errors: Failed - Invalid Index + No Resources Invalid Parameters - Not Supported +Transmit Mesh Packet Command +============================ + + Command Code: 0x0059 + Controller Index: <controller id> + Command Parameters: Addr (6 octets) + Addr Type (1 Octets) + Instant (8 Octets) + Delay (2 Octets) + Count (1 Octets) + Data Length (1 Octets) + Data (variable) + + Return Parameters: Handle (1 Octets) + + This command sends a Mesh Packet as a NONCONN LE Advertisement. + + The Addr + Addr Type parameters specifify the address to use in the + outbound advertising packet. If BD_ADDR_ANY and LE_RANDOM is set, the + kernel will create a single use non-resolvable address. + + The Instant parameter is used in combination with the Delay + parameter, to finely time the sending of the Advertising packet. It + should be set to the Instant value tag of a received incoming + Mesh Device Found Event. It is only useful in POLL-RESPONSE situations + where a response must be sent within a negotiated time window. The value + of the Instant parameter should not be interpreted by the host, and + only has meaning to the controller. + + The Delay parameter, if 0x0000, will cause the packet to be sent + at the earliest opportunity. If non-Zero, and the controller supports + delayed delivery, the Instant and Delay parameters will be used + to delay the outbound packet. While the Instant is not defined, the + Delay is specified in milliseconds. + + The Count parameter must be sent to a non-Zero value indicating the + number of times this packet will be sent before transmission completes. + If the Delay parameter is non-Zero, then Count must be 1 only. + + The Data parameter is an octet array of the AD Type and Mesh Packet. + + This command will return immediately, and if it succeeds, will generate + a Mesh Packet Transmission Complete event when after the packet has been + sent. + + Possible errors: Failed + Busy + No Resources + Invalid Parameters + + +Cancel Transmit Mesh Packet Command +=================================== + + Command Code: 0x005A + Controller Index: <controller id> + Command Parameters: Handle (1 Octets) + + This command may be used to cancel an outbound transmission request. + + The Handle parameter is the returned handle from a successful Transmit + Mesh Packet request. If Zero is specified as the handle, all outstanding + send requests are canceled. + + For each mesh packet canceled, the Mesh Packet Transmission Complete + event will be generated, regardless of whether the packet was sent + successfully. + + Possible errors: Failed + Invalid Parameters + Command Complete Event ====================== @@ -5022,20 +5109,55 @@ Advertisement Monitor Device Lost Event This event will be sent to all management sockets. -Quality Report Event -==================== +Mesh Device Found Event +======================= Event code: 0x0031 Controller Index: <controller_id> - Event Parameters: Quality_Spec (1 Octet) - Report_Len (2 Octets) - Report (0-65535 Octets) + Event Parameters: Address (6 Octets) + Address_Type (1 Octet) + RSSI (1 Octet) + Instant (8 Octets) + Flags (4 Octets) + AD_Data_Length (2 Octets) + AD_Data (0-65535 Octets) - This event carries the Bluetooth quality report sent by the - controller. + This event indicates that the controller has received an Advertisement + or Scan Result containing an AD Type matching the Mesh scan set. + + The address of the sending device is returned, and must be a valid LE + Address_Type. + + Possible values for the Address_Type parameter: + 0 Reserved (not in use) + 1 LE Public + 2 LE Random + + The RSSI field is a signed octet, and is the RSSI reported by the + receiving controller. + + The Instant field is 64 bit value that represents the instant in time + the packet was received. It's value is not intended to be interpretted + by the host, and is only useful if the host wants to make a timed + response to the received packet. (i.e. a Poll/Response) + + AD_Length and AD_Data contains the Info structure of Advertising and + Scan rsults. To receive this event, AD filters must be requested with + the Set Mesh Receiver command command, specifying which AD Types to + return. All AD structures will be received in this event if any of the + filtered AD Types are present. + + This event will be sent to all management sockets. + + +Mesh Packet Transmit Complete Event +=================================== + + Event code: 0x0032 + Controller Index: <controller_id> + Event Parameters: Handle (1 Octets) - Possible values for the Quality_Spec parameter: - 0 AOSP Bluetooth Quality Report Event - 1 Intel Telemetry Event + This event indicates that a requested outbound Mesh packet has + completed and no longer occupies a transmit slot. This event will be sent to all management sockets. -- 2.37.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: Mesh demon switched to using kernel Mesh MGMT 2022-09-22 20:38 ` [PATCH BlueZ 1/4] mgmt: Add support for Mesh in the kernel Brian Gix @ 2022-09-22 21:32 ` bluez.test.bot 0 siblings, 0 replies; 11+ messages in thread From: bluez.test.bot @ 2022-09-22 21:32 UTC (permalink / raw) To: linux-bluetooth, brian.gix [-- Attachment #1: Type: text/plain, Size: 9694 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679601 ---Test result--- Test Summary: CheckPatch FAIL 6.13 seconds GitLint PASS 3.99 seconds Prep - Setup ELL PASS 27.65 seconds Build - Prep PASS 0.86 seconds Build - Configure PASS 9.01 seconds Build - Make FAIL 111.00 seconds Make Check FAIL 1136.95 seconds Make Check w/Valgrind FAIL 85.66 seconds Make Distcheck FAIL 11.62 seconds Build w/ext ELL - Configure PASS 8.98 seconds Build w/ext ELL - Make FAIL 39.83 seconds Incremental Build w/ patches FAIL 354.58 seconds Scan Build FAIL 633.10 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script with rule in .checkpatch.conf Output: [BlueZ,1/4] mgmt: Add support for Mesh in the kernel WARNING:REPEATED_WORD: Possible repeated word: 'command' #282: FILE: doc/mgmt-api.txt:5146: + the Set Mesh Receiver command command, specifying which AD Types to /github/workspace/src/12985789.patch total: 0 errors, 1 warnings, 222 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/12985789.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [BlueZ,3/4] mesh: Improve PB-ADV timing for reliability WARNING:TYPO_SPELLING: 'dependant' may be misspelled - perhaps 'dependent'? #66: Because provisioning is not speed dependant, Timing on outbound PB-ADV ^^^^^^^^^ /github/workspace/src/12985788.patch total: 0 errors, 1 warnings, 33 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/12985788.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [BlueZ,4/4] mesh: Add new kernel MGMT based IO transport WARNING:LEADING_SPACE: please, no spaces at the start of a line #698: FILE: mesh/mesh-mgmt.c:36: + 0x76, 0x6e, 0xf3, 0xe8, 0x24, 0x5f, 0x05, 0xbf, /* UUID - Mesh */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #699: FILE: mesh/mesh-mgmt.c:37: + 0x8d, 0x4d, 0x03, 0x7a, 0xd7, 0x63, 0xe4, 0x2c,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #700: FILE: mesh/mesh-mgmt.c:38: + 0x01, /* Action - enable */$ /github/workspace/src/12985790.patch total: 0 errors, 3 warnings, 806 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/12985790.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: Build - Make - FAIL Desc: Build the BlueZ source tree Output: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12470:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12470 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Make Check - FAIL Desc: Run 'make check' Output: unit/test-avdtp.c: In function ‘main’: unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 766 | int main(int argc, char *argv[]) | ^~~~ unit/test-avrcp.c: In function ‘main’: unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 989 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make: *** [Makefile:11588: check] Error 2 ############################## Test: Make Check w/Valgrind - FAIL Desc: Run 'make check' with Valgrind Output: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12470:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12470 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Make Distcheck - FAIL Desc: Run distcheck to check the distribution Output: make[2]: *** No rule to make target 'mesh/mesh-io-mgmt.h', needed by 'distdir-am'. Stop. make[1]: *** [Makefile:11421: distdir] Error 2 make: *** [Makefile:11497: dist] Error 2 ############################## Test: Build w/ext ELL - Make - FAIL Desc: Build BlueZ source with '--enable-external-ell' configuration Output: mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Incremental Build w/ patches - FAIL Desc: Incremental build per patch in the series Output: mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Scan Build - FAIL Desc: Run Scan Build with patches Output: tools/btpclient.c:2494:3: warning: Value stored to 'reply' is never read reply = l_dbus_message_new_error(ag.pending_req, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. In file included from unit/test-mesh-crypto.c:20: In file included from ./mesh/crypto.c:18: In file included from ./ell/ell.h:1: ./ell/util.h:187:9: warning: 1st function call argument is an uninitialized value return L_BE32_TO_CPU(L_GET_UNALIGNED((const uint32_t *) ptr)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./ell/util.h:89:28: note: expanded from macro 'L_BE32_TO_CPU' #define L_BE32_TO_CPU(val) bswap_32(val) ^~~~~~~~~~~~~ /usr/include/byteswap.h:34:21: note: expanded from macro 'bswap_32' #define bswap_32(x) __bswap_32 (x) ^~~~~~~~~~~~~~ unit/test-mesh-crypto.c:965:11: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage key_aid |= KEY_ID_AKF; ~~~~~~~ ^ unit/test-mesh-crypto.c:1008:2: warning: 4th function call argument is an uninitialized value verify_uint8("NID", 0, keys->net_nid, nid); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ unit/test-mesh-crypto.c:1289:6: warning: Branch condition evaluates to a garbage value if (ctl) { ^~~ unit/test-mesh-crypto.c:1509:7: warning: Branch condition evaluates to a garbage value if (net_ctl) { ^~~~~~~ unit/test-mesh-crypto.c:1763:2: warning: 1st function call argument is an uninitialized value l_put_be64(cmac_tmp, cmac); ^~~~~~~~~~~~~~~~~~~~~~~~~~ 6 warnings generated. src/advertising.c:898:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull' memcpy(cp->data + adv_data_len, scan_rsp, scan_rsp_len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make: *** [Makefile:4451: all] Error 2 --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH BlueZ 2/4] lib: Add defines of new MGMT opcodes and events 2022-09-22 20:38 [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT Brian Gix 2022-09-22 20:38 ` [PATCH BlueZ 1/4] mgmt: Add support for Mesh in the kernel Brian Gix @ 2022-09-22 20:38 ` Brian Gix 2022-09-22 20:38 ` [PATCH BlueZ 3/4] mesh: Improve PB-ADV timing for reliability Brian Gix ` (2 subsequent siblings) 4 siblings, 0 replies; 11+ messages in thread From: Brian Gix @ 2022-09-22 20:38 UTC (permalink / raw) To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland Populated new opcodes and events into static mgmt_ev and mgmt_op string arrays. --- lib/mgmt.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/mgmt.h b/lib/mgmt.h index 79b77d31a..796190cd9 100644 --- a/lib/mgmt.h +++ b/lib/mgmt.h @@ -1170,6 +1170,10 @@ static const char *mgmt_op[] = { "Add Extended Advertisement Parameters", /* 0x0054 */ "Add Extended Advertisement Data", "Add Advertisement Patterns Monitor RSSI", + "Set Mesh Receiver", + "Read Mesh Features", + "Mesh Send", + "Mesh Send Cancel", }; static const char *mgmt_ev[] = { @@ -1222,6 +1226,8 @@ static const char *mgmt_ev[] = { "Controller Resume", "Advertisement Monitor Device Found", /* 0x002f */ "Advertisement Monitor Device Lost", + "Mesh Packet Found", + "Mesh Packet Complete", }; static const char *mgmt_status[] = { -- 2.37.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH BlueZ 3/4] mesh: Improve PB-ADV timing for reliability 2022-09-22 20:38 [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT Brian Gix 2022-09-22 20:38 ` [PATCH BlueZ 1/4] mgmt: Add support for Mesh in the kernel Brian Gix 2022-09-22 20:38 ` [PATCH BlueZ 2/4] lib: Add defines of new MGMT opcodes and events Brian Gix @ 2022-09-22 20:38 ` Brian Gix 2022-09-22 20:38 ` [PATCH BlueZ 4/4] mesh: Add new kernel MGMT based IO transport Brian Gix 2022-09-22 21:20 ` [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT patchwork-bot+bluetooth 4 siblings, 0 replies; 11+ messages in thread From: Brian Gix @ 2022-09-22 20:38 UTC (permalink / raw) To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland Because provisioning is not speed dependant, Timing on outbound PB-ADV packets have been modified to be less likely missed by remote controlers with looser timing capabilities. --- mesh/pb-adv.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c index 83f922aa8..180b16258 100644 --- a/mesh/pb-adv.c +++ b/mesh/pb-adv.c @@ -23,6 +23,8 @@ #include "mesh/provision.h" #include "mesh/pb-adv.h" +#include "mesh/util.h" + struct pb_adv_session { mesh_prov_open_func_t open_cb; @@ -158,7 +160,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, l_debug("max_seg: %2.2x", max_seg); l_debug("size: %2.2x, CRC: %2.2x", size, buf[9]); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, init_size + 10); consumed = init_size; @@ -174,7 +176,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, buf[6] = (i << 2) | 0x02; memcpy(buf + 7, data + consumed, seg_size); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, seg_size + 7); consumed += seg_size; @@ -270,7 +272,8 @@ static void send_ack(struct pb_adv_session *session, uint8_t trans_num) ack.trans_num = trans_num; ack.opcode = PB_ADV_ACK; - pb_adv_send(session, 1, 100, &ack, sizeof(ack)); + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, + &ack, sizeof(ack)); } static void send_close_ind(struct pb_adv_session *session, uint8_t reason) -- 2.37.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH BlueZ 4/4] mesh: Add new kernel MGMT based IO transport 2022-09-22 20:38 [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT Brian Gix ` (2 preceding siblings ...) 2022-09-22 20:38 ` [PATCH BlueZ 3/4] mesh: Improve PB-ADV timing for reliability Brian Gix @ 2022-09-22 20:38 ` Brian Gix 2022-09-22 21:20 ` [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT patchwork-bot+bluetooth 4 siblings, 0 replies; 11+ messages in thread From: Brian Gix @ 2022-09-22 20:38 UTC (permalink / raw) To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland 1. Re-structures MGMT handling such that it is used to detect kernel support of the mesh MGMT opcodes and events before selecting between using MGMT or the legacy raw HCI socket method. 2. Re-structures main() to allow command line to prefer MGMT over HCI or visa versa, plus optionally pass an explicte controller. 3. Adds mesh-io-mgmt as a transport. --- Makefile.mesh | 9 +- mesh/main.c | 39 ++++++++- mesh/mesh-io-api.h | 11 ++- mesh/mesh-io-generic.c | 47 +++-------- mesh/mesh-io-unit.c | 13 ++- mesh/mesh-io.c | 188 ++++++++++++++++++++++++++++++----------- mesh/mesh-io.h | 4 +- mesh/mesh-mgmt.c | 164 +++++++++++++++++++++++++++-------- mesh/mesh-mgmt.h | 12 ++- mesh/mesh.c | 6 +- mesh/mesh.h | 2 +- 11 files changed, 354 insertions(+), 141 deletions(-) diff --git a/Makefile.mesh b/Makefile.mesh index fc28b0557..3047f362b 100644 --- a/Makefile.mesh +++ b/Makefile.mesh @@ -13,12 +13,11 @@ endif mesh_sources = mesh/mesh.h mesh/mesh.c \ mesh/net-keys.h mesh/net-keys.c \ mesh/mesh-io.h mesh/mesh-io.c \ - mesh/mesh-mgmt.c mesh/mesh-mgmt.h \ + mesh/mesh-mgmt.h mesh/mesh-mgmt.c \ mesh/error.h mesh/mesh-io-api.h \ - mesh/mesh-io-generic.h \ - mesh/mesh-io-generic.c \ - mesh/mesh-io-unit.h \ - mesh/mesh-io-unit.c \ + mesh/mesh-io-unit.h mesh/mesh-io-unit.c \ + mesh/mesh-io-mgmt.h mesh/mesh-io-mgmt.c \ + mesh/mesh-io-generic.h mesh/mesh-io-generic.c \ mesh/net.h mesh/net.c \ mesh/crypto.h mesh/crypto.c \ mesh/friend.h mesh/friend.c \ diff --git a/mesh/main.c b/mesh/main.c index dd99c3085..619b17d88 100644 --- a/mesh/main.c +++ b/mesh/main.c @@ -123,6 +123,12 @@ static void disconnect_callback(void *user_data) l_main_quit(); } +static void kill_to(struct l_timeout *timeout, void *user_data) +{ + l_timeout_remove(timeout); + l_main_quit(); +} + static void signal_handler(uint32_t signo, void *user_data) { static bool terminated; @@ -131,13 +137,38 @@ static void signal_handler(uint32_t signo, void *user_data) return; l_info("Terminating"); - l_main_quit(); + mesh_cleanup(true); + l_timeout_create(1, kill_to, NULL, NULL); terminated = true; } static bool parse_io(const char *optarg, enum mesh_io_type *type, void **opts) { - if (strstr(optarg, "generic") == optarg) { + if (strstr(optarg, "auto") == optarg) { + int *index = l_new(int, 1); + + *type = MESH_IO_TYPE_AUTO; + *opts = index; + + optarg += strlen("auto"); + if (!*optarg) { + *index = MGMT_INDEX_NONE; + return true; + } + + if (*optarg != ':') + return false; + + optarg++; + + if (sscanf(optarg, "hci%d", index) == 1) + return true; + + if (sscanf(optarg, "%d", index) == 1) + return true; + + return false; + } else if (strstr(optarg, "generic") == optarg) { int *index = l_new(int, 1); *type = MESH_IO_TYPE_GENERIC; @@ -251,7 +282,7 @@ int main(int argc, char *argv[]) } if (!io) - io = l_strdup_printf("generic"); + io = l_strdup_printf("auto"); if (!parse_io(io, &io_type, &io_opts)) { l_error("Invalid io: %s", io); @@ -295,7 +326,7 @@ done: l_free(io); l_free(io_opts); - mesh_cleanup(); + mesh_cleanup(false); l_dbus_destroy(dbus); l_main_exit(); diff --git a/mesh/mesh-io-api.h b/mesh/mesh-io-api.h index 61f79f224..21c505cd0 100644 --- a/mesh/mesh-io-api.h +++ b/mesh/mesh-io-api.h @@ -10,8 +10,7 @@ struct mesh_io_private; -typedef bool (*mesh_io_init_t)(struct mesh_io *io, void *opts, - mesh_io_ready_func_t cb, void *user_data); +typedef bool (*mesh_io_init_t)(struct mesh_io *io, void *opts, void *user_data); typedef bool (*mesh_io_destroy_t)(struct mesh_io *io); typedef bool (*mesh_io_caps_t)(struct mesh_io *io, struct mesh_io_caps *caps); typedef bool (*mesh_io_send_t)(struct mesh_io *io, @@ -36,9 +35,13 @@ struct mesh_io_api { }; struct mesh_io { - enum mesh_io_type type; - const struct mesh_io_api *api; + int index; + int favored_index; + mesh_io_ready_func_t ready; + struct l_queue *rx_regs; struct mesh_io_private *pvt; + void *user_data; + const struct mesh_io_api *api; }; struct mesh_io_table { diff --git a/mesh/mesh-io-generic.c b/mesh/mesh-io-generic.c index 2d7ef261e..827128ec8 100644 --- a/mesh/mesh-io-generic.c +++ b/mesh/mesh-io-generic.c @@ -19,6 +19,7 @@ #include "monitor/bt.h" #include "src/shared/hci.h" +#include "src/shared/mgmt.h" #include "lib/bluetooth.h" #include "lib/mgmt.h" @@ -29,14 +30,12 @@ #include "mesh/mesh-io-generic.h" struct mesh_io_private { + struct mesh_io *io; struct bt_hci *hci; - void *user_data; - mesh_io_ready_func_t ready_callback; struct l_timeout *tx_timeout; struct l_queue *rx_regs; struct l_queue *tx_pkts; struct tx_pkt *tx; - uint16_t index; uint16_t interval; bool sending; bool active; @@ -385,16 +384,13 @@ static void hci_init(void *user_data) { struct mesh_io *io = user_data; bool result = true; - bool restarted = false; - if (io->pvt->hci) { - restarted = true; + if (io->pvt->hci) bt_hci_unref(io->pvt->hci); - } - io->pvt->hci = bt_hci_new_user_channel(io->pvt->index); + io->pvt->hci = bt_hci_new_user_channel(io->index); if (!io->pvt->hci) { - l_error("Failed to start mesh io (hci %u): %s", io->pvt->index, + l_error("Failed to start mesh io (hci %u): %s", io->index, strerror(errno)); result = false; } @@ -405,47 +401,26 @@ static void hci_init(void *user_data) bt_hci_register(io->pvt->hci, BT_HCI_EVT_LE_META_EVENT, event_callback, io, NULL); - l_debug("Started mesh on hci %u", io->pvt->index); + l_debug("Started mesh on hci %u", io->index); - if (restarted) - restart_scan(io->pvt); + restart_scan(io->pvt); } - if (io->pvt->ready_callback) - io->pvt->ready_callback(io->pvt->user_data, result); + if (io->ready) + io->ready(io->user_data, result); } -static void read_info(int index, void *user_data) -{ - struct mesh_io *io = user_data; - - if (io->pvt->index != MGMT_INDEX_NONE && - index != io->pvt->index) { - l_debug("Ignore index %d", index); - return; - } - - io->pvt->index = index; - hci_init(io); -} - -static bool dev_init(struct mesh_io *io, void *opts, - mesh_io_ready_func_t cb, void *user_data) +static bool dev_init(struct mesh_io *io, void *opts, void *user_data) { if (!io || io->pvt) return false; io->pvt = l_new(struct mesh_io_private, 1); - io->pvt->index = *(int *)opts; io->pvt->rx_regs = l_queue_new(); io->pvt->tx_pkts = l_queue_new(); - io->pvt->ready_callback = cb; - io->pvt->user_data = user_data; - - if (io->pvt->index == MGMT_INDEX_NONE) - return mesh_mgmt_list(read_info, io); + io->pvt->io = io; l_idle_oneshot(hci_init, io, NULL); diff --git a/mesh/mesh-io-unit.c b/mesh/mesh-io-unit.c index bf3f808e4..f4f619803 100644 --- a/mesh/mesh-io-unit.c +++ b/mesh/mesh-io-unit.c @@ -25,13 +25,13 @@ #include "mesh/dbus.h" #include "mesh/mesh-io.h" #include "mesh/mesh-io-api.h" -#include "mesh/mesh-io-generic.h" +#include "mesh/mesh-io-unit.h" struct mesh_io_private { + struct mesh_io *io; struct l_io *sio; void *user_data; char *unique_name; - mesh_io_ready_func_t ready_callback; struct l_timeout *tx_timeout; struct l_queue *rx_regs; struct l_queue *tx_pkts; @@ -203,14 +203,13 @@ static void unit_up(void *user_data) l_debug("Started io-unit"); - if (pvt->ready_callback) - pvt->ready_callback(pvt->user_data, true); + if (pvt->io && pvt->io->ready) + pvt->io->ready(pvt->user_data, true); l_timeout_create_ms(1, get_name, pvt, NULL); } -static bool unit_init(struct mesh_io *io, void *opt, - mesh_io_ready_func_t cb, void *user_data) +static bool unit_init(struct mesh_io *io, void *opt, void *user_data) { struct mesh_io_private *pvt; char *sk_path; @@ -247,7 +246,7 @@ static bool unit_init(struct mesh_io *io, void *opt, pvt->rx_regs = l_queue_new(); pvt->tx_pkts = l_queue_new(); - pvt->ready_callback = cb; + pvt->io = io; pvt->user_data = user_data; io->pvt = pvt; diff --git a/mesh/mesh-io.c b/mesh/mesh-io.c index 96891313a..32e6e2521 100644 --- a/mesh/mesh-io.c +++ b/mesh/mesh-io.c @@ -15,95 +15,160 @@ #include <ell/ell.h> #include "lib/bluetooth.h" +#include "lib/mgmt.h" +#include "src/shared/mgmt.h" #include "mesh/mesh-defs.h" +#include "mesh/mesh-mgmt.h" #include "mesh/mesh-io.h" #include "mesh/mesh-io-api.h" /* List of Mesh-IO Type headers */ +#include "mesh/mesh-io-mgmt.h" #include "mesh/mesh-io-generic.h" #include "mesh/mesh-io-unit.h" +struct mesh_io_reg { + mesh_io_recv_func_t cb; + void *user_data; + uint8_t len; + uint8_t filter[]; +} packed; + /* List of Supported Mesh-IO Types */ static const struct mesh_io_table table[] = { - {MESH_IO_TYPE_GENERIC, &mesh_io_generic}, + {MESH_IO_TYPE_MGMT, &mesh_io_mgmt}, + {MESH_IO_TYPE_GENERIC, &mesh_io_generic}, {MESH_IO_TYPE_UNIT_TEST, &mesh_io_unit}, }; -static struct l_queue *io_list; +static struct mesh_io *default_io; -static bool match_by_io(const void *a, const void *b) +static const struct mesh_io_api *io_api(enum mesh_io_type type) { - return a == b; + uint16_t i; + + for (i = 0; i < L_ARRAY_SIZE(table); i++) { + if (table[i].type == type) + return table[i].api; + } + + return NULL; } -static bool match_by_type(const void *a, const void *b) +static void refresh_rx(void *a, void *b) { - const struct mesh_io *io = a; - const enum mesh_io_type type = L_PTR_TO_UINT(b); + struct mesh_io_reg *rx_reg = a; + struct mesh_io *io = b; - return io->type == type; + if (io->api && io->api->reg) + io->api->reg(io, rx_reg->filter, rx_reg->len, rx_reg->cb, + rx_reg->user_data); } -struct mesh_io *mesh_io_new(enum mesh_io_type type, void *opts, - mesh_io_ready_func_t cb, void *user_data) +static void ctl_alert(int index, bool up, bool pwr, bool mesh, void *user_data) { + enum mesh_io_type type = L_PTR_TO_UINT(user_data); const struct mesh_io_api *api = NULL; - struct mesh_io *io; - uint16_t i; - for (i = 0; i < L_ARRAY_SIZE(table); i++) { - if (table[i].type == type) { - api = table[i].api; - break; - } - } - - io = l_queue_find(io_list, match_by_type, L_UINT_TO_PTR(type)); + l_warn("up:%d pwr: %d mesh: %d", up, pwr, mesh); - if (!api || !api->init || io) - return NULL; + /* If specific IO controller requested, honor it */ + if (default_io->favored_index != MGMT_INDEX_NONE && + default_io->favored_index != index) + return; - io = l_new(struct mesh_io, 1); + if (!up && default_io->index == index) { + /* Our controller has disappeared */ + if (default_io->api && default_io->api->destroy) { + default_io->api->destroy(default_io); + default_io->api = NULL; + } - io->type = type; - io->api = api; + /* Re-enumerate controllers */ + mesh_mgmt_list(ctl_alert, user_data); + return; + } - if (!api->init(io, opts, cb, user_data)) - goto fail; + /* If we already have an API, keep using it */ + if (!up || default_io->api) + return; - if (!io_list) - io_list = l_queue_new(); + if (mesh && type != MESH_IO_TYPE_GENERIC) + api = io_api(MESH_IO_TYPE_MGMT); - if (l_queue_push_head(io_list, io)) - return io; + else if (!pwr) + api = io_api(MESH_IO_TYPE_GENERIC); -fail: - if (api->destroy) - api->destroy(io); + if (api) { + default_io->index = index; + default_io->api = api; + api->init(default_io, &index, default_io->user_data); - l_free(io); - return NULL; + l_queue_foreach(default_io->rx_regs, refresh_rx, default_io); + } } -void mesh_io_destroy(struct mesh_io *io) +static void free_io(struct mesh_io *io) { - io = l_queue_remove_if(io_list, match_by_io, io); if (io && io->api && io->api->destroy) io->api->destroy(io); + l_queue_destroy(io->rx_regs, l_free); + io->rx_regs = NULL; l_free(io); + l_warn("Destroy %p", io); +} + +struct mesh_io *mesh_io_new(enum mesh_io_type type, void *opts, + mesh_io_ready_func_t cb, void *user_data) +{ + const struct mesh_io_api *api = NULL; - if (l_queue_isempty(io_list)) { - l_queue_destroy(io_list, NULL); - io_list = NULL; + /* Only allow one IO */ + if (default_io) + return NULL; + + default_io = l_new(struct mesh_io, 1); + default_io->ready = cb; + default_io->user_data = user_data; + default_io->favored_index = *(int *) opts; + default_io->rx_regs = l_queue_new(); + + if (type >= MESH_IO_TYPE_AUTO) { + if (!mesh_mgmt_list(ctl_alert, L_UINT_TO_PTR(type))) + goto fail; + + return default_io; } + + api = io_api(type); + + if (!api || !api->init) + goto fail; + + default_io->api = api; + + if (!api->init(default_io, &default_io->favored_index, user_data)) + goto fail; + + return default_io; + +fail: + free_io(default_io); + default_io = NULL; + return NULL; +} + +void mesh_io_destroy(struct mesh_io *io) +{ } bool mesh_io_get_caps(struct mesh_io *io, struct mesh_io_caps *caps) { - io = l_queue_find(io_list, match_by_io, io); + if (io != default_io) + return false; if (io && io->api && io->api->caps) return io->api->caps(io, caps); @@ -115,7 +180,17 @@ bool mesh_io_register_recv_cb(struct mesh_io *io, const uint8_t *filter, uint8_t len, mesh_io_recv_func_t cb, void *user_data) { - io = l_queue_find(io_list, match_by_io, io); + struct mesh_io_reg *rx_reg; + + if (io != default_io) + return false; + + rx_reg = l_malloc(sizeof(struct mesh_io_reg) + len); + rx_reg->cb = cb; + rx_reg->len = len; + rx_reg->user_data = user_data; + memcpy(rx_reg->filter, filter, len); + l_queue_push_head(io->rx_regs, rx_reg); if (io && io->api && io->api->reg) return io->api->reg(io, filter, len, cb, user_data); @@ -123,10 +198,24 @@ bool mesh_io_register_recv_cb(struct mesh_io *io, const uint8_t *filter, return false; } +static bool by_filter(const void *a, const void *b) +{ + const struct mesh_io_reg *rx_reg = a; + const uint8_t *filter = b; + + return rx_reg->filter[0] == filter[0]; +} + bool mesh_io_deregister_recv_cb(struct mesh_io *io, const uint8_t *filter, uint8_t len) { - io = l_queue_find(io_list, match_by_io, io); + struct mesh_io_reg *rx_reg; + + if (io != default_io) + return false; + + rx_reg = l_queue_remove_if(io->rx_regs, by_filter, filter); + l_free(rx_reg); if (io && io->api && io->api->dereg) return io->api->dereg(io, filter, len); @@ -137,10 +226,11 @@ bool mesh_io_deregister_recv_cb(struct mesh_io *io, const uint8_t *filter, bool mesh_io_send(struct mesh_io *io, struct mesh_io_send_info *info, const uint8_t *data, uint16_t len) { - io = l_queue_find(io_list, match_by_io, io); + if (io && io != default_io) + return false; if (!io) - io = l_queue_peek_head(io_list); + io = default_io; if (io && io->api && io->api->send) return io->api->send(io, info, data, len); @@ -151,7 +241,11 @@ bool mesh_io_send(struct mesh_io *io, struct mesh_io_send_info *info, bool mesh_io_send_cancel(struct mesh_io *io, const uint8_t *pattern, uint8_t len) { - io = l_queue_find(io_list, match_by_io, io); + if (io && io != default_io) + return false; + + if (!io) + io = default_io; if (io && io->api && io->api->cancel) return io->api->cancel(io, pattern, len); diff --git a/mesh/mesh-io.h b/mesh/mesh-io.h index 80ef3fa3e..9dd946cdf 100644 --- a/mesh/mesh-io.h +++ b/mesh/mesh-io.h @@ -14,8 +14,10 @@ struct mesh_io; enum mesh_io_type { MESH_IO_TYPE_NONE = 0, + MESH_IO_TYPE_UNIT_TEST, + MESH_IO_TYPE_AUTO, /* If MGMT required, add after here */ + MESH_IO_TYPE_MGMT, MESH_IO_TYPE_GENERIC, - MESH_IO_TYPE_UNIT_TEST }; enum mesh_io_timing_type { diff --git a/mesh/mesh-mgmt.c b/mesh/mesh-mgmt.c index 754093dbc..32254613b 100644 --- a/mesh/mesh-mgmt.c +++ b/mesh/mesh-mgmt.c @@ -12,35 +12,78 @@ #include <config.h> #endif +#include <ell/ell.h> + #include "lib/bluetooth.h" #include "lib/mgmt.h" #include "src/shared/mgmt.h" -#include "ell/queue.h" -#include "ell/log.h" -#include "ell/util.h" - #include "mesh/mesh-mgmt.h" -struct read_info_reg { - mesh_mgmt_read_info_func_t cb; - void *user_data; +struct mesh_controler { + int index; + bool mesh_support; + bool powered; }; -struct read_info_req { - int index; - struct mesh_io *io; +static mesh_mgmt_read_info_func_t ctl_info; +static struct mgmt *mgmt_mesh; +static struct l_queue *ctl_list; +static void *list_user_data; +static bool mesh_detected; + +static const uint8_t set_exp_feat_param_mesh[] = { + 0x76, 0x6e, 0xf3, 0xe8, 0x24, 0x5f, 0x05, 0xbf, /* UUID - Mesh */ + 0x8d, 0x4d, 0x03, 0x7a, 0xd7, 0x63, 0xe4, 0x2c, + 0x01, /* Action - enable */ }; -static struct mgmt *mgmt_mesh; -static struct l_queue *read_info_regs; +static bool by_index(const void *a, const void *b) +{ + const struct mesh_controler *ctl = a; + int index = L_PTR_TO_UINT(b); + + return ctl->index == index; +} -static void process_read_info_req(void *data, void *user_data) +static void index_removed(uint16_t index, uint16_t length, const void *param, + void *user_data); +static void features_cb(uint8_t status, uint16_t length, + const void *param, void *user_data) { - struct read_info_reg *reg = data; int index = L_PTR_TO_UINT(user_data); + struct mesh_controler *ctl; + - reg->cb(index, reg->user_data); + ctl = l_queue_find(ctl_list, by_index, L_UINT_TO_PTR(index)); + if (!ctl) + return; + + l_debug("Status: %d, Length: %d", status, length); + if (status != MGMT_STATUS_NOT_SUPPORTED && + status != MGMT_STATUS_UNKNOWN_COMMAND) { + ctl->mesh_support = true; + if (!mesh_detected) { + mgmt_register(mgmt_mesh, MGMT_EV_INDEX_REMOVED, + MGMT_INDEX_NONE, index_removed, + NULL, NULL); + } + mesh_detected = true; + } else + l_debug("Kernel mesh not supported for hci%u", index); + + if (ctl_info) + ctl_info(index, true, ctl->powered, ctl->mesh_support, + list_user_data); +} + +static void set_exp_mesh_cb(uint8_t status, uint16_t length, + const void *param, void *user_data) +{ + int index = L_PTR_TO_UINT(user_data); + + mesh_mgmt_send(MGMT_OP_MESH_READ_FEATURES, index, 0, NULL, + features_cb, L_UINT_TO_PTR(index), NULL); } static void read_info_cb(uint8_t status, uint16_t length, @@ -49,12 +92,25 @@ static void read_info_cb(uint8_t status, uint16_t length, int index = L_PTR_TO_UINT(user_data); const struct mgmt_rp_read_info *rp = param; uint32_t current_settings, supported_settings; + struct mesh_controler *ctl; l_debug("hci %u status 0x%02x", index, status); + ctl = l_queue_find(ctl_list, by_index, L_UINT_TO_PTR(index)); + if (!ctl) + return; + if (status != MGMT_STATUS_SUCCESS) { + ctl = l_queue_remove_if(ctl_list, by_index, + L_UINT_TO_PTR(index)); l_error("Failed to read info for hci index %u: %s (0x%02x)", index, mgmt_errstr(status), status); + + l_warn("Hci dev %d removal detected", index); + if (ctl && ctl_info) + ctl_info(index, false, false, false, list_user_data); + + l_free(ctl); return; } @@ -69,23 +125,36 @@ static void read_info_cb(uint8_t status, uint16_t length, l_debug("settings: supp %8.8x curr %8.8x", supported_settings, current_settings); - if (current_settings & MGMT_SETTING_POWERED) { - l_info("Controller hci %u is in use", index); - return; - } - if (!(supported_settings & MGMT_SETTING_LE)) { l_info("Controller hci %u does not support LE", index); + l_queue_remove(ctl_list, ctl); + l_free(ctl); return; } - l_queue_foreach(read_info_regs, process_read_info_req, - L_UINT_TO_PTR(index)); + if (current_settings & MGMT_SETTING_POWERED) + ctl->powered = true; + + mesh_mgmt_send(MGMT_OP_SET_EXP_FEATURE, index, + sizeof(set_exp_feat_param_mesh), + set_exp_feat_param_mesh, + set_exp_mesh_cb, L_UINT_TO_PTR(index), NULL); } static void index_added(uint16_t index, uint16_t length, const void *param, void *user_data) { + struct mesh_controler *ctl = l_queue_find(ctl_list, by_index, + L_UINT_TO_PTR(index)); + + if (!ctl) { + ctl = l_new(struct mesh_controler, 1); + ctl->index = index; + l_queue_push_head(ctl_list, ctl); + } else { + ctl->mesh_support = ctl->powered = false; + } + mgmt_send(mgmt_mesh, MGMT_OP_READ_INFO, index, 0, NULL, read_info_cb, L_UINT_TO_PTR(index), NULL); } @@ -93,7 +162,9 @@ static void index_added(uint16_t index, uint16_t length, const void *param, static void index_removed(uint16_t index, uint16_t length, const void *param, void *user_data) { - l_warn("Hci dev %4.4x removed", index); + mgmt_send(mgmt_mesh, MGMT_OP_READ_INFO, index, 0, NULL, + read_info_cb, L_UINT_TO_PTR(index), NULL); + } static void read_index_list_cb(uint8_t status, uint16_t length, @@ -133,8 +204,8 @@ static void read_index_list_cb(uint8_t status, uint16_t length, static bool mesh_mgmt_init(void) { - if (!read_info_regs) - read_info_regs = l_queue_new(); + if (!ctl_list) + ctl_list = l_queue_new(); if (!mgmt_mesh) { mgmt_mesh = mgmt_new_default(); @@ -146,8 +217,6 @@ static bool mesh_mgmt_init(void) mgmt_register(mgmt_mesh, MGMT_EV_INDEX_ADDED, MGMT_INDEX_NONE, index_added, NULL, NULL); - mgmt_register(mgmt_mesh, MGMT_EV_INDEX_REMOVED, - MGMT_INDEX_NONE, index_removed, NULL, NULL); } return true; @@ -155,16 +224,11 @@ static bool mesh_mgmt_init(void) bool mesh_mgmt_list(mesh_mgmt_read_info_func_t cb, void *user_data) { - struct read_info_reg *reg; - if (!mesh_mgmt_init()) return false; - reg = l_new(struct read_info_reg, 1); - reg->cb = cb; - reg->user_data = user_data; - - l_queue_push_tail(read_info_regs, reg); + ctl_info = cb; + list_user_data = user_data; /* Use MGMT to find a candidate controller */ l_debug("send read index_list"); @@ -175,3 +239,35 @@ bool mesh_mgmt_list(mesh_mgmt_read_info_func_t cb, void *user_data) return true; } + +void mesh_mgmt_destroy(void) +{ + mgmt_unref(mgmt_mesh); + mgmt_mesh = NULL; + ctl_info = NULL; + list_user_data = NULL; + l_queue_destroy(ctl_list, l_free); + ctl_list = NULL; +} + +unsigned int mesh_mgmt_send(uint16_t opcode, uint16_t index, + uint16_t length, const void *param, + mgmt_request_func_t callback, + void *user_data, mgmt_destroy_func_t destroy) +{ + return mgmt_send_timeout(mgmt_mesh, opcode, index, length, param, + callback, user_data, destroy, 0); +} + +unsigned int mesh_mgmt_register(uint16_t event, uint16_t index, + mgmt_notify_func_t callback, + void *user_data, mgmt_destroy_func_t destroy) +{ + return mgmt_register(mgmt_mesh, event, index, callback, + user_data, destroy); +} + +bool mesh_mgmt_unregister(unsigned int id) +{ + return mgmt_unregister(mgmt_mesh, id); +} diff --git a/mesh/mesh-mgmt.h b/mesh/mesh-mgmt.h index 90ac14e73..a3cd72faf 100644 --- a/mesh/mesh-mgmt.h +++ b/mesh/mesh-mgmt.h @@ -9,6 +9,16 @@ */ #include <stdbool.h> -typedef void (*mesh_mgmt_read_info_func_t)(int index, void *user_data); +typedef void (*mesh_mgmt_read_info_func_t)(int index, bool added, bool powered, + bool mesh, void *user_data); bool mesh_mgmt_list(mesh_mgmt_read_info_func_t cb, void *user_data); +unsigned int mesh_mgmt_send(uint16_t opcode, uint16_t index, + uint16_t length, const void *param, + mgmt_request_func_t callback, + void *user_data, mgmt_destroy_func_t destroy); +unsigned int mesh_mgmt_register(uint16_t event, uint16_t index, + mgmt_notify_func_t callback, + void *user_data, mgmt_destroy_func_t destroy); +bool mesh_mgmt_unregister(unsigned int id); +void mesh_mgmt_destroy(void); diff --git a/mesh/mesh.c b/mesh/mesh.c index 62d650328..91cf25175 100644 --- a/mesh/mesh.c +++ b/mesh/mesh.c @@ -324,11 +324,15 @@ static void free_pending_join_call(bool failed) join_pending = NULL; } -void mesh_cleanup(void) +void mesh_cleanup(bool signaled) { struct l_dbus_message *reply; mesh_io_destroy(mesh.io); + mesh.io = NULL; + + if (signaled) + return; if (join_pending) { diff --git a/mesh/mesh.h b/mesh/mesh.h index 0f77ebc58..c30a8d1f0 100644 --- a/mesh/mesh.h +++ b/mesh/mesh.h @@ -28,7 +28,7 @@ typedef void (*prov_rx_cb_t)(void *user_data, const uint8_t *data, bool mesh_init(const char *config_dir, const char *mesh_conf_fname, enum mesh_io_type type, void *opts, mesh_ready_func_t cb, void *user_data); -void mesh_cleanup(void); +void mesh_cleanup(bool signaled); bool mesh_dbus_init(struct l_dbus *dbus); const char *mesh_status_str(uint8_t err); -- 2.37.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT 2022-09-22 20:38 [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT Brian Gix ` (3 preceding siblings ...) 2022-09-22 20:38 ` [PATCH BlueZ 4/4] mesh: Add new kernel MGMT based IO transport Brian Gix @ 2022-09-22 21:20 ` patchwork-bot+bluetooth 4 siblings, 0 replies; 11+ messages in thread From: patchwork-bot+bluetooth @ 2022-09-22 21:20 UTC (permalink / raw) To: Gix, Brian; +Cc: linux-bluetooth, luiz.dentz, inga.stotland Hello: This series was applied to bluetooth/bluez.git (master) by Brian Gix <brian.gix@intel.com>: On Thu, 22 Sep 2022 13:38:48 -0700 you wrote: > This patchset enables the mesh daemon (bluetooth-meshd) to use the new > MGMT mesh opcodes and events to send and receive Mesh packets. By > default, the daemon attempts to enable the experimental mesh > functionality, and query the kernel for active mesh support before then > enumerating the available controllers and selecting ojne that works. > > If no kernel support is found, it will continue to use a raw HCI socket > for mesh support. > > [...] Here is the summary with links: - [BlueZ,1/4] mgmt: Add support for Mesh in the kernel https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0454e2d09570 - [BlueZ,2/4] lib: Add defines of new MGMT opcodes and events https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=721d5a8ae86d - [BlueZ,3/4] mesh: Improve PB-ADV timing for reliability (no matching commit) - [BlueZ,4/4] mesh: Add new kernel MGMT based IO transport (no matching commit) You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH BlueZ v2 1/2] mesh: Improve PB-ADV timing for reliability @ 2022-09-22 21:38 Brian Gix 2022-09-22 22:24 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 0 siblings, 1 reply; 11+ messages in thread From: Brian Gix @ 2022-09-22 21:38 UTC (permalink / raw) To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland Because provisioning is not speed dependent, Timing on outbound PB-ADV packets have been modified to be less likely missed by remote controlers with looser timing capabilities. --- mesh/pb-adv.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c index 83f922aa8..180b16258 100644 --- a/mesh/pb-adv.c +++ b/mesh/pb-adv.c @@ -23,6 +23,8 @@ #include "mesh/provision.h" #include "mesh/pb-adv.h" +#include "mesh/util.h" + struct pb_adv_session { mesh_prov_open_func_t open_cb; @@ -158,7 +160,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, l_debug("max_seg: %2.2x", max_seg); l_debug("size: %2.2x, CRC: %2.2x", size, buf[9]); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, init_size + 10); consumed = init_size; @@ -174,7 +176,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, buf[6] = (i << 2) | 0x02; memcpy(buf + 7, data + consumed, seg_size); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, seg_size + 7); consumed += seg_size; @@ -270,7 +272,8 @@ static void send_ack(struct pb_adv_session *session, uint8_t trans_num) ack.trans_num = trans_num; ack.opcode = PB_ADV_ACK; - pb_adv_send(session, 1, 100, &ack, sizeof(ack)); + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, + &ack, sizeof(ack)); } static void send_close_ind(struct pb_adv_session *session, uint8_t reason) -- 2.37.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: Mesh demon switched to using kernel Mesh MGMT 2022-09-22 21:38 [PATCH BlueZ v2 1/2] mesh: Improve PB-ADV timing for reliability Brian Gix @ 2022-09-22 22:24 ` bluez.test.bot 0 siblings, 0 replies; 11+ messages in thread From: bluez.test.bot @ 2022-09-22 22:24 UTC (permalink / raw) To: linux-bluetooth, brian.gix [-- Attachment #1: Type: text/plain, Size: 7797 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679617 ---Test result--- Test Summary: CheckPatch FAIL 3.34 seconds GitLint PASS 2.02 seconds Prep - Setup ELL PASS 26.81 seconds Build - Prep PASS 0.78 seconds Build - Configure PASS 8.57 seconds Build - Make FAIL 107.56 seconds Make Check FAIL 1082.79 seconds Make Check w/Valgrind FAIL 84.48 seconds Make Distcheck FAIL 11.32 seconds Build w/ext ELL - Configure PASS 8.73 seconds Build w/ext ELL - Make FAIL 38.90 seconds Incremental Build w/ patches FAIL 148.39 seconds Scan Build FAIL 524.34 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script with rule in .checkpatch.conf Output: [BlueZ,v2,2/2] mesh: Add new kernel MGMT based IO transport WARNING:LEADING_SPACE: please, no spaces at the start of a line #698: FILE: mesh/mesh-mgmt.c:36: + 0x76, 0x6e, 0xf3, 0xe8, 0x24, 0x5f, 0x05, 0xbf, /* UUID - Mesh */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #699: FILE: mesh/mesh-mgmt.c:37: + 0x8d, 0x4d, 0x03, 0x7a, 0xd7, 0x63, 0xe4, 0x2c,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #700: FILE: mesh/mesh-mgmt.c:38: + 0x01, /* Action - enable */$ /github/workspace/src/12985826.patch total: 0 errors, 3 warnings, 806 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/12985826.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: Build - Make - FAIL Desc: Build the BlueZ source tree Output: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12470:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12470 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Make Check - FAIL Desc: Run 'make check' Output: unit/test-avdtp.c: In function ‘main’: unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 766 | int main(int argc, char *argv[]) | ^~~~ unit/test-avrcp.c: In function ‘main’: unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 989 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make: *** [Makefile:11588: check] Error 2 ############################## Test: Make Check w/Valgrind - FAIL Desc: Run 'make check' with Valgrind Output: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12470:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12470 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Make Distcheck - FAIL Desc: Run distcheck to check the distribution Output: make[2]: *** No rule to make target 'mesh/mesh-io-mgmt.h', needed by 'distdir-am'. Stop. make[1]: *** [Makefile:11421: distdir] Error 2 make: *** [Makefile:11497: dist] Error 2 ############################## Test: Build w/ext ELL - Make - FAIL Desc: Build BlueZ source with '--enable-external-ell' configuration Output: mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Incremental Build w/ patches - FAIL Desc: Incremental build per patch in the series Output: mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Scan Build - FAIL Desc: Run Scan Build with patches Output: tools/btpclient.c:2494:3: warning: Value stored to 'reply' is never read reply = l_dbus_message_new_error(ag.pending_req, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. In file included from unit/test-mesh-crypto.c:20: In file included from ./mesh/crypto.c:18: In file included from ./ell/ell.h:1: ./ell/util.h:187:9: warning: 1st function call argument is an uninitialized value return L_BE32_TO_CPU(L_GET_UNALIGNED((const uint32_t *) ptr)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./ell/util.h:89:28: note: expanded from macro 'L_BE32_TO_CPU' #define L_BE32_TO_CPU(val) bswap_32(val) ^~~~~~~~~~~~~ /usr/include/byteswap.h:34:21: note: expanded from macro 'bswap_32' #define bswap_32(x) __bswap_32 (x) ^~~~~~~~~~~~~~ unit/test-mesh-crypto.c:965:11: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage key_aid |= KEY_ID_AKF; ~~~~~~~ ^ unit/test-mesh-crypto.c:1008:2: warning: 4th function call argument is an uninitialized value verify_uint8("NID", 0, keys->net_nid, nid); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ unit/test-mesh-crypto.c:1289:6: warning: Branch condition evaluates to a garbage value if (ctl) { ^~~ unit/test-mesh-crypto.c:1509:7: warning: Branch condition evaluates to a garbage value if (net_ctl) { ^~~~~~~ unit/test-mesh-crypto.c:1763:2: warning: 1st function call argument is an uninitialized value l_put_be64(cmac_tmp, cmac); ^~~~~~~~~~~~~~~~~~~~~~~~~~ 6 warnings generated. mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make: *** [Makefile:4451: all] Error 2 --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH BlueZ v3 1/2] mesh: Improve PB-ADV timing for reliability @ 2022-09-22 21:40 Brian Gix 2022-09-22 22:26 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 0 siblings, 1 reply; 11+ messages in thread From: Brian Gix @ 2022-09-22 21:40 UTC (permalink / raw) To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland Because provisioning is not speed dependent, Timing on outbound PB-ADV packets have been modified to be less likely missed by remote controlers with looser timing capabilities. --- mesh/pb-adv.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c index 83f922aa8..180b16258 100644 --- a/mesh/pb-adv.c +++ b/mesh/pb-adv.c @@ -23,6 +23,8 @@ #include "mesh/provision.h" #include "mesh/pb-adv.h" +#include "mesh/util.h" + struct pb_adv_session { mesh_prov_open_func_t open_cb; @@ -158,7 +160,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, l_debug("max_seg: %2.2x", max_seg); l_debug("size: %2.2x, CRC: %2.2x", size, buf[9]); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, init_size + 10); consumed = init_size; @@ -174,7 +176,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, buf[6] = (i << 2) | 0x02; memcpy(buf + 7, data + consumed, seg_size); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, seg_size + 7); consumed += seg_size; @@ -270,7 +272,8 @@ static void send_ack(struct pb_adv_session *session, uint8_t trans_num) ack.trans_num = trans_num; ack.opcode = PB_ADV_ACK; - pb_adv_send(session, 1, 100, &ack, sizeof(ack)); + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, + &ack, sizeof(ack)); } static void send_close_ind(struct pb_adv_session *session, uint8_t reason) -- 2.37.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: Mesh demon switched to using kernel Mesh MGMT 2022-09-22 21:40 [PATCH BlueZ v3 1/2] mesh: Improve PB-ADV timing for reliability Brian Gix @ 2022-09-22 22:26 ` bluez.test.bot 0 siblings, 0 replies; 11+ messages in thread From: bluez.test.bot @ 2022-09-22 22:26 UTC (permalink / raw) To: linux-bluetooth, brian.gix [-- Attachment #1: Type: text/plain, Size: 6512 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679618 ---Test result--- Test Summary: CheckPatch PASS 3.35 seconds GitLint PASS 2.02 seconds Prep - Setup ELL PASS 27.26 seconds Build - Prep PASS 0.79 seconds Build - Configure PASS 8.77 seconds Build - Make FAIL 108.23 seconds Make Check FAIL 1223.49 seconds Make Check w/Valgrind FAIL 86.48 seconds Make Distcheck FAIL 11.67 seconds Build w/ext ELL - Configure PASS 8.99 seconds Build w/ext ELL - Make FAIL 39.97 seconds Incremental Build w/ patches FAIL 149.47 seconds Scan Build FAIL 535.96 seconds Details ############################## Test: Build - Make - FAIL Desc: Build the BlueZ source tree Output: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12470:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12470 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Make Check - FAIL Desc: Run 'make check' Output: unit/test-avdtp.c: In function ‘main’: unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 766 | int main(int argc, char *argv[]) | ^~~~ unit/test-avrcp.c: In function ‘main’: unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 989 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make: *** [Makefile:11588: check] Error 2 ############################## Test: Make Check w/Valgrind - FAIL Desc: Run 'make check' with Valgrind Output: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12470:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12470 | int main(int argc, char *argv[]) | ^~~~ mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Make Distcheck - FAIL Desc: Run distcheck to check the distribution Output: make[2]: *** No rule to make target 'mesh/mesh-io-mgmt.h', needed by 'distdir-am'. Stop. make[1]: *** [Makefile:11421: distdir] Error 2 make: *** [Makefile:11497: dist] Error 2 ############################## Test: Build w/ext ELL - Make - FAIL Desc: Build BlueZ source with '--enable-external-ell' configuration Output: mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Incremental Build w/ patches - FAIL Desc: Incremental build per patch in the series Output: mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4451: all] Error 2 ############################## Test: Scan Build - FAIL Desc: Run Scan Build with patches Output: tools/btpclient.c:2494:3: warning: Value stored to 'reply' is never read reply = l_dbus_message_new_error(ag.pending_req, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. In file included from unit/test-mesh-crypto.c:20: In file included from ./mesh/crypto.c:18: In file included from ./ell/ell.h:1: ./ell/util.h:187:9: warning: 1st function call argument is an uninitialized value return L_BE32_TO_CPU(L_GET_UNALIGNED((const uint32_t *) ptr)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./ell/util.h:89:28: note: expanded from macro 'L_BE32_TO_CPU' #define L_BE32_TO_CPU(val) bswap_32(val) ^~~~~~~~~~~~~ /usr/include/byteswap.h:34:21: note: expanded from macro 'bswap_32' #define bswap_32(x) __bswap_32 (x) ^~~~~~~~~~~~~~ unit/test-mesh-crypto.c:965:11: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage key_aid |= KEY_ID_AKF; ~~~~~~~ ^ unit/test-mesh-crypto.c:1008:2: warning: 4th function call argument is an uninitialized value verify_uint8("NID", 0, keys->net_nid, nid); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ unit/test-mesh-crypto.c:1289:6: warning: Branch condition evaluates to a garbage value if (ctl) { ^~~ unit/test-mesh-crypto.c:1509:7: warning: Branch condition evaluates to a garbage value if (net_ctl) { ^~~~~~~ unit/test-mesh-crypto.c:1763:2: warning: 1st function call argument is an uninitialized value l_put_be64(cmac_tmp, cmac); ^~~~~~~~~~~~~~~~~~~~~~~~~~ 6 warnings generated. mesh/mesh-io.c:27:10: fatal error: mesh/mesh-io-mgmt.h: No such file or directory 27 | #include "mesh/mesh-io-mgmt.h" | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:7491: mesh/mesh-io.o] Error 1 make: *** [Makefile:4451: all] Error 2 --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH BlueZ v4 1/2] mesh: Improve PB-ADV timing for reliability @ 2022-09-22 22:31 Brian Gix 2022-09-22 23:26 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 0 siblings, 1 reply; 11+ messages in thread From: Brian Gix @ 2022-09-22 22:31 UTC (permalink / raw) To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland Because provisioning is not speed dependent, Timing on outbound PB-ADV packets have been modified to be less likely missed by remote controlers with looser timing capabilities. --- mesh/pb-adv.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c index 83f922aa8..180b16258 100644 --- a/mesh/pb-adv.c +++ b/mesh/pb-adv.c @@ -23,6 +23,8 @@ #include "mesh/provision.h" #include "mesh/pb-adv.h" +#include "mesh/util.h" + struct pb_adv_session { mesh_prov_open_func_t open_cb; @@ -158,7 +160,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, l_debug("max_seg: %2.2x", max_seg); l_debug("size: %2.2x, CRC: %2.2x", size, buf[9]); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, init_size + 10); consumed = init_size; @@ -174,7 +176,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, buf[6] = (i << 2) | 0x02; memcpy(buf + 7, data + consumed, seg_size); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, seg_size + 7); consumed += seg_size; @@ -270,7 +272,8 @@ static void send_ack(struct pb_adv_session *session, uint8_t trans_num) ack.trans_num = trans_num; ack.opcode = PB_ADV_ACK; - pb_adv_send(session, 1, 100, &ack, sizeof(ack)); + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, + &ack, sizeof(ack)); } static void send_close_ind(struct pb_adv_session *session, uint8_t reason) -- 2.37.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: Mesh demon switched to using kernel Mesh MGMT 2022-09-22 22:31 [PATCH BlueZ v4 1/2] mesh: Improve PB-ADV timing for reliability Brian Gix @ 2022-09-22 23:26 ` bluez.test.bot 0 siblings, 0 replies; 11+ messages in thread From: bluez.test.bot @ 2022-09-22 23:26 UTC (permalink / raw) To: linux-bluetooth, brian.gix [-- Attachment #1: Type: text/plain, Size: 1698 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679632 ---Test result--- Test Summary: CheckPatch PASS 4.12 seconds GitLint PASS 2.16 seconds Prep - Setup ELL PASS 26.03 seconds Build - Prep PASS 0.78 seconds Build - Configure PASS 8.19 seconds Build - Make PASS 719.47 seconds Make Check PASS 11.86 seconds Make Check w/Valgrind PASS 287.40 seconds Make Distcheck PASS 237.01 seconds Build w/ext ELL - Configure PASS 8.28 seconds Build w/ext ELL - Make PASS 83.69 seconds Incremental Build w/ patches PASS 197.42 seconds Scan Build WARNING 523.64 seconds Details ############################## Test: Scan Build - WARNING Desc: Run Scan Build with patches Output: ***************************************************************************** The bugs reported by the scan-build may or may not be caused by your patches. Please check the list and fix the bugs if they are caused by your patch. ***************************************************************************** mesh/mesh-io.c:118:18: warning: Access to field 'rx_regs' results in a dereference of a null pointer (loaded from variable 'io') l_queue_destroy(io->rx_regs, l_free); ^~~~~~~~~~~ 1 warning generated. --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH BlueZ v5 1/2] mesh: Improve PB-ADV timing for reliability @ 2022-09-23 18:00 Brian Gix 2022-09-23 19:24 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 0 siblings, 1 reply; 11+ messages in thread From: Brian Gix @ 2022-09-23 18:00 UTC (permalink / raw) To: linux-bluetooth; +Cc: luiz.dentz, brian.gix, inga.stotland Because provisioning is not speed dependent, Timing on outbound PB-ADV packets have been modified to be less likely missed by remote controlers with looser timing capabilities. --- mesh/pb-adv.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c index 83f922aa8..180b16258 100644 --- a/mesh/pb-adv.c +++ b/mesh/pb-adv.c @@ -23,6 +23,8 @@ #include "mesh/provision.h" #include "mesh/pb-adv.h" +#include "mesh/util.h" + struct pb_adv_session { mesh_prov_open_func_t open_cb; @@ -158,7 +160,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, l_debug("max_seg: %2.2x", max_seg); l_debug("size: %2.2x, CRC: %2.2x", size, buf[9]); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, init_size + 10); consumed = init_size; @@ -174,7 +176,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data, buf[6] = (i << 2) | 0x02; memcpy(buf + 7, data + consumed, seg_size); - pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200, + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, buf, seg_size + 7); consumed += seg_size; @@ -270,7 +272,8 @@ static void send_ack(struct pb_adv_session *session, uint8_t trans_num) ack.trans_num = trans_num; ack.opcode = PB_ADV_ACK; - pb_adv_send(session, 1, 100, &ack, sizeof(ack)); + pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500, + &ack, sizeof(ack)); } static void send_close_ind(struct pb_adv_session *session, uint8_t reason) -- 2.37.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: Mesh demon switched to using kernel Mesh MGMT 2022-09-23 18:00 [PATCH BlueZ v5 1/2] mesh: Improve PB-ADV timing for reliability Brian Gix @ 2022-09-23 19:24 ` bluez.test.bot 0 siblings, 0 replies; 11+ messages in thread From: bluez.test.bot @ 2022-09-23 19:24 UTC (permalink / raw) To: linux-bluetooth, brian.gix [-- Attachment #1: Type: text/plain, Size: 1052 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679972 ---Test result--- Test Summary: CheckPatch PASS 3.72 seconds GitLint PASS 1.59 seconds Prep - Setup ELL PASS 32.34 seconds Build - Prep PASS 0.80 seconds Build - Configure PASS 10.16 seconds Build - Make PASS 962.18 seconds Make Check PASS 13.10 seconds Make Check w/Valgrind PASS 346.94 seconds Make Distcheck PASS 288.02 seconds Build w/ext ELL - Configure PASS 10.29 seconds Build w/ext ELL - Make PASS 101.50 seconds Incremental Build w/ patches PASS 239.82 seconds Scan Build PASS 663.36 seconds --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-09-23 19:24 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-22 20:38 [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT Brian Gix 2022-09-22 20:38 ` [PATCH BlueZ 1/4] mgmt: Add support for Mesh in the kernel Brian Gix 2022-09-22 21:32 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 2022-09-22 20:38 ` [PATCH BlueZ 2/4] lib: Add defines of new MGMT opcodes and events Brian Gix 2022-09-22 20:38 ` [PATCH BlueZ 3/4] mesh: Improve PB-ADV timing for reliability Brian Gix 2022-09-22 20:38 ` [PATCH BlueZ 4/4] mesh: Add new kernel MGMT based IO transport Brian Gix 2022-09-22 21:20 ` [PATCH BlueZ 0/4] Mesh demon switched to using kernel Mesh MGMT patchwork-bot+bluetooth -- strict thread matches above, loose matches on Subject: below -- 2022-09-22 21:38 [PATCH BlueZ v2 1/2] mesh: Improve PB-ADV timing for reliability Brian Gix 2022-09-22 22:24 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 2022-09-22 21:40 [PATCH BlueZ v3 1/2] mesh: Improve PB-ADV timing for reliability Brian Gix 2022-09-22 22:26 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 2022-09-22 22:31 [PATCH BlueZ v4 1/2] mesh: Improve PB-ADV timing for reliability Brian Gix 2022-09-22 23:26 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot 2022-09-23 18:00 [PATCH BlueZ v5 1/2] mesh: Improve PB-ADV timing for reliability Brian Gix 2022-09-23 19:24 ` Mesh demon switched to using kernel Mesh MGMT bluez.test.bot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox