Re: [RESEND] Bluetooth: btrtl: Add support for RTL8852BS

Victor Hassan
2023-02-14T06:23:32Z

Dear Paul:
Thank you for your advises. I had send PATCH-v2 to fix it. Can you
give me more advises?

On 2023/2/6 18:03, Paul Menzel wrote:
> Dear Victor,
>
>
> Thank you for your patch.
>
> Am 06.02.23 um 07:33 schrieb Victor Hassan:
>> Add the support for RTL8852BS BT controller on UART interface.
>> The necessary firmware file will be submitted to linux-firmware.
>>
>> Signed-off-by: Victor Hassan <victor@allwinnertech.com>
>> ---
>>   drivers/bluetooth/btrtl.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
>> index 69c3fe649ca7..36c3a23324f8 100644
>> --- a/drivers/bluetooth/btrtl.c
>> +++ b/drivers/bluetooth/btrtl.c
>> @@ -198,6 +198,14 @@ static const struct id_table ic_id_table[] = {
>>         .fw_name  = "rtl_bt/rtl8852bu_fw.bin",
>>         .cfg_name = "rtl_bt/rtl8852bu_config" },
>> +    /* 8852B with UART interface */
>> +    { IC_INFO(RTL_ROM_LMP_8852A, 0xb, 0xb, HCI_UART),
>> +      .config_needed = true,
>> +      .has_rom_version = true,
>> +      .has_msft_ext = true,
>> +      .fw_name  = "rtl_bt/rtl8852bs_fw.bin",
>> +      .cfg_name = "rtl_bt/rtl8852bs_config" },
>> +
>
> I’d sort *bs* before *bu*.
>
>>       /* 8852C */
>>       { IC_INFO(RTL_ROM_LMP_8852A, 0xc, 0xc, HCI_USB),
>>         .config_needed = false,
>> @@ -965,5 +973,7 @@ MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");
>>   MODULE_FIRMWARE("rtl_bt/rtl8852au_config.bin");
>>   MODULE_FIRMWARE("rtl_bt/rtl8852bu_fw.bin");
>>   MODULE_FIRMWARE("rtl_bt/rtl8852bu_config.bin");
>> +MODULE_FIRMWARE("rtl_bt/rtl8852bs_fw.bin");
>> +MODULE_FIRMWARE("rtl_bt/rtl8852bs_config.bin");
>>   MODULE_FIRMWARE("rtl_bt/rtl8852cu_fw.bin");
>>   MODULE_FIRMWARE("rtl_bt/rtl8852cu_config.bin");
>
> Ditto.
>
>
> Kind regards,
>
> Paul