RE: [BlueZ,1/2] shared/shell: Add support for -i/--init-script

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 3090 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=732131

---Test result---

Test Summary:
CheckPatch                    FAIL      1.12 seconds
GitLint                       PASS      0.50 seconds
BuildEll                      PASS      26.12 seconds
BluezMake                     PASS      749.45 seconds
MakeCheck                     PASS      11.59 seconds
MakeDistcheck                 PASS      147.36 seconds
CheckValgrind                 PASS      240.08 seconds
CheckSmatch                   WARNING   320.64 seconds
bluezmakeextell               PASS      96.42 seconds
IncrementalBuild              PASS      1215.93 seconds
ScanBuild                     WARNING   956.22 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,1/2] shared/shell: Add support for -i/--init-script
ERROR:SPACING: space required after that ',' (ctx:VxV)
#155: FILE: src/shared/shell.c:1105:
+	{ "init-script",required_argument, 0, 'i' },
 	               ^

/github/workspace/src/src/13182074.patch total: 1 errors, 0 warnings, 302 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13182074.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c:615:21: warning: non-ANSI function declaration of function 'bt_shell_usage'src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c:615:21: warning: non-ANSI function declaration of function 'bt_shell_usage'src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c:615:21: warning: non-ANSI function declaration of function 'bt_shell_usage'
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
src/shared/shell.c:1171:19: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                        data.init_fd = open(optarg, O_RDONLY);
                                       ^~~~~~~~~~~~~~~~~~~~~~
src/shared/shell.c:1201:13: warning: Access to field 'options' results in a dereference of a null pointer (loaded from variable 'opt')
                        if (c != opt->options[index - offset].val) {
                                 ^~~~~~~~~~~~
2 warnings generated.



---
Regards,
Linux Bluetooth