[PATCH] configure: Fix check ell path for cross compiling

[PATCH] configure: Fix check ell path for cross compiling

[Rudi Heitbaum]

Use of AC_CHECK_FILE prevents cross compilation.
Instead use test to support cross compiling.

Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
---
 configure.ac | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index eff297960..bc7edfcd3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -298,9 +298,10 @@ if (test "${enable_external_ell}" = "yes"); then
 	AC_SUBST(ELL_LIBS)
 fi
 if (test "${enable_external_ell}" != "yes"); then
-	AC_CHECK_FILE(${srcdir}/ell/ell.h, dummy=yes,
-			AC_CHECK_FILE(${srcdir}/../ell/ell/ell.h, dummy=yes,
-				AC_MSG_ERROR(ELL source is required or use --enable-external-ell)))
+	if (test ! -f ${srcdir}/ell/ell.h) &&
+			(test ! -f ${srcdir}/../ell/ell/ell.h); then
+				AC_MSG_ERROR(ELL source is required or use --enable-external-ell)
+	fi
 fi
 AM_CONDITIONAL(EXTERNAL_ELL, test "${enable_external_ell}" = "yes" ||
 				(test "${enable_btpclient}" != "yes" &&
-- 
2.34.1

RE: configure: Fix check ell path for cross compiling

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=761714

---Test result---

Test Summary:
CheckPatch                    PASS      0.47 seconds
GitLint                       PASS      0.35 seconds
BuildEll                      PASS      27.33 seconds
BluezMake                     PASS      981.12 seconds
MakeCheck                     PASS      12.33 seconds
MakeDistcheck                 PASS      156.72 seconds
CheckValgrind                 PASS      257.33 seconds
CheckSmatch                   PASS      341.43 seconds
bluezmakeextell               PASS      103.52 seconds
IncrementalBuild              PASS      851.66 seconds
ScanBuild                     PASS      1060.78 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH] configure: Fix check ell path for cross compiling

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sat,  1 Jul 2023 04:12:52 +0000 you wrote:
> Use of AC_CHECK_FILE prevents cross compilation.
> Instead use test to support cross compiling.
> 
> Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
> ---
>  configure.ac | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Here is the summary with links:
  - configure: Fix check ell path for cross compiling
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c62a4cb55183

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html