[PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()

[PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()

[Yue Haibing]

This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
and never be implemented. 

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
v2: fix SOB and update commit log
---
 net/bluetooth/amp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
index 832764dfbfb3..97c87abd129f 100644
--- a/net/bluetooth/amp.h
+++ b/net/bluetooth/amp.h
@@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
 
 int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
 
-void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
 void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
 void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
 void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
-- 
2.34.1

RE: [v2,-next] Bluetooth: Remove unused declaration amp_read_loc_info()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2943 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=769893

---Test result---

Test Summary:
CheckPatch                    FAIL      0.82 seconds
GitLint                       FAIL      0.52 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      32.63 seconds
CheckAllWarning               PASS      35.23 seconds
CheckSparse                   PASS      39.91 seconds
CheckSmatch                   PASS      112.17 seconds
BuildKernel32                 PASS      30.89 seconds
TestRunnerSetup               PASS      469.75 seconds
TestRunner_l2cap-tester       PASS      21.85 seconds
TestRunner_iso-tester         PASS      40.19 seconds
TestRunner_bnep-tester        PASS      9.92 seconds
TestRunner_mgmt-tester        PASS      210.41 seconds
TestRunner_rfcomm-tester      PASS      15.05 seconds
TestRunner_sco-tester         PASS      15.97 seconds
TestRunner_ioctl-tester       PASS      16.89 seconds
TestRunner_mesh-tester        PASS      12.52 seconds
TestRunner_smp-tester         PASS      13.38 seconds
TestRunner_userchan-tester    PASS      10.43 seconds
IncrementalBuild              PASS      29.12 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v2,-next] Bluetooth: Remove unused declaration amp_read_loc_info()
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#52: 
This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")

total: 0 errors, 1 warnings, 0 checks, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13328661.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v2,-next] Bluetooth: Remove unused declaration amp_read_loc_info()

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
3: B1 Line exceeds max length (95>80): "This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")"
4: B2 Line has trailing whitespace: "and never be implemented. "


---
Regards,
Linux Bluetooth

Re: [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()

[Luiz Augusto von Dentz]

Hi Yue,

On Wed, Jul 26, 2023 at 6:42 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
> and never be implemented.

The commit information above shall be added with Fixes: tag so it can
be properly backported, etc.

> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> v2: fix SOB and update commit log
> ---
>  net/bluetooth/amp.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
> index 832764dfbfb3..97c87abd129f 100644
> --- a/net/bluetooth/amp.h
> +++ b/net/bluetooth/amp.h
> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>
>  int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>
> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
>  void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>  void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>  void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
> --
> 2.34.1
>


-- 
Luiz Augusto von Dentz

Re: [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()

[YueHaibing]

On 2023/7/28 6:21, Luiz Augusto von Dentz wrote:
> Hi Yue,
> 
> On Wed, Jul 26, 2023 at 6:42 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>>
>> This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
>> and never be implemented.
> 
> The commit information above shall be added with Fixes: tag so it can
> be properly backported, etc.

Ok, v3 on the way.
> 
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>> v2: fix SOB and update commit log
>> ---
>>  net/bluetooth/amp.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
>> index 832764dfbfb3..97c87abd129f 100644
>> --- a/net/bluetooth/amp.h
>> +++ b/net/bluetooth/amp.h
>> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>>
>>  int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>>
>> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
>>  void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>>  void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>>  void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
>> --
>> 2.34.1
>>
> 
>