From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Hemantg <hemantg@codeaurora.org>
Subject: Re: [PATCH] Bluetooth: hci_qca: Remove redundant initializations to zero
Date: Wed, 06 Mar 2019 11:14:33 +0530 [thread overview]
Message-ID: <64c92d9b653786e4e35952c1c37e0718@codeaurora.org> (raw)
In-Reply-To: <20190305210412.98323-1-mka@chromium.org>
On 2019-03-06 02:34, Matthias Kaehlcke wrote:
> The qca_data structure is allocated with kzalloc() and hence
> zero-initialized. Remove a bunch of unnecessary explicit
> initializations of struct members to zero.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/bluetooth/hci_qca.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 237aea34b69f1..8dccbb934e384 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -480,26 +480,7 @@ static int qca_open(struct hci_uart *hu)
> qca->tx_ibs_state = HCI_IBS_TX_ASLEEP;
> qca->rx_ibs_state = HCI_IBS_RX_ASLEEP;
>
> - /* clocks actually on, but we start votes off */
> - qca->tx_vote = false;
> - qca->rx_vote = false;
> - qca->flags = 0;
> -
> - qca->ibs_sent_wacks = 0;
> - qca->ibs_sent_slps = 0;
> - qca->ibs_sent_wakes = 0;
> - qca->ibs_recv_wacks = 0;
> - qca->ibs_recv_slps = 0;
> - qca->ibs_recv_wakes = 0;
> qca->vote_last_jif = jiffies;
> - qca->vote_on_ms = 0;
> - qca->vote_off_ms = 0;
> - qca->votes_on = 0;
> - qca->votes_off = 0;
> - qca->tx_votes_on = 0;
> - qca->tx_votes_off = 0;
> - qca->rx_votes_on = 0;
> - qca->rx_votes_off = 0;
>
> hu->priv = qca;
Reviewed-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
--
Regards
Balakrishna.
prev parent reply other threads:[~2019-03-06 5:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 21:04 [PATCH] Bluetooth: hci_qca: Remove redundant initializations to zero Matthias Kaehlcke
2019-03-06 5:44 ` Balakrishna Godavarthi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c92d9b653786e4e35952c1c37e0718@codeaurora.org \
--to=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).