* [PATCH v2] bluetooth: Add device 0bda:4853 to device tables
@ 2023-08-09 1:04 Larry Finger
2023-08-09 2:24 ` [v2] " bluez.test.bot
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Larry Finger @ 2023-08-09 1:04 UTC (permalink / raw)
To: Marcel Holtmann, Gustavo Padovan, Johan Hedberg
Cc: linux-bluetooth, Hilda Wu, Larry Finger, stable
This device is part of a Realtek RTW8852BE chip. The device table
is as follows:
T: Bus=03 Lev=01 Prnt=01 Port=09 Cnt=03 Dev#= 4 Spd=12 MxCh= 0
D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0bda ProdID=4853 Rev= 0.00
S: Manufacturer=Realtek
S: Product=Bluetooth Radio
S: SerialNumber=00e04c000001
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
Cc: stable@vger.kernel.org
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
v2 - fix too long line in description
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 764d176e9735..1019f19d86a7 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -540,6 +540,8 @@ static const struct usb_device_id blacklist_table[] = {
/* Realtek 8852BE Bluetooth devices */
{ USB_DEVICE(0x0cb8, 0xc559), .driver_info = BTUSB_REALTEK |
BTUSB_WIDEBAND_SPEECH },
+ { USB_DEVICE(0x0bda, 0x4853), .driver_info = BTUSB_REALTEK |
+ BTUSB_WIDEBAND_SPEECH },
{ USB_DEVICE(0x0bda, 0x887b), .driver_info = BTUSB_REALTEK |
BTUSB_WIDEBAND_SPEECH },
{ USB_DEVICE(0x13d3, 0x3571), .driver_info = BTUSB_REALTEK |
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [v2] bluetooth: Add device 0bda:4853 to device tables
2023-08-09 1:04 [PATCH v2] bluetooth: Add device 0bda:4853 to device tables Larry Finger
@ 2023-08-09 2:24 ` bluez.test.bot
2023-08-09 5:58 ` [PATCH v2] " Paul Menzel
2023-08-11 17:30 ` patchwork-bot+bluetooth
2 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2023-08-09 2:24 UTC (permalink / raw)
To: linux-bluetooth, Larry.Finger
[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=774317
---Test result---
Test Summary:
CheckPatch PASS 0.68 seconds
GitLint PASS 0.33 seconds
SubjectPrefix FAIL 0.31 seconds
BuildKernel PASS 32.44 seconds
CheckAllWarning PASS 35.90 seconds
CheckSparse PASS 40.84 seconds
CheckSmatch PASS 113.59 seconds
BuildKernel32 PASS 31.60 seconds
TestRunnerSetup PASS 478.91 seconds
TestRunner_l2cap-tester PASS 22.21 seconds
TestRunner_iso-tester PASS 45.12 seconds
TestRunner_bnep-tester PASS 10.05 seconds
TestRunner_mgmt-tester PASS 212.22 seconds
TestRunner_rfcomm-tester PASS 15.32 seconds
TestRunner_sco-tester PASS 18.29 seconds
TestRunner_ioctl-tester PASS 17.10 seconds
TestRunner_mesh-tester PASS 12.73 seconds
TestRunner_smp-tester PASS 13.63 seconds
TestRunner_userchan-tester PASS 10.51 seconds
IncrementalBuild PASS 30.03 seconds
Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] bluetooth: Add device 0bda:4853 to device tables
2023-08-09 1:04 [PATCH v2] bluetooth: Add device 0bda:4853 to device tables Larry Finger
2023-08-09 2:24 ` [v2] " bluez.test.bot
@ 2023-08-09 5:58 ` Paul Menzel
2023-08-09 17:41 ` Larry Finger
2023-08-11 17:30 ` patchwork-bot+bluetooth
2 siblings, 1 reply; 5+ messages in thread
From: Paul Menzel @ 2023-08-09 5:58 UTC (permalink / raw)
To: Larry Finger
Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg, linux-bluetooth,
Hilda Wu, stable
Dear Larry,
Thank you for your patch.
Am 09.08.23 um 03:04 schrieb Larry Finger:
> This device is part of a Realtek RTW8852BE chip. The device table
> is as follows:
[…]
> Cc: stable@vger.kernel.org
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> v2 - fix too long line in description
You also need to start with a capital letter: Bluetooth.
Also, I’d be more specific in the commit message summary. Maybe:
Bluetooth: Flag RTL 0bda:4853 to support wide band speech
> ---
> drivers/bluetooth/btusb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 764d176e9735..1019f19d86a7 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -540,6 +540,8 @@ static const struct usb_device_id blacklist_table[] = {
(Unrelated, although it’s named `blacklist_table`, it evolved to a quirk
table?
> /* Realtek 8852BE Bluetooth devices */
> { USB_DEVICE(0x0cb8, 0xc559), .driver_info = BTUSB_REALTEK |
> BTUSB_WIDEBAND_SPEECH },
> + { USB_DEVICE(0x0bda, 0x4853), .driver_info = BTUSB_REALTEK |
> + BTUSB_WIDEBAND_SPEECH },
> { USB_DEVICE(0x0bda, 0x887b), .driver_info = BTUSB_REALTEK |
> BTUSB_WIDEBAND_SPEECH },
> { USB_DEVICE(0x13d3, 0x3571), .driver_info = BTUSB_REALTEK |
Kind regards,
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] bluetooth: Add device 0bda:4853 to device tables
2023-08-09 5:58 ` [PATCH v2] " Paul Menzel
@ 2023-08-09 17:41 ` Larry Finger
0 siblings, 0 replies; 5+ messages in thread
From: Larry Finger @ 2023-08-09 17:41 UTC (permalink / raw)
To: Paul Menzel
Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg, linux-bluetooth,
Hilda Wu, stable
On 8/9/23 00:58, Paul Menzel wrote:
> Dear Larry,
>
>
> Thank you for your patch.
>
> Am 09.08.23 um 03:04 schrieb Larry Finger:
>> This device is part of a Realtek RTW8852BE chip. The device table
>> is as follows:
>
> […]
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>> v2 - fix too long line in description
>
> You also need to start with a capital letter: Bluetooth.
>
> Also, I’d be more specific in the commit message summary. Maybe:
>
> Bluetooth: Flag RTL 0bda:4853 to support wide band speech
No, that one is not better. The intent is to let the device be driven by btrtl,
not btusb. I changed it to "Bluetooth: Add device 0bda:4853 to blacklist/quirk
table."
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] bluetooth: Add device 0bda:4853 to device tables
2023-08-09 1:04 [PATCH v2] bluetooth: Add device 0bda:4853 to device tables Larry Finger
2023-08-09 2:24 ` [v2] " bluez.test.bot
2023-08-09 5:58 ` [PATCH v2] " Paul Menzel
@ 2023-08-11 17:30 ` patchwork-bot+bluetooth
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+bluetooth @ 2023-08-11 17:30 UTC (permalink / raw)
To: Larry Finger
Cc: marcel, gustavo, johan.hedberg, linux-bluetooth, hildawu, stable
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Tue, 8 Aug 2023 20:04:03 -0500 you wrote:
> This device is part of a Realtek RTW8852BE chip. The device table
> is as follows:
>
> T: Bus=03 Lev=01 Prnt=01 Port=09 Cnt=03 Dev#= 4 Spd=12 MxCh= 0
> D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=0bda ProdID=4853 Rev= 0.00
> S: Manufacturer=Realtek
> S: Product=Bluetooth Radio
> S: SerialNumber=00e04c000001
> C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
> E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
> E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
>
> [...]
Here is the summary with links:
- [v2] bluetooth: Add device 0bda:4853 to device tables
https://git.kernel.org/bluetooth/bluetooth-next/c/0ae8f7d53554
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-11 17:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-09 1:04 [PATCH v2] bluetooth: Add device 0bda:4853 to device tables Larry Finger
2023-08-09 2:24 ` [v2] " bluez.test.bot
2023-08-09 5:58 ` [PATCH v2] " Paul Menzel
2023-08-09 17:41 ` Larry Finger
2023-08-11 17:30 ` patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox