[PATCH] Bluetooth: btusb: Fix quirks table naming

[PATCH] Bluetooth: btusb: Fix quirks table naming

[Bastien Nocera]

The quirks table was named "blacklist_table" which isn't a good
description for that table as devices detected using it weren't ignored
by the driver.

Rename the table to match what it actually does.

Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
 drivers/bluetooth/btusb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 764d176e9735..a1be66ef175c 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -175,7 +175,7 @@ static const struct usb_device_id btusb_table[] = {
 
 MODULE_DEVICE_TABLE(usb, btusb_table);
 
-static const struct usb_device_id blacklist_table[] = {
+static const struct usb_device_id quirks_table[] = {
 	/* CSR BlueCore devices */
 	{ USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
 
@@ -4113,7 +4113,7 @@ static int btusb_probe(struct usb_interface *intf,
 	if (!id->driver_info) {
 		const struct usb_device_id *match;
 
-		match = usb_match_id(intf, blacklist_table);
+		match = usb_match_id(intf, quirks_table);
 		if (match)
 			id = match;
 	}
-- 
2.41.0

Re: [PATCH] Bluetooth: btusb: Fix quirks table naming

[Paul Menzel]

Dear Bastian,


Thank you for the patch.

Am 22.08.23 um 12:20 schrieb Bastien Nocera:
> The quirks table was named "blacklist_table" which isn't a good
> description for that table as devices detected using it weren't ignored
> by the driver.
> 
> Rename the table to match what it actually does.

Maybe mention the new name also in the summary to be more specific? Maybe:

Bluetooth: btusb: Rename blacklist_table to quirks_table

> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> ---
>   drivers/bluetooth/btusb.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 764d176e9735..a1be66ef175c 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -175,7 +175,7 @@ static const struct usb_device_id btusb_table[] = {
>   
>   MODULE_DEVICE_TABLE(usb, btusb_table);
>   
> -static const struct usb_device_id blacklist_table[] = {
> +static const struct usb_device_id quirks_table[] = {
>   	/* CSR BlueCore devices */
>   	{ USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
>   
> @@ -4113,7 +4113,7 @@ static int btusb_probe(struct usb_interface *intf,
>   	if (!id->driver_info) {
>   		const struct usb_device_id *match;
>   
> -		match = usb_match_id(intf, blacklist_table);
> +		match = usb_match_id(intf, quirks_table);
>   		if (match)
>   			id = match;
>   	}

Thank you for doing this.

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

RE: Bluetooth: btusb: Fix quirks table naming

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=778167

---Test result---

Test Summary:
CheckPatch                    PASS      0.54 seconds
GitLint                       PASS      0.23 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      42.21 seconds
CheckAllWarning               PASS      40.29 seconds
CheckSparse                   PASS      44.94 seconds
CheckSmatch                   PASS      129.05 seconds
BuildKernel32                 PASS      34.84 seconds
TestRunnerSetup               PASS      557.30 seconds
TestRunner_l2cap-tester       PASS      33.48 seconds
TestRunner_iso-tester         PASS      77.29 seconds
TestRunner_bnep-tester        PASS      13.25 seconds
TestRunner_mgmt-tester        PASS      248.29 seconds
TestRunner_rfcomm-tester      PASS      19.17 seconds
TestRunner_sco-tester         PASS      25.49 seconds
TestRunner_ioctl-tester       PASS      24.16 seconds
TestRunner_mesh-tester        PASS      15.32 seconds
TestRunner_smp-tester         PASS      16.72 seconds
TestRunner_userchan-tester    PASS      14.04 seconds
IncrementalBuild              PASS      34.63 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: btusb: Fix quirks table naming

[Bastien Nocera]

On Tue, 2023-08-22 at 12:41 +0200, Paul Menzel wrote:
> Dear Bastian,
> 
> 
> Thank you for the patch.
> 
> Am 22.08.23 um 12:20 schrieb Bastien Nocera:
> > The quirks table was named "blacklist_table" which isn't a good
> > description for that table as devices detected using it weren't
> > ignored
> > by the driver.
> > 
> > Rename the table to match what it actually does.
> 
> Maybe mention the new name also in the summary to be more specific?
> Maybe:
> 
> Bluetooth: btusb: Rename blacklist_table to quirks_table

I think that's clear enough from the commit message itself.

> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> >   drivers/bluetooth/btusb.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 764d176e9735..a1be66ef175c 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -175,7 +175,7 @@ static const struct usb_device_id btusb_table[]
> > = {
> >   
> >   MODULE_DEVICE_TABLE(usb, btusb_table);
> >   
> > -static const struct usb_device_id blacklist_table[] = {
> > +static const struct usb_device_id quirks_table[] = {
> >         /* CSR BlueCore devices */
> >         { USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
> >   
> > @@ -4113,7 +4113,7 @@ static int btusb_probe(struct usb_interface
> > *intf,
> >         if (!id->driver_info) {
> >                 const struct usb_device_id *match;
> >   
> > -               match = usb_match_id(intf, blacklist_table);
> > +               match = usb_match_id(intf, quirks_table);
> >                 if (match)
> >                         id = match;
> >         }
> 
> Thank you for doing this.
> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul

Re: [PATCH] Bluetooth: btusb: Fix quirks table naming

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 22 Aug 2023 12:20:24 +0200 you wrote:
> The quirks table was named "blacklist_table" which isn't a good
> description for that table as devices detected using it weren't ignored
> by the driver.
> 
> Rename the table to match what it actually does.
> 
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> 
> [...]

Here is the summary with links:
  - Bluetooth: btusb: Fix quirks table naming
    https://git.kernel.org/bluetooth/bluetooth-next/c/5cef82c572a5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html