linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ 1/2] main.conf: Fix printing errors for valid options
@ 2023-09-07 19:41 Luiz Augusto von Dentz
  2023-09-07 19:41 ` [PATCH BlueZ 2/2] main.conf: Fix documention of CSIS.Encrypt Luiz Augusto von Dentz
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2023-09-07 19:41 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the following errors:

Unknown key RefreshDiscovery for group General
Unknown key Encryption for group CSIS

Fixes: https://github.com/bluez/bluez/issues/583
---
 src/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/main.c b/src/main.c
index 2134fcf752cf..b5a6f8e5562f 100644
--- a/src/main.c
+++ b/src/main.c
@@ -85,6 +85,7 @@ static const char *supported_options[] = {
 	"Privacy",
 	"JustWorksRepairing",
 	"TemporaryTimeout",
+	"RefreshDiscovery",
 	"Experimental",
 	"KernelExperimental",
 	"RemoteNameRequestRetryDelay",
@@ -149,6 +150,7 @@ static const char *gatt_options[] = {
 
 static const char *csip_options[] = {
 	"SIRK",
+	"Encryption",
 	"Size",
 	"Rank",
 	NULL
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH BlueZ 2/2] main.conf: Fix documention of CSIS.Encrypt
  2023-09-07 19:41 [PATCH BlueZ 1/2] main.conf: Fix printing errors for valid options Luiz Augusto von Dentz
@ 2023-09-07 19:41 ` Luiz Augusto von Dentz
  2023-09-07 21:20 ` [BlueZ,1/2] main.conf: Fix printing errors for valid options bluez.test.bot
  2023-09-07 23:00 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2023-09-07 19:41 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

CSIS.Encrypt is a boolean so it shall only be set with true/false not
yes/no.
---
 src/main.conf | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main.conf b/src/main.conf
index d108934a8ae9..085c81a462dd 100644
--- a/src/main.conf
+++ b/src/main.conf
@@ -270,10 +270,10 @@
 
 # SIRK Encryption
 # Possible values:
-# yes: Encrypt SIRK when read
-# no: Do not encrypt SIRK when read. (plaintext)
-# Defaults to yes
-#Encryption = yes
+# true: Encrypt SIRK when read
+# false: Do not encrypt SIRK when read. (plaintext)
+# Defaults to true
+#Encryption = true
 
 # Total no of sets belongs to this Profile
 # Defaults to 0
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [BlueZ,1/2] main.conf: Fix printing errors for valid options
  2023-09-07 19:41 [PATCH BlueZ 1/2] main.conf: Fix printing errors for valid options Luiz Augusto von Dentz
  2023-09-07 19:41 ` [PATCH BlueZ 2/2] main.conf: Fix documention of CSIS.Encrypt Luiz Augusto von Dentz
@ 2023-09-07 21:20 ` bluez.test.bot
  2023-09-07 23:00 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2023-09-07 21:20 UTC (permalink / raw)
  To: linux-bluetooth, luiz.dentz

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=782332

---Test result---

Test Summary:
CheckPatch                    PASS      0.97 seconds
GitLint                       PASS      0.71 seconds
BuildEll                      PASS      26.76 seconds
BluezMake                     PASS      775.48 seconds
MakeCheck                     PASS      11.57 seconds
MakeDistcheck                 PASS      155.78 seconds
CheckValgrind                 PASS      251.36 seconds
CheckSmatch                   PASS      340.71 seconds
bluezmakeextell               PASS      103.04 seconds
IncrementalBuild              PASS      1309.56 seconds
ScanBuild                     PASS      1018.30 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH BlueZ 1/2] main.conf: Fix printing errors for valid options
  2023-09-07 19:41 [PATCH BlueZ 1/2] main.conf: Fix printing errors for valid options Luiz Augusto von Dentz
  2023-09-07 19:41 ` [PATCH BlueZ 2/2] main.conf: Fix documention of CSIS.Encrypt Luiz Augusto von Dentz
  2023-09-07 21:20 ` [BlueZ,1/2] main.conf: Fix printing errors for valid options bluez.test.bot
@ 2023-09-07 23:00 ` patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2023-09-07 23:00 UTC (permalink / raw)
  To: Luiz Augusto von Dentz; +Cc: linux-bluetooth

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu,  7 Sep 2023 12:41:33 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes the following errors:
> 
> Unknown key RefreshDiscovery for group General
> Unknown key Encryption for group CSIS
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/2] main.conf: Fix printing errors for valid options
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=32daf644a497
  - [BlueZ,2/2] main.conf: Fix documention of CSIS.Encrypt
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3294c42c9677

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-07 23:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-07 19:41 [PATCH BlueZ 1/2] main.conf: Fix printing errors for valid options Luiz Augusto von Dentz
2023-09-07 19:41 ` [PATCH BlueZ 2/2] main.conf: Fix documention of CSIS.Encrypt Luiz Augusto von Dentz
2023-09-07 21:20 ` [BlueZ,1/2] main.conf: Fix printing errors for valid options bluez.test.bot
2023-09-07 23:00 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).