* RE: Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID
2023-09-06 9:33 [PATCH 1/1] " Claudia Draghicescu
@ 2023-09-06 10:41 ` bluez.test.bot
0 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2023-09-06 10:41 UTC (permalink / raw)
To: linux-bluetooth, claudia.rosu
[-- Attachment #1: Type: text/plain, Size: 2170 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=781929
---Test result---
Test Summary:
CheckPatch PASS 0.90 seconds
GitLint FAIL 0.62 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 40.41 seconds
CheckAllWarning PASS 44.74 seconds
CheckSparse WARNING 49.64 seconds
CheckSmatch PASS 133.86 seconds
BuildKernel32 PASS 38.81 seconds
TestRunnerSetup PASS 567.33 seconds
TestRunner_l2cap-tester PASS 29.57 seconds
TestRunner_iso-tester PASS 53.80 seconds
TestRunner_bnep-tester PASS 11.43 seconds
TestRunner_mgmt-tester PASS 233.86 seconds
TestRunner_rfcomm-tester PASS 17.39 seconds
TestRunner_sco-tester PASS 21.31 seconds
TestRunner_ioctl-tester PASS 19.66 seconds
TestRunner_mesh-tester PASS 14.77 seconds
TestRunner_smp-tester PASS 15.49 seconds
TestRunner_userchan-tester PASS 12.22 seconds
IncrementalBuild PASS 31.29 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[1/1] Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
5: B2 Line has trailing whitespace: " "
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/iso.c:1466:18: warning: dereference of noderef expression
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID
2023-09-07 5:47 [PATCH v2 1/1] " Claudia Draghicescu
@ 2023-09-07 16:43 ` bluez.test.bot
0 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2023-09-07 16:43 UTC (permalink / raw)
To: linux-bluetooth, claudia.rosu
[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=782236
---Test result---
Test Summary:
CheckPatch PASS 0.64 seconds
GitLint PASS 0.27 seconds
SubjectPrefix PASS 0.07 seconds
BuildKernel PASS 40.30 seconds
CheckAllWarning PASS 43.47 seconds
CheckSparse WARNING 50.52 seconds
CheckSmatch PASS 133.85 seconds
BuildKernel32 PASS 38.35 seconds
TestRunnerSetup PASS 584.14 seconds
TestRunner_l2cap-tester PASS 32.80 seconds
TestRunner_iso-tester PASS 69.82 seconds
TestRunner_bnep-tester PASS 13.16 seconds
TestRunner_mgmt-tester FAIL 253.41 seconds
TestRunner_rfcomm-tester PASS 19.74 seconds
TestRunner_sco-tester PASS 23.27 seconds
TestRunner_ioctl-tester PASS 22.30 seconds
TestRunner_mesh-tester PASS 16.38 seconds
TestRunner_smp-tester PASS 17.75 seconds
TestRunner_userchan-tester PASS 13.95 seconds
IncrementalBuild PASS 36.29 seconds
Details
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/iso.c:1466:18: warning: dereference of noderef expression
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 497, Passed: 496 (99.8%), Failed: 1, Not Run: 0
Failed Test Cases
LL Privacy - Unpair 1 Timed out 1.901 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 0/1] Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID
@ 2023-09-28 8:02 Claudia Draghicescu
2023-09-28 8:02 ` [PATCH v3 1/1] " Claudia Draghicescu
0 siblings, 1 reply; 5+ messages in thread
From: Claudia Draghicescu @ 2023-09-28 8:02 UTC (permalink / raw)
To: linux-bluetooth
Cc: iulia.tanasescu, mihai-octavian.urzica, silviu.barbulescu,
vlad.pruteanu, andrei.istodorescu, Claudia Draghicescu
Copy the content of a Periodic Advertisement Report to BASE only if
the service UUID is Basic Audio Announcement Service UUID.
Claudia Draghicescu (1):
Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID
net/bluetooth/iso.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
base-commit: c0c68490dadb598cc621f14e37d56c284e668267
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/1] Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID
2023-09-28 8:02 [PATCH v3 0/1] Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID Claudia Draghicescu
@ 2023-09-28 8:02 ` Claudia Draghicescu
2023-09-28 8:44 ` bluez.test.bot
0 siblings, 1 reply; 5+ messages in thread
From: Claudia Draghicescu @ 2023-09-28 8:02 UTC (permalink / raw)
To: linux-bluetooth
Cc: iulia.tanasescu, mihai-octavian.urzica, silviu.barbulescu,
vlad.pruteanu, andrei.istodorescu, Claudia Draghicescu
Copy the content of a Periodic Advertisement Report to BASE only if
the service UUID is Basic Audio Announcement Service UUID.
Signed-off-by: Claudia Draghicescu <claudia.rosu@nxp.com>
---
net/bluetooth/iso.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index 2132a16be93c..4f23b3a35faf 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -14,6 +14,7 @@
#include <net/bluetooth/bluetooth.h>
#include <net/bluetooth/hci_core.h>
#include <net/bluetooth/iso.h>
+#include "eir.h"
static const struct proto_ops iso_sock_ops;
@@ -47,6 +48,7 @@ static void iso_sock_kill(struct sock *sk);
#define EIR_SERVICE_DATA_LENGTH 4
#define BASE_MAX_LENGTH (HCI_MAX_PER_AD_LENGTH - EIR_SERVICE_DATA_LENGTH)
+#define EIR_BAA_SERVICE_UUID 0x1851
/* iso_pinfo flags values */
enum {
@@ -1461,6 +1463,8 @@ static int iso_sock_getsockopt(struct socket *sock, int level, int optname,
len = min_t(unsigned int, len, base_len);
if (copy_to_user(optval, base, len))
err = -EFAULT;
+ if (put_user(len, optlen))
+ err = -EFAULT;
break;
@@ -1783,12 +1787,18 @@ int iso_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags)
ev3 = hci_recv_event_data(hdev, HCI_EV_LE_PER_ADV_REPORT);
if (ev3) {
+ size_t base_len = ev3->length;
+ u8 *base;
+
sk = iso_get_sock_listen(&hdev->bdaddr, bdaddr,
iso_match_sync_handle_pa_report, ev3);
-
- if (sk) {
- memcpy(iso_pi(sk)->base, ev3->data, ev3->length);
- iso_pi(sk)->base_len = ev3->length;
+ base = eir_get_service_data(ev3->data, ev3->length,
+ EIR_BAA_SERVICE_UUID, &base_len);
+ if (base) {
+ if (sk) {
+ memcpy(iso_pi(sk)->base, base, base_len);
+ iso_pi(sk)->base_len = base_len;
+ }
}
} else {
sk = iso_get_sock_listen(&hdev->bdaddr, BDADDR_ANY, NULL, NULL);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID
2023-09-28 8:02 ` [PATCH v3 1/1] " Claudia Draghicescu
@ 2023-09-28 8:44 ` bluez.test.bot
0 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2023-09-28 8:44 UTC (permalink / raw)
To: linux-bluetooth, claudia.rosu
[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=788382
---Test result---
Test Summary:
CheckPatch PASS 0.65 seconds
GitLint PASS 0.25 seconds
SubjectPrefix PASS 0.07 seconds
BuildKernel PASS 40.58 seconds
CheckAllWarning PASS 44.55 seconds
CheckSparse PASS 50.68 seconds
CheckSmatch PASS 135.91 seconds
BuildKernel32 PASS 39.58 seconds
TestRunnerSetup PASS 594.11 seconds
TestRunner_l2cap-tester PASS 35.07 seconds
TestRunner_iso-tester PASS 68.93 seconds
TestRunner_bnep-tester PASS 12.57 seconds
TestRunner_mgmt-tester PASS 251.29 seconds
TestRunner_rfcomm-tester PASS 18.89 seconds
TestRunner_sco-tester PASS 21.87 seconds
TestRunner_ioctl-tester PASS 21.58 seconds
TestRunner_mesh-tester PASS 15.72 seconds
TestRunner_smp-tester PASS 16.76 seconds
TestRunner_userchan-tester PASS 13.24 seconds
IncrementalBuild PASS 36.76 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-28 8:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 8:02 [PATCH v3 0/1] Bluetooth: ISO: Copy BASE if service data matches EIR_BAA_SERVICE_UUID Claudia Draghicescu
2023-09-28 8:02 ` [PATCH v3 1/1] " Claudia Draghicescu
2023-09-28 8:44 ` bluez.test.bot
-- strict thread matches above, loose matches on Subject: below --
2023-09-07 5:47 [PATCH v2 1/1] " Claudia Draghicescu
2023-09-07 16:43 ` bluez.test.bot
2023-09-06 9:33 [PATCH 1/1] " Claudia Draghicescu
2023-09-06 10:41 ` bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).