* [PATCH BlueZ v2 0/1] Increase default obex timeout: 10 sec to 500 sec
@ 2023-10-20 9:37 Purendra Singh
2023-10-20 9:37 ` [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex timeout from " Purendra Singh
0 siblings, 1 reply; 6+ messages in thread
From: Purendra Singh @ 2023-10-20 9:37 UTC (permalink / raw)
To: linux-bluetooth
Cc: devyani.godbole, nitin.jadhav, luiz.dentz, pmenzel,
purendra.singh
Hello Maintainers,
This issue is observed when multiple profiles are active from
multiple connected devices: A2DP + HID + OBex File transfer
File received status of some reference devices is delayed,
that causes timeout and file transfer status error (Variation
of timeout is between ~100 seconds to ~450 seconds).
We tested with Motorola Edge, Samsung M33, OnePlus 6T.
Experimentaly we increased the timeout and at 500 seconds no issue was
observed.
Regards,
Purendra Singh
Purendra Singh (1):
gobex/gobex.c : Increase default obex timeout from 10 sec to 500 sec
gobex/gobex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex timeout from 10 sec to 500 sec
2023-10-20 9:37 [PATCH BlueZ v2 0/1] Increase default obex timeout: 10 sec to 500 sec Purendra Singh
@ 2023-10-20 9:37 ` Purendra Singh
2023-10-20 9:44 ` Paul Menzel
2023-10-20 11:15 ` Increase default obex timeout: " bluez.test.bot
0 siblings, 2 replies; 6+ messages in thread
From: Purendra Singh @ 2023-10-20 9:37 UTC (permalink / raw)
To: linux-bluetooth
Cc: devyani.godbole, nitin.jadhav, luiz.dentz, pmenzel,
purendra.singh
This issue is observed when multiple profiles are active from
multiple connected devices: A2DP + HID + OBex File transfer
File received status of some reference devices is delayed,
that causes timeout and file transfer status error (Variation
of timeout is between ~100 seconds to ~450 seconds).
We tested with Motorola Edge, Samsung M33, OnePlus 6T.
Experimentaly we increased the timeout and at 500 seconds no issue was
observed.
---
gobex/gobex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gobex/gobex.c b/gobex/gobex.c
index e9b89cead..f0e1c2c83 100644
--- a/gobex/gobex.c
+++ b/gobex/gobex.c
@@ -22,7 +22,7 @@
#define G_OBEX_MINIMUM_MTU 255
#define G_OBEX_MAXIMUM_MTU 65535
-#define G_OBEX_DEFAULT_TIMEOUT 10
+#define G_OBEX_DEFAULT_TIMEOUT 500
#define G_OBEX_ABORT_TIMEOUT 5
#define G_OBEX_OP_NONE 0xff
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex timeout from 10 sec to 500 sec
2023-10-20 9:37 ` [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex timeout from " Purendra Singh
@ 2023-10-20 9:44 ` Paul Menzel
2023-10-20 17:49 ` Luiz Augusto von Dentz
2023-10-20 11:15 ` Increase default obex timeout: " bluez.test.bot
1 sibling, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2023-10-20 9:44 UTC (permalink / raw)
To: Purendra Singh; +Cc: linux-bluetooth, devyani.godbole, nitin.jadhav, luiz.dentz
Dear Purendra,
Thank you for sending version 2. (No space is necessary in the prefix
before the colon.)
Am 20.10.23 um 11:37 schrieb Purendra Singh:
> This issue is observed when multiple profiles are active from
> multiple connected devices: A2DP + HID + OBex File transfer
>
> File received status of some reference devices is delayed,
> that causes timeout and file transfer status error (Variation
> of timeout is between ~100 seconds to ~450 seconds).
>
> We tested with Motorola Edge, Samsung M33, OnePlus 6T.
>
> Experimentaly we increased the timeout and at 500 seconds no issue was
Experimentally
> observed.
Oh, it’s really seconds. Isn’t greater than 8 minute timeout *not* very
user friendly?
> ---
> gobex/gobex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gobex/gobex.c b/gobex/gobex.c
> index e9b89cead..f0e1c2c83 100644
> --- a/gobex/gobex.c
> +++ b/gobex/gobex.c
> @@ -22,7 +22,7 @@
> #define G_OBEX_MINIMUM_MTU 255
> #define G_OBEX_MAXIMUM_MTU 65535
>
> -#define G_OBEX_DEFAULT_TIMEOUT 10
> +#define G_OBEX_DEFAULT_TIMEOUT 500
> #define G_OBEX_ABORT_TIMEOUT 5
>
> #define G_OBEX_OP_NONE 0xff
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: Increase default obex timeout: 10 sec to 500 sec
2023-10-20 9:37 ` [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex timeout from " Purendra Singh
2023-10-20 9:44 ` Paul Menzel
@ 2023-10-20 11:15 ` bluez.test.bot
1 sibling, 0 replies; 6+ messages in thread
From: bluez.test.bot @ 2023-10-20 11:15 UTC (permalink / raw)
To: linux-bluetooth, purendra.singh
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=795037
---Test result---
Test Summary:
CheckPatch PASS 0.52 seconds
GitLint FAIL 0.59 seconds
BuildEll PASS 28.17 seconds
BluezMake PASS 857.22 seconds
MakeCheck PASS 12.30 seconds
MakeDistcheck PASS 173.62 seconds
CheckValgrind PASS 270.50 seconds
CheckSmatch PASS 359.55 seconds
bluezmakeextell PASS 116.60 seconds
IncrementalBuild PASS 725.43 seconds
ScanBuild PASS 1075.10 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v2,1/1] gobex/gobex.c : Increase default obex timeout from 10 sec to 500 sec
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (83>80): "[BlueZ,v2,1/1] gobex/gobex.c : Increase default obex timeout from 10 sec to 500 sec"
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex timeout from 10 sec to 500 sec
2023-10-20 9:44 ` Paul Menzel
@ 2023-10-20 17:49 ` Luiz Augusto von Dentz
2023-10-31 12:10 ` [EXT] " Purendra Singh
0 siblings, 1 reply; 6+ messages in thread
From: Luiz Augusto von Dentz @ 2023-10-20 17:49 UTC (permalink / raw)
To: Paul Menzel
Cc: Purendra Singh, linux-bluetooth, devyani.godbole, nitin.jadhav
Hi,
On Fri, Oct 20, 2023 at 2:44 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Purendra,
>
>
> Thank you for sending version 2. (No space is necessary in the prefix
> before the colon.)
>
>
> Am 20.10.23 um 11:37 schrieb Purendra Singh:
> > This issue is observed when multiple profiles are active from
> > multiple connected devices: A2DP + HID + OBex File transfer
> >
> > File received status of some reference devices is delayed,
> > that causes timeout and file transfer status error (Variation
> > of timeout is between ~100 seconds to ~450 seconds).
> >
> > We tested with Motorola Edge, Samsung M33, OnePlus 6T.
> >
> > Experimentaly we increased the timeout and at 500 seconds no issue was
>
> Experimentally
>
> > observed.
>
> Oh, it’s really seconds. Isn’t greater than 8 minute timeout *not* very
> user friendly?
Yeah, something like that would probably cause the user to assume the
operation didn't work.
> > ---
> > gobex/gobex.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gobex/gobex.c b/gobex/gobex.c
> > index e9b89cead..f0e1c2c83 100644
> > --- a/gobex/gobex.c
> > +++ b/gobex/gobex.c
> > @@ -22,7 +22,7 @@
> > #define G_OBEX_MINIMUM_MTU 255
> > #define G_OBEX_MAXIMUM_MTU 65535
> >
> > -#define G_OBEX_DEFAULT_TIMEOUT 10
> > +#define G_OBEX_DEFAULT_TIMEOUT 500
> > #define G_OBEX_ABORT_TIMEOUT 5
> >
> > #define G_OBEX_OP_NONE 0xff
>
>
> Kind regards,
>
> Paul
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [EXT] Re: [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex timeout from 10 sec to 500 sec
2023-10-20 17:49 ` Luiz Augusto von Dentz
@ 2023-10-31 12:10 ` Purendra Singh
0 siblings, 0 replies; 6+ messages in thread
From: Purendra Singh @ 2023-10-31 12:10 UTC (permalink / raw)
To: Luiz Augusto von Dentz, Paul Menzel
Cc: linux-bluetooth@vger.kernel.org, Devyani Godbole, Nitin Jadhav
Hello Luiz and Paul,
> -----Original Message-----
> From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Sent: Friday, October 20, 2023 11:19 PM
> To: Paul Menzel <pmenzel@molgen.mpg.de>
> Cc: Purendra Singh <purendra.singh@nxp.com>; linux-
> bluetooth@vger.kernel.org; Devyani Godbole <devyani.godbole@nxp.com>;
> Nitin Jadhav <nitin.jadhav@nxp.com>
> Subject: [EXT] Re: [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default
> obex timeout from 10 sec to 500 sec
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> Hi,
>
> On Fri, Oct 20, 2023 at 2:44 AM Paul Menzel <pmenzel@molgen.mpg.de>
> wrote:
> >
> > Dear Purendra,
> >
> >
> > Thank you for sending version 2. (No space is necessary in the prefix
> > before the colon.)
> >
> >
> > Am 20.10.23 um 11:37 schrieb Purendra Singh:
> > > This issue is observed when multiple profiles are active from
> > > multiple connected devices: A2DP + HID + OBex File transfer
> > >
> > > File received status of some reference devices is delayed, that
> > > causes timeout and file transfer status error (Variation of timeout
> > > is between ~100 seconds to ~450 seconds).
> > >
> > > We tested with Motorola Edge, Samsung M33, OnePlus 6T.
> > >
> > > Experimentaly we increased the timeout and at 500 seconds no issue
> > > was
> >
> > Experimentally
> >
> > > observed.
> >
> > Oh, it’s really seconds. Isn’t greater than 8 minute timeout *not*
> > very user friendly?
>
> Yeah, something like that would probably cause the user to assume the
> operation didn't work.
This is the maximum timeout we have set based on experimenting
different reference devices mentioned in earlier comment.
This will only come into picture if the reference devices slow in
responding the file received status.
>
> > > ---
> > > gobex/gobex.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/gobex/gobex.c b/gobex/gobex.c index
> > > e9b89cead..f0e1c2c83 100644
> > > --- a/gobex/gobex.c
> > > +++ b/gobex/gobex.c
> > > @@ -22,7 +22,7 @@
> > > #define G_OBEX_MINIMUM_MTU 255
> > > #define G_OBEX_MAXIMUM_MTU 65535
> > >
> > > -#define G_OBEX_DEFAULT_TIMEOUT 10
> > > +#define G_OBEX_DEFAULT_TIMEOUT 500
> > > #define G_OBEX_ABORT_TIMEOUT 5
> > >
> > > #define G_OBEX_OP_NONE 0xff
> >
> >
> > Kind regards,
> >
> > Paul
>
>
>
> --
> Luiz Augusto von Dentz
Thanks
Purendra
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-31 12:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-20 9:37 [PATCH BlueZ v2 0/1] Increase default obex timeout: 10 sec to 500 sec Purendra Singh
2023-10-20 9:37 ` [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex timeout from " Purendra Singh
2023-10-20 9:44 ` Paul Menzel
2023-10-20 17:49 ` Luiz Augusto von Dentz
2023-10-31 12:10 ` [EXT] " Purendra Singh
2023-10-20 11:15 ` Increase default obex timeout: " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).