[PATCH BlueZ v1] shared/vcp: Fix build error

[PATCH BlueZ v1] shared/vcp: Fix build error

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the following build error in some architectures:

src/shared/vcp.c:961:24: error: lvalue required as unary ‘&’ operand
 961 |     iov.iov_base = &cpu_to_le32(vocs->vocs_audio_loc);
   |            ^
---
 src/shared/vcp.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/shared/vcp.c b/src/shared/vcp.c
index f2c04d184a08..06a22997a95c 100644
--- a/src/shared/vcp.c
+++ b/src/shared/vcp.c
@@ -956,13 +956,12 @@ static void vocs_voal_read(struct gatt_db_attribute *attrib,
 				void *user_data)
 {
 	struct bt_vocs *vocs = user_data;
-	struct iovec iov;
+	uint32_t loc;
 
-	iov.iov_base = &cpu_to_le32(vocs->vocs_audio_loc);
-	iov.iov_len = sizeof(vocs->vocs_audio_loc);
+	loc = cpu_to_le32(vocs->vocs_audio_loc);
 
-	gatt_db_attribute_read_result(attrib, id, 0, iov.iov_base,
-							iov.iov_len);
+	gatt_db_attribute_read_result(attrib, id, 0, (void *)&loc,
+							sizeof(loc));
 }
 
 static void vocs_voaodec_read(struct gatt_db_attribute *attrib,
-- 
2.43.0

RE: [BlueZ,v1] shared/vcp: Fix build error

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=805627

---Test result---

Test Summary:
CheckPatch                    PASS      0.48 seconds
GitLint                       PASS      0.31 seconds
BuildEll                      PASS      24.06 seconds
BluezMake                     PASS      555.08 seconds
MakeCheck                     PASS      11.16 seconds
MakeDistcheck                 PASS      149.66 seconds
CheckValgrind                 PASS      209.53 seconds
CheckSmatch                   PASS      317.03 seconds
bluezmakeextell               PASS      100.79 seconds
IncrementalBuild              PASS      535.91 seconds
ScanBuild                     PASS      924.61 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] shared/vcp: Fix build error

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 30 Nov 2023 09:10:40 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes the following build error in some architectures:
> 
> src/shared/vcp.c:961:24: error: lvalue required as unary ‘&’ operand
>  961 |     iov.iov_base = &cpu_to_le32(vocs->vocs_audio_loc);
>    |            ^
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] shared/vcp: Fix build error
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=cb1a3fd96c48

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html