[PATCH BlueZ v1] client/player: Fix not prompting all parameter on endpoint.register

[PATCH BlueZ v1] client/player: Fix not prompting all parameter on endpoint.register

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

When Auto Accept is not enable not all parameters are requested.
---
 client/player.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/client/player.c b/client/player.c
index 4673d2efece8..4d49602c70d7 100644
--- a/client/player.c
+++ b/client/player.c
@@ -2813,17 +2813,13 @@ static void endpoint_auto_accept(const char *input, void *user_data)
 		return;
 	} else if (!strcasecmp(input, "n") || !strcasecmp(input, "no")) {
 		ep->auto_accept = false;
+		bt_shell_prompt_input(ep->path, "Max Transports (auto/value):",
+						endpoint_max_transports, ep);
+		return;
 	} else {
 		bt_shell_printf("Invalid input for Auto Accept\n");
 		return bt_shell_noninteractive_quit(EXIT_FAILURE);
 	}
-
-	if (ep->broadcast)
-		bt_shell_prompt_input(ep->path, "BIG (auto/value):",
-					endpoint_iso_group, ep);
-	else
-		bt_shell_prompt_input(ep->path, "CIG (auto/value):",
-					endpoint_iso_group, ep);
 }
 
 static void endpoint_set_metadata(const char *input, void *user_data)
-- 
2.43.0

Re: [PATCH BlueZ v1] client/player: Fix not prompting all parameter on endpoint.register

[Paul Menzel]

Dear Luiz,


Am 07.12.23 um 19:47 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> When Auto Accept is not enable not all parameters are requested.

enable*d*

> ---
>   client/player.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/client/player.c b/client/player.c
> index 4673d2efece8..4d49602c70d7 100644
> --- a/client/player.c
> +++ b/client/player.c
> @@ -2813,17 +2813,13 @@ static void endpoint_auto_accept(const char *input, void *user_data)
>   		return;
>   	} else if (!strcasecmp(input, "n") || !strcasecmp(input, "no")) {
>   		ep->auto_accept = false;
> +		bt_shell_prompt_input(ep->path, "Max Transports (auto/value):",
> +						endpoint_max_transports, ep);
> +		return;
>   	} else {
>   		bt_shell_printf("Invalid input for Auto Accept\n");
>   		return bt_shell_noninteractive_quit(EXIT_FAILURE);
>   	}
> -
> -	if (ep->broadcast)
> -		bt_shell_prompt_input(ep->path, "BIG (auto/value):",
> -					endpoint_iso_group, ep);
> -	else
> -		bt_shell_prompt_input(ep->path, "CIG (auto/value):",
> -					endpoint_iso_group, ep);
>   }

Excuse my ignorance, but it’s not clear to me why *Max Transports* is 
now used instead of *BIG* or *CIG*, and what the code path is, that 
could not have led to one of the two prompts.

>   static void endpoint_set_metadata(const char *input, void *user_data)


Kind regards,

Paul

RE: [BlueZ,v1] client/player: Fix not prompting all parameter on endpoint.register

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=807969

---Test result---

Test Summary:
CheckPatch                    PASS      2.00 seconds
GitLint                       PASS      0.51 seconds
BuildEll                      PASS      24.16 seconds
BluezMake                     PASS      732.65 seconds
MakeCheck                     PASS      11.85 seconds
MakeDistcheck                 PASS      159.63 seconds
CheckValgrind                 PASS      217.54 seconds
CheckSmatch                   PASS      321.99 seconds
bluezmakeextell               PASS      103.06 seconds
IncrementalBuild              PASS      681.09 seconds
ScanBuild                     PASS      906.20 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] client/player: Fix not prompting all parameter on endpoint.register

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu,  7 Dec 2023 13:47:23 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> When Auto Accept is not enable not all parameters are requested.
> ---
>  client/player.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)

Here is the summary with links:
  - [BlueZ,v1] client/player: Fix not prompting all parameter on endpoint.register
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=477c41c683ea

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html