[PATCH] mpris-proxy: add --target to target a specific player

[PATCH] mpris-proxy: add --target to target a specific player

[Willow Barraco]

fixes: https://github.com/bluez/bluez/issues/709

Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
---
 tools/mpris-proxy.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/mpris-proxy.c b/tools/mpris-proxy.c
index e5fc91fdb..c7a22c121 100644
--- a/tools/mpris-proxy.c
+++ b/tools/mpris-proxy.c
@@ -53,6 +53,7 @@ static GSList *transports = NULL;
 
 static gboolean option_version = FALSE;
 static gboolean option_export = FALSE;
+static gchar *option_target = NULL;
 
 struct tracklist {
 	GDBusProxy *proxy;
@@ -428,6 +429,11 @@ static void add_player(DBusConnection *conn, const char *name,
 	if (!adapter)
 		return;
 
+	if (option_target && strcmp(name, option_target)) {
+		printf("Not the target player, skipped\n");
+		return;
+	}
+
 	player = find_player_by_bus_name(name);
 	if (player == NULL) {
 		reply = get_all(conn, name);
@@ -733,6 +739,8 @@ static GOptionEntry options[] = {
 				"Show version information and exit" },
 	{ "export", 'e', 0, G_OPTION_ARG_NONE, &option_export,
 				"Export remote players" },
+	{ "target", 't', 0, G_OPTION_ARG_STRING, &option_target,
+				"Target a specific player" },
 	{ NULL },
 };
 
-- 
2.43.0

RE: mpris-proxy: add --target to target a specific player

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=814860

---Test result---

Test Summary:
CheckPatch                    FAIL      0.67 seconds
GitLint                       PASS      0.35 seconds
BuildEll                      PASS      24.14 seconds
BluezMake                     PASS      729.72 seconds
MakeCheck                     PASS      11.64 seconds
MakeDistcheck                 PASS      161.70 seconds
CheckValgrind                 PASS      223.47 seconds
CheckSmatch                   PASS      328.29 seconds
bluezmakeextell               PASS      107.09 seconds
IncrementalBuild              PASS      658.87 seconds
ScanBuild                     PASS      950.21 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
mpris-proxy: add --target to target a specific player
ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#61: FILE: tools/mpris-proxy.c:56:
+static gchar *option_target = NULL;

/github/workspace/src/src/13512791.patch total: 1 errors, 0 warnings, 26 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13512791.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth