* [PATCH v1 1/1] Bluetooth: btnxpuart: Add handling for boot-signature timeout errors
@ 2024-03-14 12:29 Neeraj Kale
2024-03-14 13:08 ` [v1,1/1] " bluez.test.bot
0 siblings, 1 reply; 4+ messages in thread
From: Neeraj Kale @ 2024-03-14 12:29 UTC (permalink / raw)
To: marcel, luiz.dentz
Cc: amitkumar.karwar, rohit.fule, sherry.sun, LnxRevLi,
neeraj.sanjaykale, linux-kernel, linux-bluetooth
From: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
This handles the timeout errors seen in the bootloader signatures during
FW download.
When the bootloader does not receive a response packet from the host
within a specific time, it adds an error code to the bootloader
signature while requesting for the FW chunk from the same offset.
The host is expected to clear this error code with a NAK, and reply to
only those bootloader signatures which have error code 0.
This error handling is valid for data_req bootloader signatures for V3
and future bootloader versions.
Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
drivers/bluetooth/btnxpuart.c | 46 ++++++++++++++++++++++++++++++++---
1 file changed, 42 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 0b93c2ff29e4..2018513fb961 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -187,6 +187,10 @@ struct btnxpuart_dev {
#define NXP_NAK_V3 0x7b
#define NXP_CRC_ERROR_V3 0x7c
+#define NXP_ACK_RX_TIMEOUT 0x0002
+#define NXP_HDR_RX_TIMEOUT 0x0003
+#define NXP_DATA_RX_TIMEOUT 0x0004
+
#define HDR_LEN 16
#define NXP_RECV_CHIP_VER_V1 \
@@ -277,6 +281,12 @@ struct nxp_bootloader_cmd {
__be32 crc;
} __packed;
+struct nxp_v3_rx_timeout_nak {
+ u8 nak;
+ __le32 offset;
+ u8 crc;
+} __packed;
+
static u8 crc8_table[CRC8_TABLE_SIZE];
/* Default configurations */
@@ -899,6 +909,32 @@ static int nxp_recv_chip_ver_v3(struct hci_dev *hdev, struct sk_buff *skb)
return 0;
}
+static void nxp_handle_fw_dnld_error(struct hci_dev *hdev, struct v3_data_req *req)
+{
+ struct btnxpuart_dev *nxpdev = hci_get_drvdata(hdev);
+ __u32 offset = __le32_to_cpu(req->offset);
+ __u16 err = __le16_to_cpu(req->error);
+ struct nxp_v3_rx_timeout_nak nak_tx_buf;
+
+ switch (err) {
+ case NXP_ACK_RX_TIMEOUT:
+ case NXP_HDR_RX_TIMEOUT:
+ case NXP_DATA_RX_TIMEOUT:
+ nak_tx_buf.nak = NXP_NAK_V3;
+ nak_tx_buf.offset = __cpu_to_le32(offset);
+ nak_tx_buf.crc = crc8(crc8_table, (u8 *)&nak_tx_buf,
+ sizeof(nak_tx_buf) - 1, 0xff);
+ serdev_device_write_buf(nxpdev->serdev, (u8 *)&nak_tx_buf,
+ sizeof(nak_tx_buf));
+ break;
+ default:
+ bt_dev_dbg(hdev, "Unknown bootloader error: %d", err);
+ break;
+
+ }
+
+}
+
static int nxp_recv_fw_req_v3(struct hci_dev *hdev, struct sk_buff *skb)
{
struct btnxpuart_dev *nxpdev = hci_get_drvdata(hdev);
@@ -913,7 +949,12 @@ static int nxp_recv_fw_req_v3(struct hci_dev *hdev, struct sk_buff *skb)
if (!req || !nxpdev->fw)
goto free_skb;
- nxp_send_ack(NXP_ACK_V3, hdev);
+ if (!req->error) {
+ nxp_send_ack(NXP_ACK_V3, hdev);
+ } else {
+ nxp_handle_fw_dnld_error(hdev, req);
+ goto free_skb;
+ }
len = __le16_to_cpu(req->len);
@@ -940,9 +981,6 @@ static int nxp_recv_fw_req_v3(struct hci_dev *hdev, struct sk_buff *skb)
wake_up_interruptible(&nxpdev->fw_dnld_done_wait_q);
goto free_skb;
}
- if (req->error)
- bt_dev_dbg(hdev, "FW Download received err 0x%02x from chip",
- req->error);
offset = __le32_to_cpu(req->offset);
if (offset < nxpdev->fw_v3_offset_correction) {
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [v1,1/1] Bluetooth: btnxpuart: Add handling for boot-signature timeout errors
2024-03-14 12:29 [PATCH v1 1/1] Bluetooth: btnxpuart: Add handling for boot-signature timeout errors Neeraj Kale
@ 2024-03-14 13:08 ` bluez.test.bot
0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2024-03-14 13:08 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=835311
---Test result---
Test Summary:
CheckPatch PASS 0.69 seconds
GitLint PASS 0.32 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 28.19 seconds
CheckAllWarning PASS 30.79 seconds
CheckSparse PASS 36.74 seconds
CheckSmatch PASS 99.34 seconds
BuildKernel32 PASS 27.54 seconds
TestRunnerSetup PASS 513.49 seconds
TestRunner_l2cap-tester PASS 20.10 seconds
TestRunner_iso-tester FAIL 30.73 seconds
TestRunner_bnep-tester PASS 4.84 seconds
TestRunner_mgmt-tester PASS 108.19 seconds
TestRunner_rfcomm-tester PASS 8.62 seconds
TestRunner_sco-tester PASS 15.01 seconds
TestRunner_ioctl-tester PASS 7.88 seconds
TestRunner_mesh-tester PASS 5.88 seconds
TestRunner_smp-tester PASS 6.89 seconds
TestRunner_userchan-tester PASS 4.96 seconds
IncrementalBuild PASS 26.55 seconds
Details
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 117, Passed: 116 (99.1%), Failed: 1, Not Run: 0
Failed Test Cases
ISO Connect2 Suspend - Success Failed 4.208 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [v1,1/1] Bluetooth: btnxpuart: Add handling for boot-signature timeout errors
2024-05-14 9:09 [PATCH v1 1/1] " Neeraj Sanjay Kale
@ 2024-05-14 9:34 ` bluez.test.bot
0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2024-05-14 9:34 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 3015 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=853010
---Test result---
Test Summary:
CheckPatch PASS 1.04 seconds
GitLint PASS 0.34 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 30.32 seconds
CheckAllWarning PASS 33.07 seconds
CheckSparse PASS 38.71 seconds
CheckSmatch FAIL 36.07 seconds
BuildKernel32 PASS 28.88 seconds
TestRunnerSetup PASS 522.58 seconds
TestRunner_l2cap-tester PASS 20.37 seconds
TestRunner_iso-tester FAIL 39.42 seconds
TestRunner_bnep-tester PASS 4.73 seconds
TestRunner_mgmt-tester FAIL 118.58 seconds
TestRunner_rfcomm-tester PASS 7.32 seconds
TestRunner_sco-tester PASS 14.98 seconds
TestRunner_ioctl-tester PASS 7.74 seconds
TestRunner_mesh-tester PASS 6.21 seconds
TestRunner_smp-tester PASS 6.78 seconds
TestRunner_userchan-tester PASS 4.94 seconds
IncrementalBuild PASS 27.96 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 121 (99.2%), Failed: 1, Not Run: 0
Failed Test Cases
ISO Connect2 Suspend - Success Failed 10.194 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2
Failed Test Cases
LL Privacy - Set Device Flag 1 (Device Privacy) Failed 0.134 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [v1,1/1] Bluetooth: btnxpuart: Add handling for boot-signature timeout errors
2024-06-03 6:37 [PATCH v1 1/1] " Neeraj Sanjay Kale
@ 2024-06-03 7:32 ` bluez.test.bot
0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2024-06-03 7:32 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 2577 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=858161
---Test result---
Test Summary:
CheckPatch PASS 3.18 seconds
GitLint PASS 1.59 seconds
SubjectPrefix PASS 0.16 seconds
BuildKernel PASS 29.90 seconds
CheckAllWarning PASS 32.62 seconds
CheckSparse PASS 38.59 seconds
CheckSmatch FAIL 34.86 seconds
BuildKernel32 PASS 28.91 seconds
TestRunnerSetup PASS 524.43 seconds
TestRunner_l2cap-tester PASS 20.40 seconds
TestRunner_iso-tester PASS 28.57 seconds
TestRunner_bnep-tester PASS 4.83 seconds
TestRunner_mgmt-tester PASS 116.55 seconds
TestRunner_rfcomm-tester PASS 8.72 seconds
TestRunner_sco-tester PASS 15.00 seconds
TestRunner_ioctl-tester PASS 7.90 seconds
TestRunner_mesh-tester FAIL 6.14 seconds
TestRunner_smp-tester PASS 6.89 seconds
TestRunner_userchan-tester PASS 5.09 seconds
IncrementalBuild PASS 28.05 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 9 (90.0%), Failed: 1, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 2 Failed 0.094 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-03 7:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-14 12:29 [PATCH v1 1/1] Bluetooth: btnxpuart: Add handling for boot-signature timeout errors Neeraj Kale
2024-03-14 13:08 ` [v1,1/1] " bluez.test.bot
-- strict thread matches above, loose matches on Subject: below --
2024-05-14 9:09 [PATCH v1 1/1] " Neeraj Sanjay Kale
2024-05-14 9:34 ` [v1,1/1] " bluez.test.bot
2024-06-03 6:37 [PATCH v1 1/1] " Neeraj Sanjay Kale
2024-06-03 7:32 ` [v1,1/1] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).