[PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
This chip is present e.g. on muRata 1YN module.

Extend the binding with its DT compatible using fallback
compatible string to "brcm,bcm4329-bt" which seems to be
the oldest compatible device. This should also prevent the
growth of compatible string tables in drivers. The existing
block of compatible strings is retained.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-bluetooth@vger.kernel.org
Cc: netdev@vger.kernel.org
---
V2: - Introduce fallback compatible string
    - Reword the second half of commit message to reflect that
---
 .../bindings/net/broadcom-bluetooth.yaml      | 33 +++++++++++--------
 1 file changed, 19 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
index cc70b00c6ce57..4a1bfc2b35849 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
@@ -14,20 +14,25 @@ description:
 
 properties:
   compatible:
-    enum:
-      - brcm,bcm20702a1
-      - brcm,bcm4329-bt
-      - brcm,bcm4330-bt
-      - brcm,bcm4334-bt
-      - brcm,bcm43430a0-bt
-      - brcm,bcm43430a1-bt
-      - brcm,bcm43438-bt
-      - brcm,bcm4345c5
-      - brcm,bcm43540-bt
-      - brcm,bcm4335a0
-      - brcm,bcm4349-bt
-      - cypress,cyw4373a0-bt
-      - infineon,cyw55572-bt
+    oneOf:
+      - items:
+          - enum:
+              - infineon,cyw43439-bt
+          - const: brcm,bcm4329-bt
+      - enum:
+          - brcm,bcm20702a1
+          - brcm,bcm4329-bt
+          - brcm,bcm4330-bt
+          - brcm,bcm4334-bt
+          - brcm,bcm43430a0-bt
+          - brcm,bcm43430a1-bt
+          - brcm,bcm43438-bt
+          - brcm,bcm4345c5
+          - brcm,bcm43540-bt
+          - brcm,bcm4335a0
+          - brcm,bcm4349-bt
+          - cypress,cyw4373a0-bt
+          - infineon,cyw55572-bt
 
   shutdown-gpios:
     maxItems: 1
-- 
2.43.0

RE: [v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2129 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=836295

---Test result---

Test Summary:
CheckPatch                    PASS      0.60 seconds
GitLint                       PASS      0.29 seconds
SubjectPrefix                 FAIL      0.31 seconds
BuildKernel                   PASS      27.55 seconds
CheckAllWarning               PASS      30.43 seconds
CheckSparse                   PASS      36.01 seconds
CheckSmatch                   PASS      97.81 seconds
BuildKernel32                 PASS      26.87 seconds
TestRunnerSetup               PASS      504.25 seconds
TestRunner_l2cap-tester       PASS      17.87 seconds
TestRunner_iso-tester         FAIL      30.06 seconds
TestRunner_bnep-tester        PASS      4.74 seconds
TestRunner_mgmt-tester        FAIL      107.57 seconds
TestRunner_rfcomm-tester      PASS      7.29 seconds
TestRunner_sco-tester         PASS      14.91 seconds
TestRunner_ioctl-tester       PASS      7.72 seconds
TestRunner_mesh-tester        PASS      5.82 seconds
TestRunner_smp-tester         PASS      6.85 seconds
TestRunner_userchan-tester    PASS      4.91 seconds
IncrementalBuild              PASS      26.18 seconds

Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 117, Passed: 116 (99.1%), Failed: 1, Not Run: 0

Failed Test Cases
ISO Connect2 Suspend - Success                       Failed       4.221 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2

Failed Test Cases
LL Privacy - Add Device 6 (RL is full)               Failed       0.187 seconds


---
Regards,
Linux Bluetooth

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Krzysztof Kozlowski]

On 19/03/2024 05:20, Marek Vasut wrote:
> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> This chip is present e.g. on muRata 1YN module.
> 
> Extend the binding with its DT compatible using fallback
> compatible string to "brcm,bcm4329-bt" which seems to be
> the oldest compatible device. This should also prevent the
> growth of compatible string tables in drivers. The existing
> block of compatible strings is retained.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
> On 19/03/2024 05:20, Marek Vasut wrote:
>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>> This chip is present e.g. on muRata 1YN module.
>>
>> Extend the binding with its DT compatible using fallback
>> compatible string to "brcm,bcm4329-bt" which seems to be
>> the oldest compatible device. This should also prevent the
>> growth of compatible string tables in drivers. The existing
>> block of compatible strings is retained.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Is there any action necessary from me to get this applied ?

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Krzysztof Kozlowski]

On 29/04/2024 17:10, Marek Vasut wrote:
> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
>> On 19/03/2024 05:20, Marek Vasut wrote:
>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>>> This chip is present e.g. on muRata 1YN module.
>>>
>>> Extend the binding with its DT compatible using fallback
>>> compatible string to "brcm,bcm4329-bt" which seems to be
>>> the oldest compatible device. This should also prevent the
>>> growth of compatible string tables in drivers. The existing
>>> block of compatible strings is retained.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Is there any action necessary from me to get this applied ?

I recommend resending with proper PATCH prefix matching net-next
expectations.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

On 4/29/24 8:22 PM, Krzysztof Kozlowski wrote:
> On 29/04/2024 17:10, Marek Vasut wrote:
>> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
>>> On 19/03/2024 05:20, Marek Vasut wrote:
>>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>>>> This chip is present e.g. on muRata 1YN module.
>>>>
>>>> Extend the binding with its DT compatible using fallback
>>>> compatible string to "brcm,bcm4329-bt" which seems to be
>>>> the oldest compatible device. This should also prevent the
>>>> growth of compatible string tables in drivers. The existing
>>>> block of compatible strings is retained.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Is there any action necessary from me to get this applied ?
> 
> I recommend resending with proper PATCH prefix matching net-next
> expectations.

I don't think bluetooth is net-next , it has its own ML and its own 
'Bluetooth:' subject prefix. Its patchwork.k.o project also doesn't seem 
to contain many patches with 'net'/'net-next' prefix. Also DT bindings 
do not seem to use it per 'git log 
Documentation/devicetree/bindings/net/bluetooth/'. But the bot is 
complaining about the prefix. Hence my confusion.

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Luiz Augusto von Dentz]

Hi Marek,

On Mon, Apr 29, 2024 at 4:44 PM Marek Vasut <marex@denx.de> wrote:
>
> On 4/29/24 8:22 PM, Krzysztof Kozlowski wrote:
> > On 29/04/2024 17:10, Marek Vasut wrote:
> >> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
> >>> On 19/03/2024 05:20, Marek Vasut wrote:
> >>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> >>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> >>>> This chip is present e.g. on muRata 1YN module.
> >>>>
> >>>> Extend the binding with its DT compatible using fallback
> >>>> compatible string to "brcm,bcm4329-bt" which seems to be
> >>>> the oldest compatible device. This should also prevent the
> >>>> growth of compatible string tables in drivers. The existing
> >>>> block of compatible strings is retained.
> >>>>
> >>>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>>
> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> Is there any action necessary from me to get this applied ?
> >
> > I recommend resending with proper PATCH prefix matching net-next
> > expectations.
>
> I don't think bluetooth is net-next , it has its own ML and its own
> 'Bluetooth:' subject prefix. Its patchwork.k.o project also doesn't seem
> to contain many patches with 'net'/'net-next' prefix. Also DT bindings
> do not seem to use it per 'git log
> Documentation/devicetree/bindings/net/bluetooth/'. But the bot is
> complaining about the prefix. Hence my confusion.

Well usually we require Bluetooth: prefix to indicate this patch is
for bluetooth/bluetooth-next trees, or you can do via subject e.g.
[bluetooth-next v1...] otherwise it could be merged via other trees.

-- 
Luiz Augusto von Dentz

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

On 4/29/24 10:57 PM, Luiz Augusto von Dentz wrote:
> Hi Marek,

Hello Luiz,

> On Mon, Apr 29, 2024 at 4:44 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 4/29/24 8:22 PM, Krzysztof Kozlowski wrote:
>>> On 29/04/2024 17:10, Marek Vasut wrote:
>>>> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
>>>>> On 19/03/2024 05:20, Marek Vasut wrote:
>>>>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>>>>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>>>>>> This chip is present e.g. on muRata 1YN module.
>>>>>>
>>>>>> Extend the binding with its DT compatible using fallback
>>>>>> compatible string to "brcm,bcm4329-bt" which seems to be
>>>>>> the oldest compatible device. This should also prevent the
>>>>>> growth of compatible string tables in drivers. The existing
>>>>>> block of compatible strings is retained.
>>>>>>
>>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>>
>>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>
>>>> Is there any action necessary from me to get this applied ?
>>>
>>> I recommend resending with proper PATCH prefix matching net-next
>>> expectations.
>>
>> I don't think bluetooth is net-next , it has its own ML and its own
>> 'Bluetooth:' subject prefix. Its patchwork.k.o project also doesn't seem
>> to contain many patches with 'net'/'net-next' prefix. Also DT bindings
>> do not seem to use it per 'git log
>> Documentation/devicetree/bindings/net/bluetooth/'. But the bot is
>> complaining about the prefix. Hence my confusion.
> 
> Well usually we require Bluetooth: prefix to indicate this patch is
> for bluetooth/bluetooth-next trees, or you can do via subject e.g.
> [bluetooth-next v1...] otherwise it could be merged via other trees.

Thank you for clarification. Hopefully the V3 is better.

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Krzysztof Kozlowski]

On 29/04/2024 22:44, Marek Vasut wrote:
> On 4/29/24 8:22 PM, Krzysztof Kozlowski wrote:
>> On 29/04/2024 17:10, Marek Vasut wrote:
>>> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
>>>> On 19/03/2024 05:20, Marek Vasut wrote:
>>>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>>>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>>>>> This chip is present e.g. on muRata 1YN module.
>>>>>
>>>>> Extend the binding with its DT compatible using fallback
>>>>> compatible string to "brcm,bcm4329-bt" which seems to be
>>>>> the oldest compatible device. This should also prevent the
>>>>> growth of compatible string tables in drivers. The existing
>>>>> block of compatible strings is retained.
>>>>>
>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> Is there any action necessary from me to get this applied ?
>>
>> I recommend resending with proper PATCH prefix matching net-next
>> expectations.
> 
> I don't think bluetooth is net-next , it has its own ML and its own 

True, indeed. The net prefix confused me.

Best regards,
Krzysztof