RE: [v1] bluetoothctl: CCP client interface for bluetoothctl

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 9110 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=847132

---Test result---

Test Summary:
CheckPatch                    FAIL      1.41 seconds
GitLint                       PASS      0.32 seconds
BuildEll                      PASS      24.62 seconds
BluezMake                     FAIL      19.43 seconds
MakeCheck                     FAIL      36.99 seconds
MakeDistcheck                 PASS      177.53 seconds
CheckValgrind                 FAIL      16.26 seconds
CheckSmatch                   FAIL      24.48 seconds
bluezmakeextell               FAIL      14.41 seconds
IncrementalBuild              FAIL      19.79 seconds
ScanBuild                     FAIL      537.60 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v1] bluetoothctl: CCP client interface for bluetoothctl
ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#188: FILE: client/telephony_client.c:30:
+static GDBusProxy *default_call = NULL;

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#189: FILE: client/telephony_client.c:31:
+static GList *callList = NULL;

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#190: FILE: client/telephony_client.c:32:
+static GDBusClient *client = NULL;

/github/workspace/src/src/13640519.patch total: 3 errors, 0 warnings, 1238 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13640519.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: BluezMake - FAIL
Desc: Build BlueZ
Output:

src/shared/ccp.c:549:13: error: ‘ccp_cb_notify’ defined but not used [-Werror=unused-function]
  549 | static void ccp_cb_notify(uint16_t value_handle, const uint8_t *value,
      |             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8640: src/shared/libshared_mainloop_la-ccp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4660: all] Error 2
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:

src/shared/ccp.c:549:13: error: ‘ccp_cb_notify’ defined but not used [-Werror=unused-function]
  549 | static void ccp_cb_notify(uint16_t value_handle, const uint8_t *value,
      |             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8402: src/shared/libshared_glib_la-ccp.lo] Error 1
make: *** [Makefile:12216: check] Error 2
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:

src/shared/ccp.c:549:13: error: ‘ccp_cb_notify’ defined but not used [-Werror=unused-function]
  549 | static void ccp_cb_notify(uint16_t value_handle, const uint8_t *value,
      |             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8640: src/shared/libshared_mainloop_la-ccp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:12216: check] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:621:25: warning: Variable length array is used.
src/shared/gatt-server.c:720:25: warning: Variable length array is used.
src/shared/bap.c:282:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
src/shared/ccp.c:549:13: error: ‘ccp_cb_notify’ defined but not used [-Werror=unused-function]
  549 | static void ccp_cb_notify(uint16_t value_handle, const uint8_t *value,
      |             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8640: src/shared/libshared_mainloop_la-ccp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4660: all] Error 2
##############################
Test: bluezmakeextell - FAIL
Desc: Build Bluez with External ELL
Output:

src/shared/ccp.c:549:13: error: ‘ccp_cb_notify’ defined but not used [-Werror=unused-function]
  549 | static void ccp_cb_notify(uint16_t value_handle, const uint8_t *value,
      |             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8640: src/shared/libshared_mainloop_la-ccp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4660: all] Error 2
##############################
Test: IncrementalBuild - FAIL
Desc: Incremental build with the patches in the series
Output:
[v1] bluetoothctl: CCP client interface for bluetoothctl

src/shared/ccp.c:549:13: error: ‘ccp_cb_notify’ defined but not used [-Werror=unused-function]
  549 | static void ccp_cb_notify(uint16_t value_handle, const uint8_t *value,
      |             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8640: src/shared/libshared_mainloop_la-ccp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4660: all] Error 2
##############################
Test: ScanBuild - FAIL
Desc: Run Scan Build
Output:

src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
        gatt_db_unregister(op->client->db, op->db_id);
                           ^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
        discovery_op_complete(op, false, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1294:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1359:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1634:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1639:2: warning: Use of memory after it is freed
        discover_all(op);
        ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2143:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2151:8: warning: Use of memory after it is freed
                                                        discovery_op_ref(op),
                                                        ^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3240:2: warning: Use of memory after it is freed
        complete_write_long_op(req, success, 0, false);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3262:2: warning: Use of memory after it is freed
        request_unref(req);
        ^~~~~~~~~~~~~~~~~~
12 warnings generated.
src/shared/ccp.c:549:13: error: ‘ccp_cb_notify’ defined but not used [-Werror=unused-function]
  549 | static void ccp_cb_notify(uint16_t value_handle, const uint8_t *value,
      |             ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8640: src/shared/libshared_mainloop_la-ccp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4660: all] Error 2


---
Regards,
Linux Bluetooth