linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH Bluetooth v2 0/1] LE Create Connection command timeout changed to 20 secs
@ 2024-05-02  9:01 Mahesh Talewad
  2024-05-02  9:01 ` [PATCH Bluetooth v2 1/1] LE Create Connection command timeout increased " Mahesh Talewad
  2024-05-02 14:50 ` [PATCH Bluetooth v2 0/1] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 5+ messages in thread
From: Mahesh Talewad @ 2024-05-02  9:01 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: devyani.godbole, luiz.dentz, sarveshwar.bajaj, mahesh.talewad

Hello Maintainers,

On our DUT, we can see that the host issues create connection cancel
command after 4-sec if there is no connection complete event for
LE create connection cmd.
As per core spec v5.3 section 7.8.5, advertisement interval range is-

Advertising_Interval_Min
Default : 0x0800(1.28s)
Time Range: 20ms to 10.24s

Advertising_Interval_Max
Default : 0x0800(1.28s)
Time Range: 20ms to 10.24s

If the remote device is using adv interval of > 4 sec, it is 
difficult to make a connection with the current timeout value.
Also, with the default interval of 1.28 sec, we will get only
3 chances to capture the adv packets with the 4 sec window.
Hence we want to increase this timeout to 20sec.

Thank you in advance for your review.

Thanks and regards,
Mahesh Vithal Talewad

Mahesh Talewad (1):
  LE Create Connection command timeout increased to 20 secs

 include/net/bluetooth/hci.h | 1 -
 net/bluetooth/hci_core.c    | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH BlueZ v1 1/1] LE Create Connection command timeout increased to 20 secs from 4 secs
@ 2024-03-18 12:37 Mahesh Talewad
  2024-03-18 13:10 ` LE Create Connection command timeout changed to 20 secs bluez.test.bot
  0 siblings, 1 reply; 5+ messages in thread
From: Mahesh Talewad @ 2024-03-18 12:37 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: devyani.godbole, mahesh.talewad, luiz.dentz, sarveshwar.bajaj

 - As per specs LE Connection timeout is 20 secs but in implementation,
   it was 4 secs. Hence increased this timeout to 20 Secs.

Signed-off-by: Mahesh Talewad <mahesh.talewad@nxp.com>
---
 net/bluetooth/hci_event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 4ae224824012..06fe5f6b9546 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -6067,7 +6067,7 @@ static struct hci_conn *check_pending_le_conn(struct hci_dev *hdev,
 	}
 
 	conn = hci_connect_le(hdev, addr, addr_type, addr_resolved,
-			      BT_SECURITY_LOW, hdev->def_le_autoconnect_timeout,
+			      BT_SECURITY_LOW, HCI_LE_CONN_TIMEOUT,
 			      HCI_ROLE_MASTER);
 	if (!IS_ERR(conn)) {
 		/* If HCI_AUTO_CONN_EXPLICIT is set, conn is already owned
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-02 14:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-02  9:01 [PATCH Bluetooth v2 0/1] LE Create Connection command timeout changed to 20 secs Mahesh Talewad
2024-05-02  9:01 ` [PATCH Bluetooth v2 1/1] LE Create Connection command timeout increased " Mahesh Talewad
2024-05-02  9:33   ` LE Create Connection command timeout changed " bluez.test.bot
2024-05-02 14:50 ` [PATCH Bluetooth v2 0/1] " patchwork-bot+bluetooth
  -- strict thread matches above, loose matches on Subject: below --
2024-03-18 12:37 [PATCH BlueZ v1 1/1] LE Create Connection command timeout increased to 20 secs from 4 secs Mahesh Talewad
2024-03-18 13:10 ` LE Create Connection command timeout changed to 20 secs bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).