[PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373

[PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373

[Tim Harvey]

From: Scott Ehlert <ehlert@battelle.org>

CYW4373 devices soldered onto the PCB (non-removable),
use a UART connection for Bluetooth and the advertised btsdio
support as an SDIO function should be ignored.

Signed-off-by: Scott Ehlert <ehlert@battelle.org>
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 drivers/bluetooth/btsdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
index f19d31ee37ea..bc9631bddc40 100644
--- a/drivers/bluetooth/btsdio.c
+++ b/drivers/bluetooth/btsdio.c
@@ -298,6 +298,7 @@ static int btsdio_probe(struct sdio_func *func,
 		case SDIO_DEVICE_ID_BROADCOM_4345:
 		case SDIO_DEVICE_ID_BROADCOM_43455:
 		case SDIO_DEVICE_ID_BROADCOM_4356:
+		case SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373:
 			return -ENODEV;
 		}
 	}
-- 
2.25.1

RE: Bluetooth: btsdio: Do not bind to non-removable CYW4373

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2747 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=852863

---Test result---

Test Summary:
CheckPatch                    PASS      0.66 seconds
GitLint                       PASS      0.33 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      29.79 seconds
CheckAllWarning               PASS      32.82 seconds
CheckSparse                   PASS      38.17 seconds
CheckSmatch                   FAIL      36.10 seconds
BuildKernel32                 PASS      28.81 seconds
TestRunnerSetup               PASS      519.15 seconds
TestRunner_l2cap-tester       PASS      18.47 seconds
TestRunner_iso-tester         FAIL      31.44 seconds
TestRunner_bnep-tester        PASS      4.80 seconds
TestRunner_mgmt-tester        PASS      109.18 seconds
TestRunner_rfcomm-tester      PASS      7.23 seconds
TestRunner_sco-tester         PASS      14.97 seconds
TestRunner_ioctl-tester       PASS      9.75 seconds
TestRunner_mesh-tester        PASS      5.78 seconds
TestRunner_smp-tester         PASS      6.76 seconds
TestRunner_userchan-tester    PASS      4.85 seconds
IncrementalBuild              PASS      27.91 seconds

Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 121 (99.2%), Failed: 1, Not Run: 0

Failed Test Cases
ISO Connect2 Suspend - Success                       Failed       4.225 seconds


---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373

[Tim Harvey]

On Mon, May 13, 2024 at 9:22 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> From: Scott Ehlert <ehlert@battelle.org>
>
> CYW4373 devices soldered onto the PCB (non-removable),
> use a UART connection for Bluetooth and the advertised btsdio
> support as an SDIO function should be ignored.
>
> Signed-off-by: Scott Ehlert <ehlert@battelle.org>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  drivers/bluetooth/btsdio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
> index f19d31ee37ea..bc9631bddc40 100644
> --- a/drivers/bluetooth/btsdio.c
> +++ b/drivers/bluetooth/btsdio.c
> @@ -298,6 +298,7 @@ static int btsdio_probe(struct sdio_func *func,
>                 case SDIO_DEVICE_ID_BROADCOM_4345:
>                 case SDIO_DEVICE_ID_BROADCOM_43455:
>                 case SDIO_DEVICE_ID_BROADCOM_4356:
> +               case SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373:
>                         return -ENODEV;
>                 }
>         }
> --
> 2.25.1
>

Greetings,

It seems that this patch got archived due to failure of an automated
test. The failure doesn't appear to me to have anything to do with the
code change or perhaps I'm just not understanding the error:
https://patchwork.kernel.org/project/bluetooth/patch/20240513162200.2658571-1-tharvey@gateworks.com/

Is there something I need to do here?

Best Regards,

Tim