* RE: [v2] Bluetooth: btnxpuart: Enable Power Save feature on startup
2024-01-11 10:11 [PATCH v2] " Neeraj Sanjay Kale
@ 2024-01-11 12:41 ` bluez.test.bot
0 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2024-01-11 12:41 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=816155
---Test result---
Test Summary:
CheckPatch PASS 0.52 seconds
GitLint PASS 0.25 seconds
SubjectPrefix PASS 0.09 seconds
BuildKernel PASS 29.45 seconds
CheckAllWarning PASS 31.94 seconds
CheckSparse PASS 38.45 seconds
CheckSmatch PASS 102.87 seconds
BuildKernel32 PASS 28.02 seconds
TestRunnerSetup PASS 440.13 seconds
TestRunner_l2cap-tester PASS 23.18 seconds
TestRunner_iso-tester PASS 45.80 seconds
TestRunner_bnep-tester PASS 6.97 seconds
TestRunner_mgmt-tester PASS 165.97 seconds
TestRunner_rfcomm-tester PASS 10.82 seconds
TestRunner_sco-tester PASS 14.60 seconds
TestRunner_ioctl-tester PASS 12.11 seconds
TestRunner_mesh-tester PASS 11.16 seconds
TestRunner_smp-tester PASS 9.94 seconds
TestRunner_userchan-tester PASS 7.18 seconds
IncrementalBuild PASS 26.61 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [v2] Bluetooth: btnxpuart: Enable Power Save feature on startup
2024-03-04 17:07 [PATCH v2] " Neeraj Sanjay Kale
@ 2024-03-04 17:56 ` bluez.test.bot
0 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2024-03-04 17:56 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=832171
---Test result---
Test Summary:
CheckPatch PASS 0.62 seconds
GitLint PASS 0.29 seconds
SubjectPrefix PASS 0.10 seconds
BuildKernel PASS 28.12 seconds
CheckAllWarning PASS 31.50 seconds
CheckSparse PASS 36.84 seconds
CheckSmatch PASS 101.40 seconds
BuildKernel32 PASS 27.66 seconds
TestRunnerSetup PASS 508.70 seconds
TestRunner_l2cap-tester PASS 20.25 seconds
TestRunner_iso-tester PASS 32.80 seconds
TestRunner_bnep-tester PASS 4.75 seconds
TestRunner_mgmt-tester PASS 113.13 seconds
TestRunner_rfcomm-tester PASS 7.40 seconds
TestRunner_sco-tester PASS 14.92 seconds
TestRunner_ioctl-tester PASS 7.85 seconds
TestRunner_mesh-tester FAIL 6.11 seconds
TestRunner_smp-tester PASS 6.91 seconds
TestRunner_userchan-tester PASS 5.01 seconds
IncrementalBuild PASS 26.54 seconds
Details
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 9 (90.0%), Failed: 1, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Failed 0.104 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on startup
@ 2024-05-14 9:02 Neeraj Sanjay Kale
2024-05-14 9:34 ` [v2] " bluez.test.bot
2024-05-17 7:17 ` [PATCH v2] " Neeraj Sanjay Kale
0 siblings, 2 replies; 7+ messages in thread
From: Neeraj Sanjay Kale @ 2024-05-14 9:02 UTC (permalink / raw)
To: marcel, luiz.dentz
Cc: linux-bluetooth, linux-kernel, amitkumar.karwar, rohit.fule,
neeraj.sanjaykale, sherry.sun, ziniu.wang_1, haibo.chen, LnxRevLi
This sets the default power save mode setting to enabled.
The power save feature is now stable and stress test issues, such as the
TX timeout error, have been resolved.
commit c7ee0bc8db32 ("Bluetooth: btnxpuart: Resolve TX timeout error in
power save stress test")
With this setting, the driver will send the vendor command to FW at
startup, to enable power save feature.
User can disable this feature using the following vendor command:
hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE)
Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
v2: Corrected subject line. Added commit reference. (Paul Menzel)
drivers/bluetooth/btnxpuart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 7f88b6f52f26..42e929f0d141 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -281,7 +281,7 @@ static u8 crc8_table[CRC8_TABLE_SIZE];
/* Default configurations */
#define DEFAULT_H2C_WAKEUP_MODE WAKEUP_METHOD_BREAK
-#define DEFAULT_PS_MODE PS_MODE_DISABLE
+#define DEFAULT_PS_MODE PS_MODE_ENABLE
#define FW_INIT_BAUDRATE HCI_NXP_PRI_BAUDRATE
static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode,
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [v2] Bluetooth: btnxpuart: Enable Power Save feature on startup
2024-05-14 9:02 [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on startup Neeraj Sanjay Kale
@ 2024-05-14 9:34 ` bluez.test.bot
2024-05-17 7:17 ` [PATCH v2] " Neeraj Sanjay Kale
1 sibling, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2024-05-14 9:34 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 3095 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=853008
---Test result---
Test Summary:
CheckPatch PASS 0.71 seconds
GitLint PASS 0.35 seconds
SubjectPrefix PASS 0.14 seconds
BuildKernel PASS 30.78 seconds
CheckAllWarning PASS 32.99 seconds
CheckSparse PASS 38.39 seconds
CheckSmatch FAIL 37.57 seconds
BuildKernel32 PASS 29.48 seconds
TestRunnerSetup PASS 527.09 seconds
TestRunner_l2cap-tester PASS 20.57 seconds
TestRunner_iso-tester FAIL 33.71 seconds
TestRunner_bnep-tester PASS 4.82 seconds
TestRunner_mgmt-tester FAIL 110.89 seconds
TestRunner_rfcomm-tester PASS 7.37 seconds
TestRunner_sco-tester PASS 15.13 seconds
TestRunner_ioctl-tester PASS 7.72 seconds
TestRunner_mesh-tester PASS 5.85 seconds
TestRunner_smp-tester PASS 6.91 seconds
TestRunner_userchan-tester PASS 5.02 seconds
IncrementalBuild PASS 29.82 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 120 (98.4%), Failed: 2, Not Run: 0
Failed Test Cases
ISO Connect Suspend - Success Failed 4.189 seconds
ISO Connect2 Suspend - Success Failed 4.217 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2
Failed Test Cases
LL Privacy - Add Device 4 (2 Devices to AL) Failed 0.166 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on startup
2024-05-14 9:02 [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on startup Neeraj Sanjay Kale
2024-05-14 9:34 ` [v2] " bluez.test.bot
@ 2024-05-17 7:17 ` Neeraj Sanjay Kale
1 sibling, 0 replies; 7+ messages in thread
From: Neeraj Sanjay Kale @ 2024-05-17 7:17 UTC (permalink / raw)
To: Neeraj Sanjay Kale, marcel@holtmann.org, luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Amitkumar Karwar, Rohit Fule, Sherry Sun, Luke Wang, Bough Chen,
LnxRevLi
Hi Luiz,
If no further reviews, can we merge this?
Thanks,
Neeraj
> This sets the default power save mode setting to enabled.
>
> The power save feature is now stable and stress test issues, such as the TX
> timeout error, have been resolved.
> commit c7ee0bc8db32 ("Bluetooth: btnxpuart: Resolve TX timeout error in
> power save stress test")
>
> With this setting, the driver will send the vendor command to FW at startup,
> to enable power save feature.
>
> User can disable this feature using the following vendor command:
> hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE)
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> v2: Corrected subject line. Added commit reference. (Paul Menzel)
> drivers/bluetooth/btnxpuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
> index 7f88b6f52f26..42e929f0d141 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -281,7 +281,7 @@ static u8 crc8_table[CRC8_TABLE_SIZE];
>
> /* Default configurations */
> #define DEFAULT_H2C_WAKEUP_MODE WAKEUP_METHOD_BREAK
> -#define DEFAULT_PS_MODE PS_MODE_DISABLE
> +#define DEFAULT_PS_MODE PS_MODE_ENABLE
> #define FW_INIT_BAUDRATE HCI_NXP_PRI_BAUDRATE
>
> static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode,
> --
> 2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [v2] Bluetooth: btnxpuart: Enable Power Save feature on startup
2024-06-03 6:22 [PATCH v2] " Neeraj Sanjay Kale
@ 2024-06-03 7:00 ` bluez.test.bot
0 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2024-06-03 7:00 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 2827 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=858158
---Test result---
Test Summary:
CheckPatch PASS 1.02 seconds
GitLint PASS 0.34 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 29.80 seconds
CheckAllWarning PASS 33.19 seconds
CheckSparse PASS 38.79 seconds
CheckSmatch FAIL 37.14 seconds
BuildKernel32 PASS 30.76 seconds
TestRunnerSetup PASS 528.73 seconds
TestRunner_l2cap-tester PASS 20.63 seconds
TestRunner_iso-tester FAIL 35.71 seconds
TestRunner_bnep-tester PASS 4.90 seconds
TestRunner_mgmt-tester PASS 112.73 seconds
TestRunner_rfcomm-tester PASS 7.51 seconds
TestRunner_sco-tester PASS 15.14 seconds
TestRunner_ioctl-tester PASS 8.35 seconds
TestRunner_mesh-tester PASS 6.09 seconds
TestRunner_smp-tester PASS 7.02 seconds
TestRunner_userchan-tester PASS 5.44 seconds
IncrementalBuild PASS 28.39 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 116 (95.1%), Failed: 2, Not Run: 4
Failed Test Cases
ISO Connect Suspend - Success Failed 4.178 seconds
ISO Connect2 Suspend - Success Failed 4.224 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [v2] Bluetooth: btnxpuart: Enable Power Save feature on startup
2024-06-14 8:20 Neeraj Sanjay Kale
@ 2024-06-14 8:59 ` bluez.test.bot
0 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2024-06-14 8:59 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=861975
---Test result---
Test Summary:
CheckPatch PASS 1.18 seconds
GitLint PASS 0.29 seconds
SubjectPrefix PASS 0.98 seconds
BuildKernel PASS 30.37 seconds
CheckAllWarning PASS 33.05 seconds
CheckSparse PASS 41.71 seconds
CheckSmatch PASS 106.32 seconds
BuildKernel32 PASS 29.30 seconds
TestRunnerSetup PASS 527.09 seconds
TestRunner_l2cap-tester PASS 18.66 seconds
TestRunner_iso-tester PASS 33.50 seconds
TestRunner_bnep-tester PASS 5.28 seconds
TestRunner_mgmt-tester FAIL 112.58 seconds
TestRunner_rfcomm-tester PASS 7.56 seconds
TestRunner_sco-tester PASS 15.09 seconds
TestRunner_ioctl-tester PASS 8.47 seconds
TestRunner_mesh-tester PASS 6.10 seconds
TestRunner_smp-tester PASS 6.92 seconds
TestRunner_userchan-tester PASS 5.18 seconds
IncrementalBuild PASS 28.41 seconds
Details
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2
Failed Test Cases
LL Privacy - Add Device 7 (AL is full) Failed 0.197 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-06-14 8:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-14 9:02 [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on startup Neeraj Sanjay Kale
2024-05-14 9:34 ` [v2] " bluez.test.bot
2024-05-17 7:17 ` [PATCH v2] " Neeraj Sanjay Kale
-- strict thread matches above, loose matches on Subject: below --
2024-06-14 8:20 Neeraj Sanjay Kale
2024-06-14 8:59 ` [v2] " bluez.test.bot
2024-06-03 6:22 [PATCH v2] " Neeraj Sanjay Kale
2024-06-03 7:00 ` [v2] " bluez.test.bot
2024-03-04 17:07 [PATCH v2] " Neeraj Sanjay Kale
2024-03-04 17:56 ` [v2] " bluez.test.bot
2024-01-11 10:11 [PATCH v2] " Neeraj Sanjay Kale
2024-01-11 12:41 ` [v2] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).